From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Shi Hao <i.shihao.999@gmail.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "inux-scsi@vger.kernel.org" <inux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] target: substitute kmap() with kmap_local_page()
Date: Thu, 6 Nov 2025 06:42:32 +0000 [thread overview]
Message-ID: <df283f3a-5463-4696-a067-3a4a30498d6e@nvidia.com> (raw)
In-Reply-To: <20251101074137.98988-1-i.shihao.999@gmail.com>
On 11/1/25 00:41, Shi Hao wrote:
> There was a single use of kmap() which could be replaced with
> kmap_local_page() for better CPU contention and cache locality.
> kmap_local_page() ensures non-sleeping operation and provides
> better multi-core CPU scalability compared to kmap().
> Convert kmap() to kmap_local_page() following modern kernel
> coding practices.
>
> Signed-off-by: Shi Hao<i.shihao.999@gmail.com>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
prev parent reply other threads:[~2025-11-06 6:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-01 7:41 Shi Hao
2025-11-06 6:42 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df283f3a-5463-4696-a067-3a4a30498d6e@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=i.shihao.999@gmail.com \
--cc=inux-scsi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®