mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ray Jui <ray.jui@broadcom.com>
To: Scott Branden <scott.branden@broadcom.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org,
	Alex Barba <alex.barba@broadcom.com>,
	Oza Oza <oza.oza@broadcom.com>, Ray Jui <rjui@broadcom.com>
Subject: Re: [PATCH 07/12] PCI: iproc: Update iProc PCIe DT binding
Date: Mon, 24 Oct 2016 15:27:08 -0700	[thread overview]
Message-ID: <df28b5f4-7263-8288-39eb-d5ead6f7475d@broadcom.com> (raw)
In-Reply-To: <94ae3c67-d5ed-d736-6e17-036f3caf4eaa@broadcom.com>

Thanks! Will address both typos in the next revision. Waiting for 
feedback from Bjorn before sending out the next revision.

Ray

On 10/24/2016 3:24 PM, Scott Branden wrote:
> 2 spelling typos
>
> On 16-10-24 03:17 PM, Ray Jui wrote:
>> Remove the following outbound related device tree properties:
>> brcm,pcie-ob-window-size
>> brcm,pcie-ob-oarr-size
>>
>> The above two prperties are a bit duplicated in functions. In addition,
> properties typo
>> the next generation iProc PCIe controller has outbound mapping window
>> that
>> supports more than just two sizes, which cannot be properly supported by
>> these properties
>>
>> A better solution is to make the driver outbound mapping logic slightly
>> more inteligent so it can figure out how to configure the outbound
>> mapping
> intelligent typo
>> based on the 'ranges' specified in device tree and the number and sizes
>> of the outbound mapping windows that a particular revision of the iProc
>> PCIe controller can support
>>
>> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>> ---
>>  Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt | 7 -------
>>  1 file changed, 7 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
>> b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
>> index 071bbc2..f827b8d 100644
>> --- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
>> +++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
>> @@ -35,11 +35,6 @@ effective:
>>  Required:
>>  - brcm,pcie-ob-axi-offset: The offset from the AXI address to the
>> internal
>>  address used by the iProc PCIe core (not the PCIe address)
>> -- brcm,pcie-ob-window-size: The outbound address mapping window size
>> (in MB)
>> -
>> -Optional:
>> -- brcm,pcie-ob-oarr-size: Some iProc SoCs need the OARR size bit to
>> be set to
>> -increase the outbound window size
>>
>>  MSI support (optional):
>>
>> @@ -95,9 +90,7 @@ Example:
>>          phy-names = "pcie-phy";
>>
>>          brcm,pcie-ob;
>> -        brcm,pcie-ob-oarr-size;
>>          brcm,pcie-ob-axi-offset = <0x00000000>;
>> -        brcm,pcie-ob-window-size = <256>;
>>
>>          msi-parent = <&msi0>;
>>
>>

  reply	other threads:[~2016-10-24 22:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-24 22:17 [PATCH 00/12] Additional iProc PCIe host support/fixes Ray Jui
2016-10-24 22:17 ` [PATCH 01/12] PCI: iproc: Improve core register population Ray Jui
2016-10-24 22:17 ` [PATCH 02/12] PCI: iproc: Do not reset PAXC when initializing the driver Ray Jui
2016-10-24 22:17 ` [PATCH 03/12] PCI: iproc: Add BCMA type Ray Jui
2016-10-24 22:17 ` [PATCH 04/12] PCI: iproc: Fix exception with multi-function devices Ray Jui
2016-10-24 22:17 ` [PATCH 05/12] PCI: iproc: Update iProc PCIe DT binding Ray Jui
2016-10-24 22:17 ` [PATCH 06/12] PCI: iproc: Add PAXC v2 support Ray Jui
2016-10-24 22:17 ` [PATCH 07/12] PCI: iproc: Update iProc PCIe DT binding Ray Jui
2016-10-24 22:24   ` Scott Branden
2016-10-24 22:27     ` Ray Jui [this message]
2016-10-24 22:17 ` [PATCH 08/12] PCI: iproc: Making outbound mapping code more generic Ray Jui
2016-10-24 22:17 ` [PATCH 09/12] PCI: iproc: Update iProc PCIe DT binding Ray Jui
2016-10-24 22:17 ` [PATCH 10/12] PCI: iproc: Add inbound DMA mapping support Ray Jui
2016-10-24 22:17 ` [PATCH 11/12] PCI: iproc: Update iProc PCIe DT binding Ray Jui
2016-10-24 22:17 ` [PATCH 12/12] PCI: iproc: Add support for the next-gen PAXB controller Ray Jui
2016-10-24 22:30 ` [PATCH 00/12] Additional iProc PCIe host support/fixes Scott Branden
2016-10-24 22:31   ` Ray Jui
2016-10-24 22:52 ` Bjorn Helgaas
2016-10-24 22:54   ` Ray Jui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df28b5f4-7263-8288-39eb-d5ead6f7475d@broadcom.com \
    --to=ray.jui@broadcom.com \
    --cc=alex.barba@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=oza.oza@broadcom.com \
    --cc=rjui@broadcom.com \
    --cc=scott.branden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®