From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E424C433E2 for ; Sat, 5 Sep 2020 03:00:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4C8220791 for ; Sat, 5 Sep 2020 03:00:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728277AbgIEDAg (ORCPT ); Fri, 4 Sep 2020 23:00:36 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:43624 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726317AbgIEDAf (ORCPT ); Fri, 4 Sep 2020 23:00:35 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 895C5346DECBEDDD2514; Sat, 5 Sep 2020 11:00:32 +0800 (CST) Received: from [127.0.0.1] (10.174.179.81) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Sat, 5 Sep 2020 11:00:29 +0800 Subject: Re: [PATCH net-next] net/packet: Remove unused macro BLOCK_PRIV To: Willem de Bruijn CC: David Miller , Jakub Kicinski , "John Ogness" , Mao Wenan , , Arnd Bergmann , Colin King , Eric Dumazet , "Network Development" , linux-kernel References: <20200904130608.19869-1-wanghai38@huawei.com> From: "wanghai (M)" Message-ID: Date: Sat, 5 Sep 2020 11:00:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.81] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/9/4 21:26, Willem de Bruijn 写道: > On Fri, Sep 4, 2020 at 3:09 PM Wang Hai wrote: >> BPDU_TYPE_TCN is never used after it was introduced. >> So better to remove it. > This comment does not cover the patch contents. Otherwise the patch > looks good to me. Thanks for your review, I will revise this comment. >> Reported-by: Hulk Robot >> Signed-off-by: Wang Hai >> --- >> net/packet/af_packet.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c >> index da8254e680f9..c430672c6a67 100644 >> --- a/net/packet/af_packet.c >> +++ b/net/packet/af_packet.c >> @@ -177,7 +177,6 @@ static int packet_set_ring(struct sock *sk, union tpacket_req_u *req_u, >> #define BLOCK_LEN(x) ((x)->hdr.bh1.blk_len) >> #define BLOCK_SNUM(x) ((x)->hdr.bh1.seq_num) >> #define BLOCK_O2PRIV(x) ((x)->offset_to_priv) >> -#define BLOCK_PRIV(x) ((void *)((char *)(x) + BLOCK_O2PRIV(x))) >> >> struct packet_sock; >> static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev, >> -- >> 2.17.1 >> > . >