From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B13A63CE084 for ; Thu, 25 Jun 2026 10:22:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782382947; cv=none; b=n6YK/XB2sdxwZCzOdOHV8qLbXXH0hEgVep7wBlz26FDEKYtjiny5eBIiL5PikYItqErbBI5xiEmx51mflJK53PTsV1LVWALW0dwa/uPuqG1fthnKcC2vbettvVyD4WcQLf6vHVzXTdiEP8rSimm3YNdEg9Se6lP2zehZgz45+TI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782382947; c=relaxed/simple; bh=PUd3wa1z9wVw46F6JNtqqyfzu6JtX0osRRT07M2mB0g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YFYusKbQBCpnSc0woF/NZpBGMOO+/7xUxisNCIT2K09R4t7EKquH1zrKh+3RwllAw/OXFHwXGtitlXvEoP+jfzvu9aTgX7aOTxXTC90s6QfBdztBz8TLiQo85zX7+7mO2Ka7ZleXDVHteTryp4spKUx+XuqQ7mEQ63rl8+ZeCAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j6+gUzc5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WEAjm5QY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j6+gUzc5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WEAjm5QY" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65P9jwtj1371445 for ; Thu, 25 Jun 2026 10:22:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QKsIEUrVK0G2nIoOCPG0vvWvJmYCsY+ovNi5/n5tMP8=; b=j6+gUzc5lXVSNUD0 kXlMVtHC3fQPq0lxjmNUrXWVdBZPIs0itBiyQKGlKjBDFlDUikU024C/H8o93ELN VU6p4ZAA7/Jinjj0EizNoSl8bwVUz1gxSt5oQjruMXn3Du2/jHc5wyXnlwx2Cww6 rDmEvEygNI4jWAxY6ioh6CcVw/Ex3i31gHnixifCEwUfKvNQNF0eNBjztQMPpfpB 35MhHxYzxZNnqPCfGFt75MFA8uVPmblxQKRWONU1+ycunVZ0gdwPhMUPVLLlkGa2 eSSDN8RxAKTUI83o7awTdcnw7ihfjnlTfnN3mOli3d7UR6BlBwZ1gAPyAWGyAXKa 5D0Ohw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0ymv0r3n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Jun 2026 10:22:24 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8dd10a7e0ecso6361866d6.0 for ; Thu, 25 Jun 2026 03:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782382944; x=1782987744; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QKsIEUrVK0G2nIoOCPG0vvWvJmYCsY+ovNi5/n5tMP8=; b=WEAjm5QYwAz2E2R6nX7AE5zq3nTqdpBFbpmUX9jmjyBmRb3JLKNGQBmovyWxgBHbgv RDmKcgITR91zQZPs+17TSF4G83SW4hEVPFXT9O531bOPx/pFWPFKDnusF56zrTlALLwi rNNMjtFcTTTCSNrNZ/KbAC9/Vu34TYCOIDGki7RG2+58X8mdjpWUAThSgoFL7Si1svUG upMt/0ujhMD5goO0F49nZ1FS7cJ/X4zhjVU7rEVc70Hvy25iZ/L2Mr4e1l4N7LhDEkSp VqSwG4dPof3QumgDE0974luqjusnjme/aNG6bNFxiOEz4g2t1dwES6eV7iYHB9XlWYxY TNVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782382944; x=1782987744; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QKsIEUrVK0G2nIoOCPG0vvWvJmYCsY+ovNi5/n5tMP8=; b=SON88Gs3zX6gFt15y+5znQ7CxLjmYnFRciiYucoFfM/pJXoRv2Mo9GbjWBoxHlX23z v1VTrwKbZNvkmOzOt23tdE398mD2K/S/ARbNPV7CXR6rZ/W4pHS1r0DjSoSyXWvwt1Rd Xxv0g/OirplTa71OcJOx66HMzc5xFnYXHneZ9diiqo/ZMzE09Xx8QoVSh/65ja+Gx0K+ Kq8MwUnapsVYgBp7hM3HA/ApAItrfGQJesctOt9fF3qcMP1T8/TlaWtyFlS+gY8mbqgH 1wHJZS22eBJ/KtmAKqRrH2Cd5+qqrK7F2alL45xYxor9oPz9vPUyW2y1XAQxZCr3RPtT EC3g== X-Forwarded-Encrypted: i=1; AFNElJ9vsHPDW3DbDFrap9CZebG4JgSSsdy625BUM83a3YKJ/CBJa233XF5wHgD5bBDhLEjI61UE7cFQ85Nv/1g=@vger.kernel.org X-Gm-Message-State: AOJu0YySvOs/gjTUOgnGv1LTiwy2WxIxZYNw7jDAyd9edxY1u6+jSr1a gk3Df9E0aD1QmczaoBTAYlS1buoxgyBRb2rWgjNDuPM4PHzw5QRHpAEHNPZOxJ+o+0h5tcsraxL kpLf0K0XdvCc2HKa8JQ0okWHLP9ixYJgdagIM2bSgpMqVq4ZyTpqLGl/MxBiRamBC8qQ= X-Gm-Gg: AfdE7cn0zjhJKl6CM6u8ztiXUmGQMdg3/Q7Y1PI+qHd0qYlwfgKGMv3mwjUzbzg5DWl vwDp/2RtGp0ijfcBwDVq4Og4P+hCvkfk+6T3nb1zMPwdcI51g6oKVZ7dV0mjv7WUv05+QENC/IA WVF5JIgsych9EPaQ4OxidU3AYpV4wSyMI7mCELJWbw2oqRlIKmGaOlQyPLd3xrjJyL+7un4JakP N8bA9OgME15R27RWhTQQyt5FApi0tElaaXNsHkIJfTxIJTOiGYu+Xj82DcoeODhEgPxB+dr6Em7 lB2dHoatV5gf3EC79vYTVqfNEvmfRzQUayCZNg+sEkMmrDVS9bLsPzcqkyxpH28Q2uccWyVvbXS a+iGA1+JNUNb4l8xiw+wCAo56o3HiOo4afkI= X-Received: by 2002:ac8:5f83:0:b0:50d:a92e:fead with SMTP id d75a77b69052e-51a728014a8mr13182641cf.3.1782382944035; Thu, 25 Jun 2026 03:22:24 -0700 (PDT) X-Received: by 2002:ac8:5f83:0:b0:50d:a92e:fead with SMTP id d75a77b69052e-51a728014a8mr13182371cf.3.1782382943539; Thu, 25 Jun 2026 03:22:23 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c11fb8dc641sm152400166b.0.2026.06.25.03.22.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2026 03:22:22 -0700 (PDT) Message-ID: Date: Thu, 25 Jun 2026 12:22:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] i2c: qcom-cci: drop custom suspend/resume and rely on runtime PM helpers To: Wenmeng Liu , Loic Poulain , Robert Foss , Andi Shyti , Bjorn Andersson , Wolfram Sang , Todor Tomov , Vinod Koul Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260625-cci-v1-1-a100cda673ce@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260625-cci-v1-1-a100cda673ce@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=DqBmPm/+ c=1 sm=1 tr=0 ts=6a3d0160 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=9YL1cksPtRnqhRk4DJMA:9 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDA4OCBTYWx0ZWRfXy0UA5k0qIlaP VkTbqBThZnxaWJmE4wMcRvDSLI9PLMvWPN4TwsM01zexcJAzCz98dc1933TzenKib9DdX6gJeo4 ilorsphJSSfKQKKmn5lfLiEwujs9oQM= X-Proofpoint-ORIG-GUID: q_Ry-WwXlL4UvoCSdIa62-oE-yhhiB8G X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDA4OCBTYWx0ZWRfXwlgfrI8YR7Ph fUHCFe1S53eyfKJkXduT+/EdGmGKcFCJfgKXQ8Usdb2go8hg6fr8+8pLRAC2bb/uTnpyf49P74b JNcRkIP1a3cVB/KBb8D2yrK1LZNwyjIyC10QAQF5/0ghNhouCQ7yANMnehKG0EJiqF08NDa2j4a RqwtkvjOxW8+R6nvIMyiobp9+hwMHukHfpyWuyAI5lBl/63v2spzm6WyD+Fa7WvoOJBb14mTR+K qq5mA4pu/1CN4lmJ5hKGyUwDu+u6FDPkliQa1H6xV5LxBTwl8Y7hRKM5b5aMloj9bHwRFqN66zm f2b1zBsrRzSkQxOzejSg7XFFssXn1Xsc/z2UNT16AOohCQNAxtqyt87gZNNpw65LH16bnhhNLKc 1asJnlX9+FwI4dmuSTswjTaKuDcxbzfjYAmQbelGV395HI3+3IZQOpWrTEMzzZCO3nFvirrfQRG E8z0QyfOy9PCBB8QQNw== X-Proofpoint-GUID: q_Ry-WwXlL4UvoCSdIa62-oE-yhhiB8G X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_01,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606250088 On 6/25/26 11:42 AM, Wenmeng Liu wrote: > cci_resume() unconditionally calls cci_resume_runtime() regardless of > the runtime PM state. > > If the device is already runtime-suspended before system suspend, > the clock is re-enabled while runtime_status remains RPM_SUSPENDED. > As a result, pm_request_autosuspend() does not arm the timer, > leaving the clock permanently enabled. > > Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver") > Cc: stable@vger.kernel.org > Signed-off-by: Wenmeng Liu > --- Reviewed-by: Konrad Dybcio Konrad