mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yum Rayan" <yum.rayan@gmail.com>
To: "Antonino A. Daplas" <adaplas@gmail.com>
Cc: "Dave Jones" <davej@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [RFC] VBE DDC bios call stalls boot
Date: Mon, 24 Apr 2006 00:27:25 -0700	[thread overview]
Message-ID: <df35dfeb0604240027u799e1aafu2d86ebc8085ef379@mail.gmail.com> (raw)
In-Reply-To: <444C1211.8090505@gmail.com>

> > Is this how your patch looked when you tried this ?
>
> I've discovered that checking for availability does not give any added benefit,
> but this is the correct approach and I have to agree with this patch.

My patch was similar. I referenced
http://www.vesa.org/public/VBE/VBEDDC11.PDF. Differences were the
finer look up of the ambiguous status code and setting up ES:DI to be
NULL before call to INT 10h, as follows:

--- linux-2.6.15.4.a/arch/i386/boot/video.S	2006-02-09 23:22:48.000000000 -0800
+++ linux-2.6.15.4.b/arch/i386/boot/video.S	2006-04-24 00:07:08.000000000 -0700
@@ -1946,6 +1946,22 @@ store_edid:
 	rep
  	stosl

+	pushw	%es
+	movw	$0x4f15, %ax                    # report VBE/DDC capabilities
+	xorw	%bx, %bx
+	xorw	%cx, %cx
+	xorw	%di, %di
+	pushw	%di
+	popw	%es
+	int	$0x10
+	popw	%es
+
+	cmpb	$0x0, %ah			# function call failed
+	jne	no_edid
+
+	cmpb	$0x4f, %al			# function not supported
+	jne	no_edid
+
  	movw	$0x4f15, %ax                    # do VBE/DDC
  	movw	$0x01, %bx
  	movw	$0x00, %cx
@@ -1953,6 +1969,7 @@ store_edid:
  	movw	$0x140, %di
 	int	$0x10

+no_edid:
  	popw	%di				# restore all registers
  	popw	%dx
  	popw	%cx


> This option is new and not yet available in 2.6.15, so you may have
> to use your patch temporarily.

I was able to download a more recent kernel and configure
CONFIG_FB_FIRMWARE_EDID. Thanks.

      reply	other threads:[~2006-04-24  7:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-23 19:08 Yum Rayan
2006-04-23 20:14 ` Ingo Oeser
2006-04-23 23:40   ` Antonino A. Daplas
2006-04-23 20:24 ` Dave Jones
2006-04-23 23:47   ` Antonino A. Daplas
2006-04-24  7:27     ` Yum Rayan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df35dfeb0604240027u799e1aafu2d86ebc8085ef379@mail.gmail.com \
    --to=yum.rayan@gmail.com \
    --cc=adaplas@gmail.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome