From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DC6A35DCF9 for ; Tue, 27 Jan 2026 15:28:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527717; cv=none; b=R3Eectlqqd7qwCxyO6a+8GZ+n6akYrqrXB/6+lwY3GNiiSQQa+mQqBdsYjQr/kvvxV9JMk7jOEYaNZeU04tEMJKSFluNaEkxECkxM7YqkZI+XysMJ4p0ng/OXD8Wtmxi5PW0HdvfLehYRWe0R7pCQvnyDB6aA59gkPCcCvuww5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527717; c=relaxed/simple; bh=vY875ywlnRkw7n2jSx23koiCa4M3AexNrI8y1uxIrMk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R6r992cu0U059icFyl5nnAqjxpJYE9O3c7ISiiwWni4ajRNtmK+HoQiSjBETZikhPIEnVI6Zc2mX40grDpqCmOeNfLEa6TZv6B8CNbJuhM3sqzQdrxhDQSj72WqnfHCmuRjqM1Ukb39uQEzV5VNLgpK5wXq31Q/KcQGV0yMcAkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=LBj2+Y8y; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="LBj2+Y8y" Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 60R4dY12032521; Tue, 27 Jan 2026 15:28:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=D5FFn1 GzrUusatVc2ljbWWw6ntEDzJ4LADcEolkRkP4=; b=LBj2+Y8yWAAmxJOrqwqUfq UmLCvUjte/DRMFT5bCqu0eKH7kJrwW/xO0kagRblRIwDrrbVEKy2t/pY4LOYQmE5 QMsd7SQmEmJlUY/9Hnli1wUcD64hjvZBjR56YaVB4V58jNDtrR3dpU0mODZWLiiK 2t0sDpriK3elm2ueOPRDvO95xS7Hi/ym63qRRGBOYF2kmlIHdKc7YITeTCD/jPHk fFGeZ7+yMBkcbhILGfbI9j9hMFrZ23ZeCFCjOYXhiTV5fUby7VVVg6zqziq0tym8 mmtHa3idIHwy/v3P76XTDrXoDA+nBkFummcqk7r5i7BDzR5tf7emNUdsl1A7aHew == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4bvnrte37r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jan 2026 15:28:32 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 60RE4sEB023679; Tue, 27 Jan 2026 15:28:31 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4bwamjrytq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jan 2026 15:28:31 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 60RFSUBV61538626 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jan 2026 15:28:30 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9927858052; Tue, 27 Jan 2026 15:28:30 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6C21C58056; Tue, 27 Jan 2026 15:28:30 +0000 (GMT) Received: from [9.61.135.234] (unknown [9.61.135.234]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 27 Jan 2026 15:28:30 +0000 (GMT) Message-ID: Date: Tue, 27 Jan 2026 09:28:30 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/13] fsi: scom: Convert to fsi bus probe mechanism To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Eddie James In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: larGd1nhCEnbUIi9sEE_vSnjFGQSnD16 X-Authority-Analysis: v=2.4 cv=Uptu9uwB c=1 sm=1 tr=0 ts=6978d9a0 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=IpJZQVW2AAAA:8 a=6DySQIVUtBDBgFpyoi0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-ORIG-GUID: larGd1nhCEnbUIi9sEE_vSnjFGQSnD16 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDEyMSBTYWx0ZWRfXzx/iKcmtiU8S zEDtKgq0H7tNcKK/8t22nhtjvUOQjwSgOq0VLwp+8RvdjdHOVRaqcBEspEt6ZIwn3zp4G3jR8nu IsPJgQ9metle3Ib7XSnri6a5CNlUpJORJUJAJJ435skU5JfDwpOszHmnLE0dUaA9psh3alm/Whx Q5D9SgZ5OcpvtJXbmgUD/7X/Tutc9+Z2pVdrl0tUb8n49srmayVCOcpOVh53oY5jiJNEboAkbjB 6bBaI+3WpkIrKq9LG9P/oCH1iGk06u4gPiUVeLIUwHiUjpsNgLrqvGFnyU4N99PXOHb97Ruloa6 suSLRkiYF4oEpXxVhrFwZ3oOlvX3qSI5QidR3f0vbFz9ILc61vJNKfSj0uij7FMeE4JjNth/EUd KAcvAiCH1Ie2vpk83Rw7AZpHqbMnNCWUZUxeW4GShRVkQxHJ/5mOtmz5I83oqiiWKxx3Tn3zmvu BsPJZmMPYly+7cgVKSw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-27_03,2026-01-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 clxscore=1011 lowpriorityscore=0 phishscore=0 adultscore=0 impostorscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2601150000 definitions=main-2601270121 On 12/9/25 5:40 AM, Uwe Kleine-König wrote: > The fsi bus got a dedicated probe function. Make use of that. This fixes > a runtime warning about the driver needing to be converted to the bus > probe method. Acked-by: Eddie James > > Signed-off-by: Uwe Kleine-König > --- > drivers/fsi/fsi-scom.c | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c > index 2eda44451cc1..67cd45605fe4 100644 > --- a/drivers/fsi/fsi-scom.c > +++ b/drivers/fsi/fsi-scom.c > @@ -527,16 +527,16 @@ static void scom_free(struct device *dev) > kfree(scom); > } > > -static int scom_probe(struct device *dev) > +static int scom_probe(struct fsi_device *fsi_dev) > { > - struct fsi_device *fsi_dev = to_fsi_dev(dev); > + struct device *dev = &fsi_dev->dev; > struct scom_device *scom; > int rc, didx; > > scom = kzalloc(sizeof(*scom), GFP_KERNEL); > if (!scom) > return -ENOMEM; > - dev_set_drvdata(dev, scom); > + fsi_set_drvdata(fsi_dev, scom); > mutex_init(&scom->lock); > > /* Grab a reference to the device (parent of our cdev), we'll drop it later */ > @@ -574,9 +574,9 @@ static int scom_probe(struct device *dev) > return rc; > } > > -static int scom_remove(struct device *dev) > +static void scom_remove(struct fsi_device *fsi_dev) > { > - struct scom_device *scom = dev_get_drvdata(dev); > + struct scom_device *scom = fsi_get_drvdata(fsi_dev); > > mutex_lock(&scom->lock); > scom->dead = true; > @@ -584,8 +584,6 @@ static int scom_remove(struct device *dev) > cdev_device_del(&scom->cdev, &scom->dev); > fsi_free_minor(scom->dev.devt); > put_device(&scom->dev); > - > - return 0; > } > > static const struct of_device_id scom_of_ids[] = { > @@ -604,11 +602,11 @@ static const struct fsi_device_id scom_ids[] = { > > static struct fsi_driver scom_drv = { > .id_table = scom_ids, > + .probe = scom_probe, > + .remove = scom_remove, > .drv = { > .name = "scom", > .of_match_table = scom_of_ids, > - .probe = scom_probe, > - .remove = scom_remove, > } > }; >