On Fri, 7 Nov 2025, Andy Shevchenko wrote: > On Thu, Nov 06, 2025 at 08:14:35PM +0200, Andy Shevchenko wrote: > > On Thu, Nov 06, 2025 at 08:00:36PM +0200, Ilpo Järvinen wrote: > > > On Thu, 6 Nov 2025, Ilpo Järvinen wrote: > > > > On Thu, 6 Nov 2025, Borislav Petkov wrote: > > > > > On Thu, Nov 06, 2025 at 06:15:57PM +0200, Andy Shevchenko wrote: > > > > > > > So I'm seeing this with an allmodconfig build too: > > > > > ^^^^^^^^^^^^ > > > > > > > depmod: ERROR: Cycle detected: 8250 -> 8250_base -> 8250 > > > > > > > depmod: ERROR: Found 2 modules in dependency cycles! > > > > > > > > > > > > I'm surprised it took so long to people to start complaining. > > > > > > > > > > > > So, some of those are modules? Can you share the > > > > > > > > > > > > grep 8250 .config > > > > > > > > > > > > part? > > > > > > > > > > See above. > > > > > > > > https://lore.kernel.org/all/87frc3sd8d.fsf@posteo.net/ > > > > > > > > I wonder if 8250_rsa.o can be put into 8250_base.o where most of its > > > > callers are anyway? > > > > > > This seems to resolve the build issue for me: > > > > I prefer this solution to anything that suggests to merge the 8250_rsa in > > another module. > > Oh, I meant "merge the source of the 8250_rsa", and here we are talking about > merging the object file, which is totally fine! Sorry for the confusion it > might made. The suggestion in that link was to merge the modules (8250.ko with 8250_base.ko) and that certainly isn't a great idea. My patch only moves 8250_rsa.o from 8250.ko to 8250_base.ko and breaks the symbol loop by passing what is needed from 8250.ko in function arguments instead of directly referencing them in 8250_rsa.o. > > If it fixes for the reporters, feel free to add my > > Reviewed-by: Andy Shevchenko > > -- i.