From: YueHaibing <yuehaibing@huawei.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Will Deacon <will.deacon@arm.com>, Jens Axboe <axboe@kernel.dk>,
"Omar Sandoval" <osandov@fb.com>, Hannes Reinecke <hare@suse.de>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH -next] memstick: remove set but not used variable 'data'
Date: Thu, 11 Apr 2019 20:23:49 +0800 [thread overview]
Message-ID: <df3b6949-a54e-c887-742d-94cecbb7f5d4@huawei.com> (raw)
In-Reply-To: <CAPDyKFq8icX27w2FaLgTWtdV1MicfVO+rG_5sZT9n-5pT7iAWg@mail.gmail.com>
On 2019/4/11 19:01, Ulf Hansson wrote:
> On Thu, 11 Apr 2019 at 04:48, YueHaibing <yuehaibing@huawei.com> wrote:
>>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/memstick/host/jmb38x_ms.c: In function 'jmb38x_ms_issue_cmd':
>> drivers/memstick/host/jmb38x_ms.c:371:17: warning:
>> variable 'data' set but not used [-Wunused-but-set-variable]
>>
>> It's never used since introduction and can be removed.
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Applied for next (to my mmc tree), thanks!
>
> Next time, please post to linux-mmc as well.
Ok, Thanks!
>
> Kind regards
> Uffe
>
>
>> ---
>> drivers/memstick/host/jmb38x_ms.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c
>> index e3a5af65dbce..acec09813419 100644
>> --- a/drivers/memstick/host/jmb38x_ms.c
>> +++ b/drivers/memstick/host/jmb38x_ms.c
>> @@ -368,7 +368,6 @@ static int jmb38x_ms_transfer_data(struct jmb38x_ms_host *host)
>> static int jmb38x_ms_issue_cmd(struct memstick_host *msh)
>> {
>> struct jmb38x_ms_host *host = memstick_priv(msh);
>> - unsigned char *data;
>> unsigned int data_len, cmd, t_val;
>>
>> if (!(STATUS_HAS_MEDIA & readl(host->addr + STATUS))) {
>> @@ -400,8 +399,6 @@ static int jmb38x_ms_issue_cmd(struct memstick_host *msh)
>> cmd |= TPC_WAIT_INT;
>> }
>>
>> - data = host->req->data;
>> -
>> if (!no_dma)
>> host->cmd_flags |= DMA_DATA;
>>
>>
>>
>
> .
>
prev parent reply other threads:[~2019-04-11 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 2:59 YueHaibing
2019-04-11 11:01 ` Ulf Hansson
2019-04-11 12:23 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df3b6949-a54e-c887-742d-94cecbb7f5d4@huawei.com \
--to=yuehaibing@huawei.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@fb.com \
--cc=ulf.hansson@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®