From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635AbdHIMBa (ORCPT ); Wed, 9 Aug 2017 08:01:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37844 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752409AbdHIMB2 (ORCPT ); Wed, 9 Aug 2017 08:01:28 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2251810F5DC Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com Subject: Re: [PATCH 1/2] mfd: intel_soc_pmic_chtwc: Remove unneeded I2C device ID table To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Lee Jones References: <20170809084404.781-1-javierm@redhat.com> From: Hans de Goede Message-ID: Date: Wed, 9 Aug 2017 14:01:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170809084404.781-1-javierm@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 09 Aug 2017 12:01:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 09-08-17 10:44, Javier Martinez Canillas wrote: > The driver has an empty I2C device table as a workaround for a previous > bug in the I2C core that was returning -ENODEV in i2c_device_probe() if > the driver didn't have an I2C device ID table. Even when is for an ACPI > only device and so the driver shouldn't need an I2C ID table in theory. > > But now this issue has been fixed by commit c64ffff7a9d1 ("i2c: core: > Allow empty id_table in ACPI case as well"), so the empty I2C device > ID table can be removed. > > Signed-off-by: Javier Martinez Canillas Thank you. Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > drivers/mfd/intel_soc_pmic_chtwc.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/mfd/intel_soc_pmic_chtwc.c b/drivers/mfd/intel_soc_pmic_chtwc.c > index b35da01d5bcf..ca01ecd1e546 100644 > --- a/drivers/mfd/intel_soc_pmic_chtwc.c > +++ b/drivers/mfd/intel_soc_pmic_chtwc.c > @@ -208,10 +208,6 @@ static int __maybe_unused cht_wc_resume(struct device *dev) > } > static SIMPLE_DEV_PM_OPS(cht_wc_pm_ops, cht_wc_suspend, cht_wc_resume); > > -static const struct i2c_device_id cht_wc_i2c_id[] = { > - { } > -}; > - > static const struct acpi_device_id cht_wc_acpi_ids[] = { > { "INT34D3", }, > { } > @@ -225,6 +221,5 @@ static struct i2c_driver cht_wc_driver = { > }, > .probe_new = cht_wc_probe, > .shutdown = cht_wc_shutdown, > - .id_table = cht_wc_i2c_id, > }; > builtin_i2c_driver(cht_wc_driver); >