From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83D2A3C13FD for ; Wed, 22 Apr 2026 10:43:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776854582; cv=none; b=PY76olj4yyrHvjoW+QGZQHlOwicWYZoIa0cLkko7+u8OlnSIobuiVBLz2wDIS7o4ADuYZRyaiPk9cNiN0PeiKTcP7pfOWxQZVy62XgIljyQSFJHOZ1yH2fVOGGfkmkFBzFv+F8HevMDud466rjbB0Sns68tlukiEqJxGQ33GGhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776854582; c=relaxed/simple; bh=RZ8LyAzFHHhQCHwVx9G/hYYS0Bj1t0Ro9JS1AkBSZ5A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uXgG2N+s3rcPuLM0cdbVaRnfnp4iiti71ACPvf2FanIcMWssT8VYECe1mQOGKJfR6AMJuR4lu3Hr7Bwg1y1i5NTV5t1c2yZFOSoW+HZaiTbvOJnvfho3ajQjKomwtsd/ADFwpLj04me9bcwA9aDQd7aKzgMp6rhbU0LraDiBRXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f7b3V42n; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iyjvBZDs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f7b3V42n"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iyjvBZDs" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M99agu1444300 for ; Wed, 22 Apr 2026 10:43:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OGoandW6NCRWawexIx9PyDzPA9ZO9OfXwwgw+bG5ti8=; b=f7b3V42nOJR9eQ2C QAoLe0G65JGEWtU8Feg6S1LIBsPxtmk9oaKlSkOhm9sI7YPuGPbiSMRf/2H81M2w 3HM+PP9bJoNeniPmEFetXYdgKQV9iAGUZp9Wbw1i+E+fEtgVD+Rdb2TsmIgq3d+H r+6DCRDfHaO5mDh1ox2B6iSvuirT+PoKZG9f4idKYVI/6g8QGm/mYVX5iFKupK2i ZdiDZDGA61AFlaWMiiXr1Vkp20T1bm0IzwO1JRv+qj432WxEooSrJ+QOsByRvsPZ n95hViauxZvUBkAlOnpa5eHWq3gYgCjrkf1gVBStAyBMwLAWP2hXJy1BJ/3A+8Tn YGmZiw== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenftws8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 10:43:00 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8b047093195so9519036d6.3 for ; Wed, 22 Apr 2026 03:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776854580; x=1777459380; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OGoandW6NCRWawexIx9PyDzPA9ZO9OfXwwgw+bG5ti8=; b=iyjvBZDsuDvcL0JNKXusdbt4hW//n0jP3AZZRUDTnHCxPBSHZBk8tQUohELJWosad6 Oy4O4BftA15qXMACxgfJiQnDWTVFg1JK8tkUAR/pyP6MElMbTYcaEkk9F6XO9mjGH6qX G0YKQ83spZBZkuhR7CPVAbX7VI1GPWlvmNwlb1aC2vxMGBDTCw4Exr+wVmcbPP1zHSp5 cqIsLycm786Jz7wvNIf6xYzPGs9Ve/+zdSQmHUhpL4q7M/IQSjl9b78rsXg1Xfvp6Eyh AplP7VX7bKkd/0iWu9onwb6wxPPDBiHRQB9TS8/M4bhBO/r96gqtZshnedNBzZPCXMC/ wTTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776854580; x=1777459380; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OGoandW6NCRWawexIx9PyDzPA9ZO9OfXwwgw+bG5ti8=; b=Y4lhUwCh5mvjnJFmxnYJpf8412T1ejoPE7tmC7UqAN4nh7mrmge8/X99523+xSrlmf K2uq+ZnZXFyb1ceYmWwpFDrqAMisit9YFnmMeXxfbq4yFupvphZi24+AVUajoaJJdHj6 2119iKUyZybFy5RV70W6KSGqzS3W6/ihmwP0AmF3grsyXd24egiFI5lfsPQBlgG7tyS9 Lhp5SdGD5UDBOEjslqG1nKxdY/NywhbdrnX+n/69g4ytvtdyzfnTGzHpAqYD0dG+eB6A egt+mudKvyTUiWadWPl0msN9ehxbPU/evLqoG80h6EMs8E83gbIR8vtFA0S3/445tI1Z MAwg== X-Forwarded-Encrypted: i=1; AFNElJ9tlso1NacV8pn5aL58TPz4F2nGAJ4let+ymrYTDMzXxGDmWTj6kqL7wAj+THTpfRf0MsiEdiuxHIrfJfE=@vger.kernel.org X-Gm-Message-State: AOJu0YzvNcDWiJnxWcTWyz/jp+Vv/MMhLf1zGR++SHqg5+LoCTI3L8O5 nxwiLrJB/qI/GjY3XheR3TFzBw50nTjAkeBH7qIhU1gYaxh6OUrMWvqF+Ga4zdHCQpkq+8jRFRA DlO3UiGFdj/o9Z9e3+7UR9Lj7TlvOOXBIL+pvY+DhUhoOMgBh27hpWaj0U/6wfIqN3HM= X-Gm-Gg: AeBDievv/8HTVALRfun5tOoj+q+ccDSRuz7EdpH02Gw1pir77Fl371FeG1QUnKY/4s9 /bqVmigkBqmWtg7VBszasD99e9G1A95iBXytszBJd4Vo60pQtJClpTDbE68odY88Uei3c5hUK8N f42XvvKJfjzf0v0jTVvJP+TybwWrh5RAM017fkRMDufNGMurR5nOnVN60hzCgIhpOR6vVoelPXd 05t1v3jziW7+4YBZY+WqTruNEquosMxQ4rIg2FTxtjITEHUU54lkLIz6jzMGGCW2cjrj+6A4nNt hMksu7y+dc1iT58aY6oyQn3N4JcBEnx7eFU3m3jY3s6fPV9n8WiX8K5PfJ8EzbdP/5hA5Vjl3WY +MyshFv5jxS4Z6pE2TTEsUII1WeCazFTUiteN2YFQnT+d7SgbXvCZtsRnhlVtlsHnRxlTg7Segi plnSQgmtKzJwg/bg== X-Received: by 2002:a05:6214:629:b0:8ac:4fd1:2d5d with SMTP id 6a1803df08f44-8b0281d4c8amr253288216d6.5.1776854579760; Wed, 22 Apr 2026 03:42:59 -0700 (PDT) X-Received: by 2002:a05:6214:629:b0:8ac:4fd1:2d5d with SMTP id 6a1803df08f44-8b0281d4c8amr253287996d6.5.1776854579384; Wed, 22 Apr 2026 03:42:59 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba454d1bf00sm521636366b.33.2026.04.22.03.42.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 03:42:58 -0700 (PDT) Message-ID: Date: Wed, 22 Apr 2026 12:42:56 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/5] phy: qcom: edp: Add SC7280/SC8180X swing/pre-emphasis tables To: Yongxing Mou , Vinod Koul , Neil Armstrong , Stephen Boyd , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260422-edp_phy-v4-0-c38bef2d027b@oss.qualcomm.com> <20260422-edp_phy-v4-3-c38bef2d027b@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260422-edp_phy-v4-3-c38bef2d027b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: jK_4RZ3f9ORc4m2OwDafJcJJxLzozsRR X-Authority-Analysis: v=2.4 cv=YJuvDxGx c=1 sm=1 tr=0 ts=69e8a634 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=9UQlOuGZ28LDIwtST30A:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDEwMiBTYWx0ZWRfX2TD8F2yPUJvJ eVBRlJKFR8eAwOgHvDbzggXdrod+ECf7uVv5TzQBaiSZQ09AL47u74sDOmBZlsekniVItbGyqK7 QwpC8YztckEAR4KbF3N+r49mu1zOwlRofVFhp4tSYnLzAuaZD/xOJKg390RbK7K9tzi0Sa9aG7z kg3VFKjSdlqoms/HqQIcG4zObIFkWNDM24Cnb/CfkWcfP6gENCxOB0GT/HgaFYphM/VhNUFR+4R Zfsexa2ZoQye39jbTG8Ux5mMrCh71DGQayvVUmZgooYEWqKgf9UP26E+JVqNfZ/lT3rQQVmXehZ BUYceeuCeuCK1SIUImhDmQmo/YJIyUsiyXqTJxQguzQCS9GhRiZyYR6IIwfgnoZtBDegIisfEFl SvzICX9cVxZ9h+EVWvWyFICH0FwcFnTRfvNuTaTyW3CQ1/gGg0fgJWLl9JexJZgEiSXMURoggBH wYCNL0dgAPIjUXOShFQ== X-Proofpoint-ORIG-GUID: jK_4RZ3f9ORc4m2OwDafJcJJxLzozsRR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220102 On 4/22/26 8:01 AM, Yongxing Mou wrote: > SC7280 and SC8180X previously shared the same cfg because they did not use > swing/pre-emphasis tables. Add the corresponding tables for these > platforms. Since they have different PHY sub-versions, their eDP/DP mode > tables also differ, so move SC8180X to its own cfg instead of reusing the > SC7280 one. > > Signed-off-by: Yongxing Mou > --- > +static const struct qcom_edp_swing_pre_emph_cfg edp_phy_swing_pre_emph_cfg_v2 = { > + .swing_hbr_rbr = &edp_swing_hbr_rbr, For eDP / low-Vdiff: I believe the RBR swing settings for 8180 should instead be: 0x07 0x0f 0x17 0x1f (matches) (the rest differs) 0x0d 0x16 0x1e 0x11 0x1b 0x16 The preem RBR almost matches, one byte is off (arr[0][1] = 0x12 on poipu, 0x11 on kodiak) The swing and preem settings for HBR3 look OK For DP / low-Vdiff: .swing_hbr3_hbr2 OK .swing_hbr_rbr - I don't know. The docs are unclear whether the same settings should be used for RBR and HBR3, but maybe? There's a separate table for mini-DP but I doubt there's any poipu boards with such a connector (maybe some obscure ones) .pre_emphasis_hbr3_hbr2 OK .pre_emphasis_hbr_rbr same as above Konrad