From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6818C43387 for ; Tue, 8 Jan 2019 09:03:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DF6E2087E for ; Tue, 8 Jan 2019 09:03:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728113AbfAHJDa (ORCPT ); Tue, 8 Jan 2019 04:03:30 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:59870 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726333AbfAHJD3 (ORCPT ); Tue, 8 Jan 2019 04:03:29 -0500 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id x088muNa133111 for ; Tue, 8 Jan 2019 04:03:28 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0b-001b2d01.pphosted.com with ESMTP id 2pvr7jab30-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 08 Jan 2019 04:03:28 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 8 Jan 2019 09:03:26 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 8 Jan 2019 09:03:23 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x0893LPo3998096 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 8 Jan 2019 09:03:21 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 92F8FA4059; Tue, 8 Jan 2019 09:03:21 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3591DA4040; Tue, 8 Jan 2019 09:03:21 +0000 (GMT) Received: from [9.152.98.101] (unknown [9.152.98.101]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 8 Jan 2019 09:03:21 +0000 (GMT) Reply-To: mimu@linux.ibm.com Subject: Re: [PATCH v5 15/15] KVM: s390: start using the GIB To: pmorel@linux.ibm.com, KVM Mailing List Cc: Linux-S390 Mailing List , linux-kernel@vger.kernel.org, Martin Schwidefsky , Heiko Carstens , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Halil Pasic References: <20181219191756.57973-1-mimu@linux.ibm.com> <20181219191756.57973-16-mimu@linux.ibm.com> From: Michael Mueller Organization: IBM Date: Tue, 8 Jan 2019 10:03:20 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19010809-4275-0000-0000-000002FBCF11 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19010809-4276-0000-0000-00003809D92C Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-08_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901080073 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.01.19 18:45, Pierre Morel wrote: > On 19/12/2018 20:17, Michael Mueller wrote: >> By initializing the GIB, it will be used by the kvm host. >> >> Signed-off-by: Michael Mueller >> --- >>   arch/s390/kvm/kvm-s390.c | 8 +++++++- >>   1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c >> index 2d10e175862c..777c8a87d81c 100644 >> --- a/arch/s390/kvm/kvm-s390.c >> +++ b/arch/s390/kvm/kvm-s390.c >> @@ -428,16 +428,22 @@ int kvm_arch_init(void *opaque) >>           goto out_debug_unreg; >>       } >> +    rc = kvm_s390_gib_init(GAL_ISC); >> +    if (rc) >> +        goto out_debug_unreg; >> + > > Since it is the last introduced I have a preference to put the gib > initialization after any existing initialization. > it does not have influence them. > >>       kvm_s390_cpu_feat_init(); >>       /* Register floating interrupt controller interface. */ >>       rc = kvm_register_device_ops(&kvm_flic_ops, KVM_DEV_TYPE_FLIC); >>       if (rc) { >>           pr_err("Failed to register FLIC rc=%d\n", rc); >> -        goto out_debug_unreg; >> +        goto out_gib_destroy; > > It is not a big problem but would make the patch more smaller by > gathering all changes. I will move that behind the FLIC registraion. > >>       } >>       return 0; >> +out_gib_destroy: >> +    kvm_s390_gib_destroy(); >>   out_debug_unreg: >>       debug_unregister(kvm_s390_dbf); >>       return rc; >> > > with these changes. > Reviewed-by: Pierre Morel > > > >