From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118AbdJ0PUj (ORCPT ); Fri, 27 Oct 2017 11:20:39 -0400 Received: from mail-by2nam03on0054.outbound.protection.outlook.com ([104.47.42.54]:21333 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750714AbdJ0PUf (ORCPT ); Fri, 27 Oct 2017 11:20:35 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gary.Hook@amd.com; Subject: Re: [PATCH] iommu: Limit the IOVA page range to the specified addresses To: Alex Williamson Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <150827532101.76237.2380796046683480798.stgit@sosxen2.amd.com> <20171026103201.6ac9f21c@t450s.home> From: Gary R Hook Message-ID: Date: Fri, 27 Oct 2017 10:20:43 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171026103201.6ac9f21c@t450s.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR2201CA0073.namprd22.prod.outlook.com (10.174.103.26) To CY4PR12MB1206.namprd12.prod.outlook.com (10.168.166.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fff3fee0-813b-47f6-b5a0-08d51d4e44ec X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(2017052603199);SRVR:CY4PR12MB1206; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1206;3:JBM9Y6uKhcsqQNludcK603Ocyje+cTBQ7XLF9a8pXw3XsahzULGtEMBmI7DIm52SgQWHnoVjfBY0cYUUFIGkxfbE3fagWKgW0ciSvnuB4wZ+Lp9ihTPhnuh1BJyvBfrY3l2VYsm5TnUlIVlI6WAmYn40zJP2foMno54+sHHqGT5SWRJt5jT/xrTWEAyg47ZQksPoNYcnBiOmOyK0plr/xKH04Xu26g9n1EA0SM9RZUOnmxBP6VTPaM/iGH/2C4HR;25:JuUkIumYE0iiXfWShRuiwPloIUY3sndXXMeyHXkoPzp2qlnybGV/afS5VpXLGSnrn8oxmWhtj/Rx1TWydr6qFmEfAQn1jDemqEzFMF9I6Pz1lMmDpq6ph09agkBFIk5nvqo55Pm9RKW5uBI4R1GNUfToQTdFZNfXDXz93ghiAEU3+ldGqOEZT//iq62EHfx4hasOpA1hXe+OlrWw18NG/LXVAMZwu8WTEMzmJdSPlmso6hWJdJXEiWSwf66uTnw71eAeMMNPkbF3NjGOqbezxU9bHF4z7C263LISGwS2jke2BX6emg4vdLHCZ596/rBvqoW6usdT7nH3O+vMvk7ayQ==;31:Cmzdg1Rq7tdUSEAUHzDLWEG/xArhvz2ZKnnt/L4WRE3hF6V0dG3C8rzLntg4siojx1fV4wtn6/0ggehgrjrB5LD49MEQS0uaSsFEExES/WDOESRxaweMvUEgwhb2SLLQZ7pFOHPVILNVopSi7MpxLMf90QAyZ6nEwKKWOKU0ILXYYsAWfq21RkCHZLChmqW5wfZuvAG4wGTc0F7cESf/LLoK6sUEtU2413L26Rph7eY= X-MS-TrafficTypeDiagnostic: CY4PR12MB1206: X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1206;20:qO48GqH5AD50SDxK4ZMjxNBOuqU5KfHy1pbzMYTJp07BPrlaFvNWkvNwrITa+Y2V2mvJrjubmCHv/ugYzxgQNZ7Szn5Yyr7UdjwHYLE2JWpBKia0Oscb7Hzsde/3EEz5RBP/nCw2b9IERvzRVOmC8lmPwidwCv7Ww82Ri8Sb4n0uKZ5xfDQs1Zt4+1rhcTj2pwXGmvTGm0DBA9MtlR7Hem3MJ5a8QiGu96y0++2FKe4OjMym0863BhNQgG7gbVCK5glNwwfLlO92/zHDX16XnmRtHdzB3JuXWNvdw5azPQwmMUumZne0pIpOE+Py+ED5xEbLkPBl+XpVj/dckG9OPWNKWOWq2dZ8NAmQd8zkpW/EcTEYz2t52emmoVFi1spx+Usq1nYfTfzzeWpc1UXmC3E13viEk4xm8/8d017Tf36APDT/l6TrKxU8vXWbTAMZX7pW7/mEuvMMV6Zghi7xioKkDbkIfn7QsvrEfCDNZV0/aVKf2BY9T86LlGrtKxEy;4:xVZgfqglGvIgFHOmzKbgq+dbJL/GVIgZlYE0Y+gIVqTUgdgmb+v35sxTJjxgloKwpQkMZry85WS+DupRebC/Rcve2PkxetvKP0NGIdQ+tTzTlaP+azLMcV33KBtJoMUNZPydghneHVcCO1AOTiTeMMdE/u23nY/p/LHSRp+gz8vre5/br32ZnsT/ERGhUon/CZlcC4+XtpYDlvP/Y9C1v/MEJxzdvfqcUYNgKWWStLXV7ITjZM1Hovlt7pro2aBVHCtdU/XvrdflzcHSFGH8sFZbgYKonYbl3iKHSmvhT2zxh3+6b7D0Fn/+5SFBouHR X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3231020)(3002001)(6055026)(6041248)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR12MB1206;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR12MB1206; X-Forefront-PRVS: 0473A03F3F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(346002)(376002)(39860400002)(199003)(24454002)(189002)(58126008)(4326008)(478600001)(189998001)(25786009)(31696002)(230700001)(83506002)(36756003)(90366009)(53546010)(72206003)(229853002)(68736007)(2906002)(31686004)(16526018)(6486002)(77096006)(16576012)(316002)(575784001)(3846002)(86362001)(6246003)(65806001)(76176999)(66066001)(50466002)(64126003)(5660300001)(65826007)(81166006)(6116002)(33646002)(47776003)(65956001)(50986999)(97736004)(54356999)(6916009)(105586002)(7736002)(106356001)(2950100002)(81156014)(23676002)(305945005)(6666003)(8676002)(101416001)(53936002)(8936002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1206;H:[10.236.19.127];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyTUIxMjA2OzIzOlZHUXVoN2RSRCtWdFNDV1Z5WGhXdWMyZlAw?= =?utf-8?B?dkF4TFl5NndTTEN4Sy9PZXZ4VXh0RHp6SmQyanZ0S1IvSmZpUkh5UTRkYUdT?= =?utf-8?B?UHZhQ1Yra2FBM0hqOWdwVlhKOUxtdzdCMVBWdldiWUlVNGdqamI3ZWZORWZJ?= =?utf-8?B?Qi9sZ0h6K0lYRXNNNUg4ckl0UG9RZFdxdEk5UkFFSU9UMEpJd21kdnBoOVU5?= =?utf-8?B?aWp2SzVYZW9ENC91ZDJDTVFDZkF2Nkd5cTlSaW92S2EzeVdMRW1XMXJhY0lv?= =?utf-8?B?Q1ByQy9rL01YOEo5UWZJM2lzd0J4LzJMbEdLbDVyRkpVWlRpZ2tUdnZJeGN3?= =?utf-8?B?aDJaMWRnSlh0RFlKM0dGYStBZXAxNWxPOHFZdWc2cVFjQUlsWXZvNFJDNEVn?= =?utf-8?B?eDR3bnhsMXU2L2dGZFB5anpyeGtLbmpLUXNtL0xWZ29yT3R6WDJJdGJNcVds?= =?utf-8?B?dk9sL1dMaTBsY2VDTTRyOGhLeDQ2emd3UDNwa3FucXZnTE01STV4YUljSG04?= =?utf-8?B?YWR1WUMxcTE0ODFZNFN6Wi9YRmpERnh5c2g3QURITnhJWWRjdWwyQ243RkZu?= =?utf-8?B?QkhtZWdGZ3hweG1HbFk4TXhyZmpsZTJHMi9hRlZtbWpNTWRWZXcxZ2VBWjZi?= =?utf-8?B?UUpHcWltWkRuUVJ1eTJhMG9uYXlUK0lsektXS0JJSEdmb1doWXV2Y2NMdWxq?= =?utf-8?B?VUdoTjdHREplVHVZZFdBVmF2aDVTQ1hFQVVvWHlMOFVWMFBacG9uQU9CK3hZ?= =?utf-8?B?bm43Nmkrelg0Nzd3a1kzOTN0TXA0UVE2Z3JQT3BWR3NiUzl0SnpXNU5KcWlE?= =?utf-8?B?Ulpxc0RSQnU1TU5YSnRJL3VtT05CSDA1SVBQTGFTaDNxT3hKVEgwZGtFQlN3?= =?utf-8?B?R1BxSkh6M0Naa2xpVWJuSERhdktJb0lCcTNyZVRrREZTWFVGVWFweUdYa1Zu?= =?utf-8?B?NCt1RlcxRUduUnNtR0l6T2s5SE1tNUxwT2NuL1pqdEl6RktOUTFjL3k3a0Iy?= =?utf-8?B?VzVXZUIyaGhETnJKMTlaQm9xMzk1bVJmMlZzanBvTTd6MlpicXhkSGxVTHRl?= =?utf-8?B?QlNoS3Jld3haemcvSGx3NVRaQXZrWkR3QkxMOGhaOXNEL0Q4aG54dTNUcHFO?= =?utf-8?B?ZmYrQUdaU2V3TVVScUJqbUJoMlNGWkI2aGl2TmlreWZwSXEvYzhjNHRGT0Qy?= =?utf-8?B?aUVzZ05lNFR2R3hyU01XSlNzL29GWkV1azUyYmVveURXZ1U1TVAxdnNya3ZY?= =?utf-8?B?d2w0OTFZbDRmUG5Cd0l0MTRNZHVUN3gycmE3a2tsN210RTQyRERHWGdzeXM5?= =?utf-8?B?QjEwMHlSSnlJMDVjRjkrc2l3aWZOMGpJWVdJdGxYczdQL0tHMFA1c05xeEUy?= =?utf-8?B?S25MQmhsZlFHQ0MyWDIybU5UaFdVOW1vVXdtNXUyZTJxdVA5Y3c1cnRDTEtU?= =?utf-8?B?eit0eW8wVmNqb1EyUWdUd1k4OFJJRm5RYU1TUnEycFJTOXpFeE1TN2FsVUlm?= =?utf-8?B?OVJ1V2RQL0VPeVpaRzVFWXYvR01CSnNENC8rS3ZoaUJKTmpOalMwdUw3Sk1z?= =?utf-8?B?UVEwaFAyVjBCbzJETno4MWlGb0huY2ROWGpFZEIvZktucmtSaVlscmdUTmNm?= =?utf-8?B?OWxha3NaL0poWkRSVmhxV1NyaEdyb1hXZVlqOTRsV1N1cWtpNEMzTi94cmhQ?= =?utf-8?B?dEpGeVUyOXJTZ0QxSi9iS0daNXhISzR1Mlpzd1RPSDdlSXpNbWcreW04WW1V?= =?utf-8?B?S2NxSFM3cytnM3hmMENkdWdWT051elphTG01TWdkOWV0TUJEWDJlQktnelJR?= =?utf-8?B?OU5uOVBGVko4bkFXQW4zcnNQaVdhRDlhWkVQZXNBdDJWR1lwUFJpbWtDd2dC?= =?utf-8?Q?S1ksP+fAT28cfZolRQKZpbZQN41mPMQ7?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1206;6:THHbxear0EkDbbSAg9SIzFRiKOeLd9vBqCB/kdr3SNMQAOdunVOBjtMCuvQqxKCvlGO0iokrxomKgpx+nOlNtG8ByU0EmzOV2OAWrFdYm4qK8M7/QKhOosWd/DkNqCnvZPhqCkN9jj8++DZKv/AUFCGse7KDWb1wyT9swUzP6Iy2RsFJsQX6IdWvIoxXDaQr6109DNYg8weGB+NAi0DA8bmMyeTNDo0S3pwTgWELjI/AHk4AbDm0FlseuvT7JFjzxHFcvXNM5AwUchAxcQNtHw2sHQD8xtBpoxppVpC0nRd9lGLmOm0+NFd2/KHfwObLnLAKvJ47DfzXPsq/qDAovqtVJOMMpCHlz5miwVZD08k=;5:0IhXaA0721ao/IFlM0E0VoRymm/eLanyF/cB94Ow6O9kNMYhb5Yo88c0i6axX36xc9ZuAgxzLX0+YdtEQJ6M2D0snDlFNfMrW+oDwGo3C8Odh5J/yD7Ks4+9ExYzUCycFnoUVBQ8iao6ydE7nl+ismzlBs8vSzOKftnGsicwYf8=;24:VqiqK9yrvPQgjGX1b+wxXwaM+cX2JmHeLKCZiuqDFpdFtpI4AaE3YKBuf21YROnByuCB2gRIThcP6wHlvEHeXfSNkl53MGuQM1gyj0mTUoM=;7:OAIvLHxfBm1GrGwBm7lN5lYRP189JX4nlKGRbfJeT9V8rTzUsV6yxVcXbNZ01dV8utpZVSMWKJGV1gcRR1viImdWcP9DsDWqHsxgQ4bau877HYoMIqgX5ivjjgtf0o7mS1Jgd1Ie84UTrEUl+gIjoxEYZyJdzxGl3b2PH7idVp0hacUndLaVIf2926AzcpSRYAM5j7NpApzEoqsn5K2x8ZXPk9sghSs2MmKAbtlKSv6HK8HAkvesX2jV9iv2RFDA SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1206;20:9ntqS9us8ADxx4n3eF/a4GHhv92oAwzACt+pDSLeNivNmDMt936QqMrdpY7RYVhfgsFQQFv2yqvISUR40meqzljP8YXqklwk9BeB5BUZtBlLFl3xqeb+rTSr1i7hHqcQenXvhXKVGIWzaDPdjj7EMuKohsBLUZ+GXpzJIGBeA1KDdQO64V/AVmFJadCxvOwpcdn0FlrFAX5QfQyLiFnTGWc5ROdgNnmi+jg/hh5QZQaHv8lLQz5YL/wwecRDO1ck X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2017 15:20:33.9207 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fff3fee0-813b-47f6-b5a0-08d51d4e44ec X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1206 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2017 03:32 AM, Alex Williamson wrote: > On Tue, 17 Oct 2017 16:22:01 -0500 > Gary R Hook wrote: > >> From: amd >> >> The extent of pages specified when applying a reserved region should >> include up to the last page of the range, but not the page following >> the range. >> >> Signed-off-by: Gary R Hook >> --- >> drivers/iommu/amd_iommu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c >> index 27eb0d6fcdc2..bb3ef33e3784 100644 >> --- a/drivers/iommu/amd_iommu.c >> +++ b/drivers/iommu/amd_iommu.c >> @@ -3271,7 +3271,7 @@ static void amd_iommu_apply_resv_region(struct device *dev, >> unsigned long start, end; >> >> start = IOVA_PFN(region->start); >> - end = IOVA_PFN(region->start + region->length); >> + end = IOVA_PFN(region->start + region->length - 1); >> >> WARN_ON_ONCE(reserve_iova(&dma_dom->iovad, start, end) == NULL); >> } > > This looks like a fix, should we include: > > Fixes: 8d54d6c8b8f3 ('iommu/amd: Implement apply_dm_region call-back') It turns out there are other places where the computation is incorrect. Would you prefer a single patch to address all of them, or separate patches that apply to specific areas of the driver?