From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D7603EDADD for ; Tue, 17 Mar 2026 16:49:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773766147; cv=none; b=GH8ATsyUvA908qz8YcfmeMktyKdWpaP+X8mG4K4QRhxaDpGMhMbaZc42Du17gI8wozMCIhIClBYnHyz6L67MEhbaGpmepvbzNDrRbaDC27XY0YaAHZm+XG/sLLj/8E/mtO+q32E7gervu28njg7cdrN62ltv+151qmu38IymMEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773766147; c=relaxed/simple; bh=dzQo8pIjVyFIpUhTBop2r5f458RB0osK21r8zdLhEiU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Xhd2Yc2bmrqX1XD2LZsuUWpQuT/tkVA0woNFGUnsWH760CDfgAn4UXiK+lk/ZOHdzJbMj9FU202e+4bKqbGta0vADGL5vrNaV+lsHpfj6/GZzEb/0Sv1dpIDUm8oJPSq26yZwaAUIJT+1kbVooPgfbmyogu/3yYedwoqp+Q6QY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=M4H1y0ua; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ov3v1V/E; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="M4H1y0ua"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ov3v1V/E" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62HGfK9H1413421 for ; Tue, 17 Mar 2026 16:49:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 451Gt6n+OxCGYuKYdPgYhLoSVjAkvBCo9iM63F8lQ8M=; b=M4H1y0uap5vzXLWE nJnxdL7qOlLsLRSIX6z+4Rnb2J4t684jbo4SxBFE2JpXwFPaTzvM81paBveqwGoC oE7ISkAzOS8Vgke/Gi8sN17RKuoDco3se8oythL7/Hz2G+1L6o1kTESoNBLRJtic CTxNbfEpdKjYDL8AJgxR7kmDtAjwGw4cInfIt+apFNizmHwnKI+vMQmE5+JD1Fof M2jaDqaKjRdIyXJjhjEPXui3hXc4q7qj44NWOTznj1bMvSq/JvXUo6N1wdCyfZ8v 3kNvzHYJlL48EisMu1CLaTYDlBOxNcp1H61IzDcSOunNtkTsId+WVJlf84mTKFJv V8k7dw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cyapug0xa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 16:49:04 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cd90210336so320329285a.3 for ; Tue, 17 Mar 2026 09:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773766143; x=1774370943; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=451Gt6n+OxCGYuKYdPgYhLoSVjAkvBCo9iM63F8lQ8M=; b=Ov3v1V/EERtL5qJtf+fwSa4xjtPIixZPM3MA0qEDaFgNH8m7INwIkF9jsJ+jCxoyV+ RQekHkzMZBUWWIaH5Ld1pdY6ms8icy2XiJNOFkPLBSVM/hJlFcp2H+TOGzXFFfFOdGGQ Rl3x38b68QYp9VoQ6QEffWSphEsqKLsGfoBMCKcw824jqfdAiTmZhDsqzDR0Cbu0QqC9 k+W3bICsZCvAAYqk+dvs531KJBqR/6MaVw4cU/JI4l49m7c81hp+vo+HkQpK0t673I1s 7k8arwnAM/LjueJuE+0PrGueY5+GDme6Wpd/mA0Ip9AphHOkWKtkbiCZ1IuD/OiEAsAC 3Wgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773766143; x=1774370943; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=451Gt6n+OxCGYuKYdPgYhLoSVjAkvBCo9iM63F8lQ8M=; b=c8uB8utU0jCaEizO8mLZ8AKriPJNjiZszBezOpCtzsGHvOTXKpviR+XE9V0+UsmyCs 7pGQiVt+/WTCy7DGRdc712miZyzbVlXEq3J/3xt2577qs4JSpcY3VBapaS+7UDoXnERQ fUbjVFY0d8KnSydUt2r/zIVnXfBq0ytatCEwmh54mi5y8hRvZeyEoK4sB75NfpkAOiDI eGqnNFEkSNrw4ItlL/xWFOf2ygiXwN4V1HVFKwmGaHlvhl2WIMNzf2hPV6jt/1OZ9aeL tSu98MbeBKefzRH7Y3kRYGTOr5JvCoZ6grcH9qXGyRfsuYNcxXY7phepVCC3B6IuxbfP xfVg== X-Forwarded-Encrypted: i=1; AJvYcCV68KIeXaKaGHJ0uZ1ucKjbKkgsY7pBhOijhdCKF/VlElVSgQehRe8gxBzH5BLDaUSxNi3mPOuj5gzmY/g=@vger.kernel.org X-Gm-Message-State: AOJu0Yxawc1XldbvEeAZGwtnYPcKc/b/hzI8uvsfIjOpzNcg06HsDjF/ 3KFXEFy4TtxijtV0GdKoLHUoylHiTMghhwbbmoTnxXApHXKod25rOmaZVfFR1uB5OaHCAPisCEL pMG6F4pJ0QADIefZvE8/DiUKfbkzO1qMLM8vwbf5IrlJrA1ovRiiezhXIxDbd4nuEzc4= X-Gm-Gg: ATEYQzwvgHfZzmxOkspBQwcMJlX0PJeXetkmRtLYPJxGofTKPVJbAbJGFagHseMV35E ImgnfuFToFLD6vMb95tcGEDD9o6OkWUtgukACh0wkR5F0s2qyKjLSGKerw52Quanp25rX/W4KtK fD9YJyyi6sohqT62c9lYCcnisuv6Jb/5JVFuQL8EYTujqsLZl/Ksa33L/4ZcXueeh2eSyn6GYho S3hnodkgs1cjKqeRz8z1j3SG4IYesEcFo0lMpdrlfUFj1rrdsR1UOgRi2q9M2xNIlNV7+wUdTsi REzx7hkHdOGMNZoYBcMs1P2zEgHhbPXzELWuge//pds7LAlpRv2HZJiilJRuPw3zawDnRnOXq18 aIP7HybqlsWyC7CRCwX9vI11V3Tx93d2DJh6D7EGVZf0GFDky7f70Xa2jKMBzFDUuhhAWwT96Nx s2F+s= X-Received: by 2002:a05:620a:4095:b0:7e6:9e2b:6140 with SMTP id af79cd13be357-8cfad376157mr19977085a.8.1773766143563; Tue, 17 Mar 2026 09:49:03 -0700 (PDT) X-Received: by 2002:a05:620a:4095:b0:7e6:9e2b:6140 with SMTP id af79cd13be357-8cfad376157mr19974685a.8.1773766143117; Tue, 17 Mar 2026 09:49:03 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f13ee739sm21035366b.12.2026.03.17.09.49.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 09:49:02 -0700 (PDT) Message-ID: Date: Tue, 17 Mar 2026 17:48:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm/dpu: don't try using 2 LMs if only one DSC is available To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Luca Weiss References: <20260317-fix-3d-dsc-v1-1-88b54f62f659@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260317-fix-3d-dsc-v1-1-88b54f62f659@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=bKIb4f+Z c=1 sm=1 tr=0 ts=69b98600 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=LbxHV1oPoWewQDzF:21 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=6H0WHjuAAAAA:8 a=EUspDBNiAAAA:8 a=n8dURotSPeuEtQbmUPwA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDE0NyBTYWx0ZWRfX73MwO6X0aTya 4M326XnN/N2BgVCubWyra8+TN/Jqy+0zZjDNunnvRVVIcPR2rWvz9osBRyAe6Qx7T+uHxjFgP+X MphlOdUI3Lrp+yhJ82tj5MtqVxTToryAlvYUBE3k6tMTx2liMga0NJAtPHeZPb+FhAWPIisVgBu nULcJ36Yk0FGHeI+MIMCguFCaW0NDmj4tEt9+R8TDnOpN+FkoDoCMaeJRBOrYlvbn3yfF0yGWc0 tH5oVYdaXLpfUE+WEBVWY67nDZ084u1nTGeHOzNYxlJArZvOf2VqshRxEDyMjPF38iSIDTpk2XX ICURH7ttgrPvWvzqoXbmvKzqKHDvtAUYS15tffcqw4zwj4TA6HtrRzY50P4rnqiuXxEa77X/LDf pvIZ5LXXn2WAY8S4U8Bq7VlDwlkAD+AZ5n2h+JvEBtAavMbOV31JkRKbWN4y/Jo/ummpZfmBP9n dcfmLxwJkrx0fIV4ZSg== X-Proofpoint-GUID: O5SUGsW-AlGTfmfeRvyv7u32dmJ2KUEt X-Proofpoint-ORIG-GUID: O5SUGsW-AlGTfmfeRvyv7u32dmJ2KUEt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_03,2026-03-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170147 On 3/17/26 4:30 PM, Dmitry Baryshkov wrote: > Current topology code will try using 2 LMs with just one DSC, which > breaks cases like SC7280 / Fairphone5. (why/how?) Konrad > Forbid using 2 LMs split in such > a case. > > Fixes: 1ce69c265a53 ("drm/msm/dpu: move resource allocation to CRTC") > Reported-by: Luca Weiss > Closes: https://lore.kernel.org/r/DH1IKLU0YZYU.2SW4WYO7H3H4R@fairphone.com/ > Tested-by: Luca Weiss # qcm6490-fairphone-fp5 > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index 6bf7c46379ae..96b67ea3fb4c 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -1410,7 +1410,8 @@ static struct msm_display_topology dpu_crtc_get_topology( > topology.num_lm = 2; > else if (topology.num_dsc == 2) > topology.num_lm = 2; > - else if (dpu_kms->catalog->caps->has_3d_merge) > + else if (dpu_kms->catalog->caps->has_3d_merge && > + topology.num_dsc == 0) > topology.num_lm = (mode->hdisplay > MAX_HDISPLAY_SPLIT) ? 2 : 1; > else > topology.num_lm = 1; > > --- > base-commit: 50c4a49f7292b33b454ea1a16c4f77d6965405dc > change-id: 20260317-fix-3d-dsc-4b073977ea19 > > Best regards,