From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A79C48BDF for ; Tue, 15 Jun 2021 10:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4191561428 for ; Tue, 15 Jun 2021 10:05:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231428AbhFOKHX (ORCPT ); Tue, 15 Jun 2021 06:07:23 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:6507 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230519AbhFOKHU (ORCPT ); Tue, 15 Jun 2021 06:07:20 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G43lH6BjBzZhJt; Tue, 15 Jun 2021 18:02:19 +0800 (CST) Received: from dggpemm500023.china.huawei.com (7.185.36.83) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 18:05:06 +0800 Received: from [10.174.187.128] (10.174.187.128) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 18:05:05 +0800 Subject: Re: [PATCH] KVM: arm64: Trival coding style fixes for all vgic-related files To: Marc Zyngier CC: James Morse , Alexandru Elisei , Eric Auger , "Catalin Marinas" , Will Deacon , , , , , References: <20210615035019.35808-1-wangyanan55@huawei.com> <87o8c7ihlf.wl-maz@kernel.org> From: "wangyanan (Y)" Message-ID: Date: Tue, 15 Jun 2021 18:05:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <87o8c7ihlf.wl-maz@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.187.128] X-ClientProxiedBy: dggeme702-chm.china.huawei.com (10.1.199.98) To dggpemm500023.china.huawei.com (7.185.36.83) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/15 17:48, Marc Zyngier wrote: > On Tue, 15 Jun 2021 04:50:19 +0100, > Yanan Wang wrote: >> These fixes introduce no functional change but just adjustment about >> coding style issues for ARM64 vgic code. They mainly include identation >> fix of function parameters/arguments, identation fix of structure >> initialization, identation fix of comment, also the deletion of some >> superfluous space lines. > Please don't. This sort of patches bring little value, and make the > backporting of important fixes more difficult because of pointless > context change. Oh, this is an point that I didn't notice but indeed worths considering. > Fixing these cosmetic details is fine when you are modifying the > code. But as a standalone patch, this brings more pain than benefit. Ok, I will just drop this stuff. Sorry for the noise. Thanks, Yanan > Thanks, > > M. >