From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91548C32774 for ; Tue, 23 Aug 2022 17:28:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231553AbiHWR2c (ORCPT ); Tue, 23 Aug 2022 13:28:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233142AbiHWR0V (ORCPT ); Tue, 23 Aug 2022 13:26:21 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A26517E019 for ; Tue, 23 Aug 2022 08:04:38 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 079B7224F7; Tue, 23 Aug 2022 15:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1661267077; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1cFTANejxhxOSG7GTBTGu700vzKAak6B7yGbxdS2/DM=; b=T0QqjOFd6oBtVDCJkYSzOLQRe6QHGWtLNxQvRrFFBYsHzTzAKJ811NnNnyX44eWA1Tdteg nq7/BFoRbN607DXjU52WByzmeZZ1Bo9Lu327AgLI2iKfEEBek9H45OqBEwub79AkHeXO46 MydiT33+5SZz8ug2T36dwoM+IV1KDuc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1661267077; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1cFTANejxhxOSG7GTBTGu700vzKAak6B7yGbxdS2/DM=; b=4cI74gBerp3rnvYEfNWoymhgI7UP9NAjzkmBXU9ebY5cEDQtAXjRUAVS58p3pGExh1+CSW WoZDn2xhu0qUaMAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C6FEF13A89; Tue, 23 Aug 2022 15:04:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Z5+2L4TsBGPCEgAAMHmgww (envelope-from ); Tue, 23 Aug 2022 15:04:36 +0000 Message-ID: Date: Tue, 23 Aug 2022 17:04:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH v4 13/17] mm/sl[au]b: cleanup kmem_cache_alloc[_node]_trace() Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220817101826.236819-1-42.hyeyoo@gmail.com> <20220817101826.236819-14-42.hyeyoo@gmail.com> From: Vlastimil Babka In-Reply-To: <20220817101826.236819-14-42.hyeyoo@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/17/22 12:18, Hyeonggon Yoo wrote: > This patch does: I've removed this line locally and re-idented the rest. > - Despite its name, kmem_cache_alloc[_node]_trace() is hook for > inlined kmalloc. So rename it to kmalloc[_node]_trace(). > > - Move its implementation to slab_common.c by using > __kmem_cache_alloc_node(), but keep CONFIG_TRACING=n varients to > save a function call when CONFIG_TRACING=n. > > - Use __assume_kmalloc_alignment for kmalloc[_node]_trace > instead of __assume_slab_alignement. Generally kmalloc has > larger alignment requirements. > > Suggested-by: Vlastimil Babka > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Reviewed-by: Vlastimil Babka