From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4FC8EE49A3 for ; Fri, 25 Aug 2023 10:40:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244495AbjHYKkV (ORCPT ); Fri, 25 Aug 2023 06:40:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244496AbjHYKjx (ORCPT ); Fri, 25 Aug 2023 06:39:53 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16013199E for ; Fri, 25 Aug 2023 03:39:50 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-9a1de3417acso385510866b.0 for ; Fri, 25 Aug 2023 03:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692959989; x=1693564789; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=T4bCjQrZ7ywE3HWQV7oP/6H4w62lITlc52ygpwYMfFI=; b=b/2B5kQNomuylgRRvXA3bIMXOMmpnHKBi9YGgMIqQniAJXNL347eXDGCMAp0rhbmRO 8tqMO/CKkHgbEE6h39avWZO8CDh04lC/FXnhEengWH9W8mp+MVwM/d4voiT5PmImrwR/ KJ4Z3izLAKR+bG5pvd2a/exarE0gImQCq1Atlaf67SB8Eji9IAERWhUX8JveT/gvLyE7 56giynFtUCXqGUIg30/TjLxfdYU1NwT5XDTaWYcjHJhcwa/HDxVTe0UoJ0uwuPJLPfk3 xcMeVChesfVvQBXtDrJ9U0P3o1+beJnptMamURKT8gHpWkeGeRFt/UCbxR9wk5J20BGs 1UjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692959989; x=1693564789; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T4bCjQrZ7ywE3HWQV7oP/6H4w62lITlc52ygpwYMfFI=; b=cuBpcHeiYccqLdfCfUYPBrzu6lzZALiXKnLtt4Ef+XG3e6tpCdgj8dGNGM967j8Wzd Lpo8eOjLBK8jtdjOyd/o0fHWH3KtdCFtaSyztov1HMaGveyuX7nokVsXKAhpo9ZOjRx2 j8ipOn1bVKHH66hRX+BE0h9s1oHxNp4VLCuqqgUm9jMctyeg5xOCBrxlyxSvQmGR8uji nRJKLfCYnwBZntnssdMB/j4WpAXN5nRDo8pcwjJWXfyTiHimbEkqIb5vwzypp6wxfZYC F7QRUDDv+/upLxm9HvUwp6k++0HM2Gog+UoI2ou+jOc2h6uZTnDTGAKxtlJjnlhiRvBl iEzQ== X-Gm-Message-State: AOJu0YzGl26Bc4pPV0oygvWgvFDfnoYVGEOR4VTrVVX65aNGLRqJwSNE v58yrX9GlKvShvAc2N8UViFjgA== X-Google-Smtp-Source: AGHT+IEMrMlgr7JpaeTq/MvmU3/4a1WTA6huvdVoSFYPUJSKNZ2VXpw0Gy2tBVpvZnmyuzvs9XADfQ== X-Received: by 2002:a17:907:2711:b0:9a1:df30:e158 with SMTP id w17-20020a170907271100b009a1df30e158mr6781455ejk.36.1692959989433; Fri, 25 Aug 2023 03:39:49 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id rs25-20020a170907037900b0099bd1a78ef5sm819588ejb.74.2023.08.25.03.39.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Aug 2023 03:39:48 -0700 (PDT) Message-ID: Date: Fri, 25 Aug 2023 12:39:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 4/5] arm64: dts: qcom: ipq5018: Add USB related nodes Content-Language: en-US To: Nitheesh Sekar , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, kishon@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, gregkh@linuxfoundation.org, quic_srichara@quicinc.com, quic_varada@quicinc.com, quic_wcheng@quicinc.com, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Cc: Amandeep Singh References: <20230825093531.7399-1-quic_nsekar@quicinc.com> <20230825093531.7399-5-quic_nsekar@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230825093531.7399-5-quic_nsekar@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/08/2023 11:35, Nitheesh Sekar wrote: > Add USB phy and controller nodes. > > Co-developed-by: Amandeep Singh > Signed-off-by: Amandeep Singh > Signed-off-by: Nitheesh Sekar > --- > arch/arm64/boot/dts/qcom/ipq5018.dtsi | 54 +++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi > index 9f13d2dcdfd5..ff477923a823 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi > @@ -238,6 +238,60 @@ > status = "disabled"; > }; > }; > + > + usbphy0: phy@5b000 { > + compatible = "qcom,ipq5018-usb-hsphy"; > + reg = <0x0005b000 0x120>; > + > + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>; > + > + resets = <&gcc GCC_QUSB2_0_PHY_BCR>; > + > + #phy-cells = <0>; > + > + status = "disabled"; > + }; > + > + usb: usb2@8a00000 { Eee, where did you put these? Don't stuff things to the end of any list. This applies to your entire code: Makefile, Kconfig, .c, .h, .dts, .dtsi and other languages and projects as well. Krzysztof