From: Krzysztof Kozlowski <krzk@kernel.org>
To: dongxuyang@eswincomputing.com, p.zabel@pengutronix.de,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com,
huangyifeng@eswincomputing.com
Subject: Re: [PATCH v2 1/2] dt-bindings: reset: eswin: Documentation for eic7700 SoC
Date: Wed, 4 Jun 2025 11:03:47 +0200 [thread overview]
Message-ID: <df534020-f34c-4d23-85c4-eb9c241e5c7b@kernel.org> (raw)
In-Reply-To: <20250604085235.2153-1-dongxuyang@eswincomputing.com>
On 04/06/2025 10:52, dongxuyang@eswincomputing.com wrote:
> +
> +properties:
> + compatible:
> + items:
> + - const: eswin,eic7700-reset
> + - const: syscon
Hm? Did you just add it for the driver? If so, then no, drop. Use
standard MMIO regmap (if you want regmap).
> + - const: simple-mfd
Why did this appear? Changelog is silent on this and it makes no sense
here. No children.
> +
> + reg:
> + maxItems: 1
> +
> + '#reset-cells':
> + const: 2
> +
> +required:
> + - compatible
> + - reg
> + - '#reset-cells'
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-04 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 8:51 [PATCH v2 0/2] Add driver support for ESWIN eic7700 SoC reset controller dongxuyang
2025-06-04 8:52 ` [PATCH v2 1/2] dt-bindings: reset: eswin: Documentation for eic7700 SoC dongxuyang
2025-06-04 9:03 ` Krzysztof Kozlowski [this message]
2025-06-04 10:06 ` Philipp Zabel
2025-06-04 8:53 ` [PATCH v2 2/2] reset: eswin: Add eic7700 reset driver dongxuyang
2025-06-04 12:13 ` Krzysztof Kozlowski
2025-06-04 12:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df534020-f34c-4d23-85c4-eb9c241e5c7b@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongxuyang@eswincomputing.com \
--cc=huangyifeng@eswincomputing.com \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®