From: Andrew Lunn <andrew@lunn.ch>
To: Aleksei Sviridkin <f@lex.la>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, olteanv@gmail.com, Thangaraj.S@microchip.com,
UNGLinuxDriver@microchip.com, steve.glendinning@shawell.net,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v8 1/4] net: usb: lan78xx: register the PHY interrupt with the MDIO bus
Date: Fri, 18 Sep 2026 04:04:40 +0200 [thread overview]
Message-ID: <df5d4af1-a86a-4820-9aeb-b1449a60f37e@lunn.ch> (raw)
In-Reply-To: <20260918015029.2518425-2-f@lex.la>
> - /* if phyirq is not set, use polling mode in phylib */
> if (dev->domain_data.phyirq > 0)
> - phydev->irq = dev->domain_data.phyirq;
> - else
> - phydev->irq = PHY_POLL;
> + dev->mdiobus->irq[phydev->mdio.addr] = dev->domain_data.phyirq;
> +
> + phydev->irq = dev->mdiobus->irq[phydev->mdio.addr];
This line is redundant, given how phylib works.
> netdev_dbg(dev->net, "phydev->irq = %d\n", phydev->irq);
So maybe change this line?
Andrew
next prev parent reply other threads:[~2026-09-18 2:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 1:50 [PATCH net v8 0/4] net: phy: keep a PHY interrupt across a generic bind cycle Aleksei Sviridkin
2026-09-18 1:50 ` [PATCH net v8 1/4] net: usb: lan78xx: register the PHY interrupt with the MDIO bus Aleksei Sviridkin
2026-09-18 2:04 ` Andrew Lunn [this message]
2026-09-18 8:20 ` Aleksei Sviridkin
2026-09-22 2:28 ` netdev-bot+sashiko
2026-09-18 1:50 ` [PATCH net v8 2/4] net: usb: smsc95xx: " Aleksei Sviridkin
2026-09-18 2:05 ` Andrew Lunn
2026-09-18 8:20 ` Aleksei Sviridkin
2026-09-18 1:50 ` [PATCH net v8 3/4] net: phy: take the interrupt back from the bus on detach Aleksei Sviridkin
2026-09-22 2:28 ` netdev-bot+sashiko
2026-09-18 1:50 ` [PATCH net v8 4/4] net: phy: restore the interrupt when the generic bind cycle fails Aleksei Sviridkin
2026-09-22 2:28 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df5d4af1-a86a-4820-9aeb-b1449a60f37e@lunn.ch \
--to=andrew@lunn.ch \
--cc=Thangaraj.S@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f@lex.la \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®