From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751534AbeDFTGg (ORCPT <rfc822;w@1wt.eu>);
        Fri, 6 Apr 2018 15:06:36 -0400
Received: from mga12.intel.com ([192.55.52.136]:52727 "EHLO mga12.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751278AbeDFTGf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 6 Apr 2018 15:06:35 -0400
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.48,416,1517904000";
   d="scan'208";a="39945944"
Subject: Re: [PATCH v1]: perf/x86: store user space frame-pointer value on a
 sample
To: Andi Kleen <ak@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <086d45fb-a099-4ae9-2854-943447e86010@linux.intel.com>
 <20180406153144.GA9010@tassilo.jf.intel.com>
From: Alexey Budankov <alexey.budankov@linux.intel.com>
Organization: Intel Corp.
Message-ID: <df5f38d8-9b35-0309-527a-c7b7b35c635b@linux.intel.com>
Date: Fri, 6 Apr 2018 22:06:26 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180406153144.GA9010@tassilo.jf.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06.04.2018 18:31, Andi Kleen wrote:
>> diff --git a/arch/x86/kernel/perf_regs.c b/arch/x86/kernel/perf_regs.c
>> index e47b2dbbdef3..9284048cf5b0 100644
>> --- a/arch/x86/kernel/perf_regs.c
>> +++ b/arch/x86/kernel/perf_regs.c
>> @@ -157,6 +157,15 @@ void perf_get_regs_user(struct perf_regs *regs_user,
>>  	 */
>>  	regs_user_copy->bx = -1;
>>  	regs_user_copy->bp = -1;
>> +	if (user_64bit_mode(user_regs)) {
> 
> Why is it 64bit only? Should work on 32bit too.

bp register is a part of i386 syscall ABI 
(http://man7.org/linux/man-pages/man2/syscall.2.html) 
so not sure if it will make any sense for 32bit processes. 

-Alexey

> 
> -Andi
> 
>> +		/*
>> +		 * Store user space frame-pointer value on sample
>> +		 * to facilitate stack unwinding for cases when
>> +		 * user space x86_64 executable code has such
>> +		 * support enabled at compile time;
>> +		 */
>> +		regs_user_copy->bp = user_regs->bp;
>> +	}
>>  	regs_user_copy->r12 = -1;
>>  	regs_user_copy->r13 = -1;
>>  	regs_user_copy->r14 = -1;
>