From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: regulator: Document TI TPS65185
Date: Tue, 30 Dec 2025 11:40:32 +0100 [thread overview]
Message-ID: <df617237-3b07-47b9-89b1-9b43ed332d03@kernel.org> (raw)
In-Reply-To: <20251230104909.3236ce13@kemnade.info>
On 30/12/2025 10:49, Andreas Kemnade wrote:
> On Tue, 30 Dec 2025 10:08:57 +0100
> Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
>> On Sat, Dec 27, 2025 at 11:20:36AM +0100, Andreas Kemnade wrote:
>>> Document the TPS65185. GPIO names are same as in the datasheet except for
>>> the PWRUP pad which is described as "enable". That pin is optional because
>>> the rising edge corresponds to setting one register bit and falling edge
>>> to another register bit.
>>
>> Nothing improved in the subject. Mark asked for proper prefix and you
>> used exactly the same prefix, so the same problem stays.
>>
> Quoting:
> The Documentation/ and include/dt-bindings/ portion of the patch should be a separate patch. The preferred subject prefix for binding patches is:
> "dt-bindings: <binding dir>: ..."
>
> That looks like what I am using.
Please read entire paragraph not just half of it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-30 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-27 10:20 [PATCH v2 0/2] regulator: Add TPS65185 Andreas Kemnade
2025-12-27 10:20 ` [PATCH v2 1/2] dt-bindings: regulator: Document TI TPS65185 Andreas Kemnade
2025-12-30 9:08 ` Krzysztof Kozlowski
2025-12-30 9:49 ` Andreas Kemnade
2025-12-30 10:40 ` Krzysztof Kozlowski [this message]
2025-12-27 10:20 ` [PATCH v2 2/2] regulator: Add TPS65185 driver Andreas Kemnade
2025-12-27 16:33 ` Josua Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df617237-3b07-47b9-89b1-9b43ed332d03@kernel.org \
--to=krzk@kernel.org \
--cc=andreas@kemnade.info \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®