From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8BDD19C549 for ; Tue, 22 Oct 2024 11:42:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729597370; cv=none; b=Jru1XvNILOwiabPXF+kFllw9MRIipwBb6qm33orglkCQWmCiLE3ulQ3h2yLvRBNESjv3Z8amh8/cVy7PIvnhFItYImHl3KC2HBV28TmfjqrxjIkZxiB9loU2p8MiaDAXWcDtaOQPQpJbnAUsbuhSwVcSnlDKljNigVkb/vJL8L0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729597370; c=relaxed/simple; bh=raa66sydrVS7SYiJ0GgKYuUMIZ/xbMw6qo8atNjsO8s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dyBp0oBDjiWfJoPT3lK/ScPtkzQSBWgnP/i6LJrjnSBLlCa9tAspSl9E4Wq7tg6xtTvpudTjN37cuVRuxaew7UvVvd8eTQbzixlwYuZg3dBE73jQM2pIm5mQPVEj60+8u1GpOxbt+Y4HzSwjCvr7avpkAYyGR2+QMPxLHo9LWvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=cffjGT7C; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="cffjGT7C" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a9a2209bd7fso740229166b.2 for ; Tue, 22 Oct 2024 04:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1729597367; x=1730202167; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8b6GJXioy/QHHMfPsIPiSHRGT4MhlfXPQwWNMxqLwkI=; b=cffjGT7C3sFd5RxxcIaS31FqZeB7ognz3qpOyWbztqtehNtX9QrPX1yTHr6dh6SLiW 9qFK6w3Za90hoBxMl0TojlyY937xy1JHH7w/FfR5Vr0nDF02og7PdR8yWXUh4JkXoV8L bweBrzUqvudH3Q0rTUm+RIhZyTQb9yN97MH7sz0Z6KM/JtRvsjEamz0UpDwWrX5ccuE1 PY8YZVNU/bc5vEzOqYgAsSovUOTrX88uWcYwwT5cLVHZiXZEQZvOegCNt4wfqgBMkLFB whYr4T0fIEK5u16e6Zt45W46FoR+lwJPwwUlBn+J0Jt1iGC6uDVeJsyLdGvpozp8/ZuO rt2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729597367; x=1730202167; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8b6GJXioy/QHHMfPsIPiSHRGT4MhlfXPQwWNMxqLwkI=; b=ajV/e2edMqSOkhy42ADrKag3S2DHbz/erWY7w2B5rAefqESiQVdCkYy3e6wJ1mcXd7 STSSMATflffhIS/wls/6ldkxPSGtczeuRY/jHyQD0u6Y1CB61j0KBk93q0LRawHbBovq RruUWcICslJho3IY8vdqjYfO+HLSe5KjaBuFOkuSc7cqiF8PLYnFWz+uEvIN1vT1HUTo QQTfIIeY8USiDp2WjrJ+2zbi28/wZ8t2cMhf/1SjGtiaH1xYkpCzmt+e/OnheQjpSLJz WUmUHJVKvjOtNYnG/N2O1jfNte1HInnoLc/GFjkiTmbty3t6Ims3jns8eTwj5JmF18eO cUjg== X-Forwarded-Encrypted: i=1; AJvYcCW14kH4WXJk1RRDED7vGRaRQ0ibg80UqbhvSuAEKNB+ajhAIeASVwL6CQOq7fMuBVd7RZPRwVxnkC1KOLw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4bn+CCwR40UWyt0rkVDo01j1JNzoZH8kczWOgbqaKTNhDcpEG NMsMWTXLK8s6UmRMCFZd1CaWkjJ29rNaHWDg3tdQjgT3/wXlBcQCXeWb3aZi8m8= X-Google-Smtp-Source: AGHT+IG2HVAkARznKGeXSSOz3pYHmzdRrakg/LgoenOtPU5eMNDOO3eQvdGmwFfjp7NcnbHTBiLBcg== X-Received: by 2002:a17:907:7d9e:b0:a99:f8e2:edec with SMTP id a640c23a62f3a-a9a69a7dc95mr1691628266b.21.1729597367082; Tue, 22 Oct 2024 04:42:47 -0700 (PDT) Received: from [10.100.51.161] ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a9155a1c9sm328599966b.129.2024.10.22.04.42.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Oct 2024 04:42:46 -0700 (PDT) Message-ID: Date: Tue, 22 Oct 2024 13:42:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 09/19] gendwarfksyms: Expand structure types To: Sami Tolvanen Cc: Masahiro Yamada , Luis Chamberlain , Miguel Ojeda , Greg Kroah-Hartman , Matthew Maurer , Alex Gaynor , Gary Guo , Petr Pavlu , Daniel Gomez , Neal Gompa , Hector Martin , Janne Grunau , Miroslav Benes , Asahi Linux , Sedat Dilek , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, rust-for-linux@vger.kernel.org References: <20241008183823.36676-21-samitolvanen@google.com> <20241008183823.36676-30-samitolvanen@google.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20241008183823.36676-30-samitolvanen@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/8/24 20:38, Sami Tolvanen wrote: > Recursively expand DWARF structure types, i.e. structs, unions, and > enums. Also include relevant DWARF attributes in type strings to > encode structure layout, for example. > > Example output with --dump-dies: > > subprogram ( > formal_parameter structure_type &str { > member pointer_type { > base_type u8 byte_size(1) encoding(7) > } data_ptr data_member_location(0) , > member base_type usize byte_size(8) encoding(7) length data_member_location(8) > } byte_size(16) alignment(8) msg > ) > -> base_type void > > Signed-off-by: Sami Tolvanen > Acked-by: Neal Gompa Looks ok to me, feel free to add: Reviewed-by: Petr Pavlu -- Petr