From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752706AbcHLMsr (ORCPT ); Fri, 12 Aug 2016 08:48:47 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:9602 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbcHLMsp (ORCPT ); Fri, 12 Aug 2016 08:48:45 -0400 X-AuditID: cbfec7f5-f792a6d000001302-0a-57adc5aaf215 Subject: Re: [PATCH v1] power: reset: reboot mode: fix build error of missing ioremap/iounmap on UM To: Andy Yan , sre@kernel.org References: <1470996110-8550-1-git-send-email-andy.yan@rock-chips.com> Cc: matthias.bgg@gmail.com, dbaryshkov@gmail.com, richard@nod.at, alexandre.belloni@free-electrons.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dwmw2@infradead.org, nicolas.ferre@atmel.com From: Krzysztof Kozlowski Message-id: Date: Fri, 12 Aug 2016 14:48:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <1470996110-8550-1-git-send-email-andy.yan@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsVy+t/xy7qrjq4NN2juY7XouLaYyaL//E1G i0lP3jNbTFw5mdni9QtDi8u75rBZfO49wmjR1GJs8e1yM7vF5J1vGC1O7y5x4PZY8Gsri8eT TRcZPXbOusvusXmFlsemVZ1sHjfnFXr8nbWfxaNvyypGj8+b5AI4o7hsUlJzMstSi/TtErgy tm+6x1Swh7vi08wNTA2M+zi7GDk4JARMJB4cqeli5AQyxSQu3FvP1sXIxSEksJRRYtXPN+wQ zjNGiT2/ZrKBVAkLpErcmfaFEcQWETCTuD5hCZgtJOAmcf3WV7BuZoELjBIzD51nBUmwCRhL bF6+BKyZV8BOYsmSbSwgm1kEVCU2nFEECYsKREjcWvWREaJEUOLH5HssIDangLtE76cJzCDl zAJ6EvcvaoGEmQXkJTavecs8gVFgFpKOWQhVs5BULWBkXsUomlqaXFCclJ5rpFecmFtcmpeu l5yfu4kREidfdzAuPWZ1iFGAg1GJh5djxZpwIdbEsuLK3EOMEhzMSiK8nw6vDRfiTUmsrEot yo8vKs1JLT7EKM3BoiTOO3PX+xAhgfTEktTs1NSC1CKYLBMHp1QDIzPf17bE3RnLtSM+fsn5 zrlTcnnupIDdYr479vo8PvB/7vvA0M+lMYKGp6cYmhr3KC7Ry29RUV/SEK5sWZIlwDjzsMbW LdECzXvcm/2aL7gFn71x9dF6Tudf0lM+X9f9mvjz0aMEFwvxuGNfwm8fcA04MWuhbFPNuWK2 9jfPrVYun7jiseKJICWW4oxEQy3mouJEAObMLqaPAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/12/2016 12:01 PM, Andy Yan wrote: > commit 4fcd504edbf7 ("power: reset: add reboot mode driver") uses api from > syscon, and syscon uses ioremap/iounmap which depends on HAS_IOMEM, so > let's depend on MFD_SYSCON instead of selecting it directly to avoid the > um-allyesconfig like build error on archs that without iomem: > > drivers/mfd/syscon.c: In function 'of_syscon_register': > drivers/mfd/syscon.c:67:9: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration] > base = ioremap(res.start, resource_size(&res)); > ^ > drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion] > base = ioremap(res.start, resource_size(&res)); > ^ > drivers/mfd/syscon.c:109:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration] > iounmap(base); > ^ > > Reported-by: Kbuild test robot > Fixes: 4fcd504edbf7("power: reset: add reboot mode driver") > Signed-off-by: Andy Yan > > --- > > Changes in v1: > - let this driver depend on MFD_SYSCON > - add Reported-by tag, which suggested by Krzysztof Kozlowski > - add Fixes tag, which suggested by Matthias Brugger > > drivers/power/reset/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof