From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69A2BC25B45 for ; Mon, 23 Oct 2023 18:02:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230247AbjJWSCG (ORCPT ); Mon, 23 Oct 2023 14:02:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229594AbjJWSCD (ORCPT ); Mon, 23 Oct 2023 14:02:03 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40145A1; Mon, 23 Oct 2023 11:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=MQawxn832yz1X6QjBTcyMN3/+LzdSzv7N+CX88b/x6o=; b=WN2vBimorueRpS/2O4+IyWMAm+ DSpv6k8QxUL7fURmYnu+eUDWVVO/bHVMFqnyOin8LKMRlCz3QR84p8oj9mJWdnkON6RPvH6+tMEOh IQhOHCpzT/dOmMCnPuWluK60/KmfdiuanWCXVrCR+v7BM+zGtQpbzyrT+7IoorpmBnYg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1quzFU-0033ZG-BQ; Mon, 23 Oct 2023 20:01:56 +0200 Date: Mon, 23 Oct 2023 20:01:56 +0200 From: Andrew Lunn To: Romain Gantois Cc: davem@davemloft.net, Rob Herring , Krzysztof Kozlowski , Jakub Kicinski , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko , Andy Gross , Bjorn Andersson , Konrad Dybcio , Maxime Chevallier Subject: Re: [PATCH net-next 4/5] net: ipqess: add a PSGMII calibration procedure to the IPQESS driver Message-ID: References: <20231023155013.512999-1-romain.gantois@bootlin.com> <20231023155013.512999-5-romain.gantois@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231023155013.512999-5-romain.gantois@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 23, 2023 at 05:50:11PM +0200, Romain Gantois wrote: > The IPQ4019 Ethernet Switch Subsystem uses a PSGMII link to communicate > with a QCA8075 5-port PHY. This 1G link requires calibration before it can > be used reliably. > > This commit introduces a calibration procedure followed by thourough > testing of the link between each switch port and its corresponding PHY > port. Could you explain the architecture in a bit more detail. When i see MAC code messing with a PHY, i normally say move it into the PHY driver. But its not clear to me if you are talking about the real PHYs here, or this is the switch end of the link, and it has some sort of a PHY to talk to the quint PHY? Andrew