From: Philipp Zabel <p.zabel@pengutronix.de>
To: Robert Marko <robert.marko@sartura.hr>,
linus.walleij@linaro.org, bgolaszewski@baylibre.com,
robh+dt@kernel.org, lee.jones@linaro.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: luka.perkov@sartura.hr, jmp@epiphyte.org, pmenzel@molgen.mpg.de,
buczek@molgen.mpg.de
Subject: Re: [PATCH v4 4/6] reset: Add Delta TN48M CPLD reset controller
Date: Mon, 07 Jun 2021 11:23:12 +0200 [thread overview]
Message-ID: <df76ecd3748a055085fe62f3119eaebc7f2c16bd.camel@pengutronix.de> (raw)
In-Reply-To: <20210602122439.2084775-4-robert.marko@sartura.hr>
Hi Robert,
On Wed, 2021-06-02 at 14:24 +0200, Robert Marko wrote:
> Delta TN48M CPLD exposes resets for the following:
> * 88F7040 SoC
> * 88F6820 SoC
> * 98DX3265 switch MAC-s
> * 88E1680 PHY-s
> * 88E1512 PHY
> * PoE PSE controller
>
> Controller supports only self clearing resets.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> drivers/reset/Kconfig | 9 +++
> drivers/reset/Makefile | 1 +
> drivers/reset/reset-tn48m.c | 128 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 138 insertions(+)
> create mode 100644 drivers/reset/reset-tn48m.c
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 4171c6f76385..14e179cda58c 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -237,6 +237,15 @@ config RESET_TI_SYSCON
> you wish to use the reset framework for such memory-mapped devices,
> say Y here. Otherwise, say N.
>
> +config RESET_TN48M_CPLD
> + tristate "Delta Networks TN48M switch CPLD reset controller"
> + depends on MFD_TN48M_CPLD
Let's make this
depends on MFD_TN48M_CPLD || COMPILE_TEST
default MFD_TN48M_CPLD
unless there is a reason not to enable the reset driver by default when
the MFD driver is activated.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
next prev parent reply other threads:[~2021-06-07 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 12:24 [PATCH v4 1/6] mfd: simple-mfd-i2c: Add Delta TN48M CPLD support Robert Marko
2021-06-02 12:24 ` [PATCH v4 2/6] gpio: Add Delta TN48M CPLD GPIO driver Robert Marko
2021-06-02 12:24 ` [PATCH v4 3/6] dt-bindings: reset: Add Delta TN48M Robert Marko
2021-06-02 12:24 ` [PATCH v4 4/6] reset: Add Delta TN48M CPLD reset controller Robert Marko
2021-06-07 9:23 ` Philipp Zabel [this message]
2021-06-07 10:40 ` Robert Marko
2021-06-02 12:24 ` [PATCH v4 5/6] dt-bindings: mfd: Add Delta TN48M CPLD drivers bindings Robert Marko
2021-06-02 12:24 ` [PATCH v4 6/6] MAINTAINERS: Add Delta Networks TN48M CPLD drivers Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df76ecd3748a055085fe62f3119eaebc7f2c16bd.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=bgolaszewski@baylibre.com \
--cc=buczek@molgen.mpg.de \
--cc=devicetree@vger.kernel.org \
--cc=jmp@epiphyte.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=pmenzel@molgen.mpg.de \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®