From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB0E7344D8C for ; Fri, 29 May 2026 16:12:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780071154; cv=none; b=adwNOXTES9owgJ9kS6MXACQYQbpBUCe0UYVE4mDK05ZPCTqGKU8PZ2vGyr95n/1mN1XhHEMeqmTs8RQ8ZitZPET+/pUVyys4/HoSOUCahyuZ8NhsabY3YTGMcUrUxVW/k2ml4/gHK24gKPHAvi9Go1kXDiQZMT+SxXYjThwV7Ek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780071154; c=relaxed/simple; bh=przyp5bNGse5tpmBoS6kVRjn0WsVKg8vjerffbq8d38=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B8f6HuNCIET8nDIlCcCeywyKJoHPeGmvJZpGEYAPz3qZY7DVhms/uo0Y3Lh6k8+/aR0pUbkLMmIC3JV/mnrsPLBLXYHUb5h1qXaXlsEm40WOQauelFI1NLdMofz6HKd3bC0NZ2IeghVOaomefKDadmH/gQmGjoQyLZ3l2nYrtUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KPtjMgIk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=j1AsHFsV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KPtjMgIk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="j1AsHFsV" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64TDLDNa154428 for ; Fri, 29 May 2026 16:12:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 06DgXkn3vnm0O67cuWd7+N21NOACsuVZyxVwUzts++c=; b=KPtjMgIkkqOdpb2H ehkY78DZ9PkFMi7AmUljXM14iuKn/xv1AKShU8nDyhBtpqRtjJEs3l95nGzFwytt tw0C8pW29kQOOtvDcASZdEAa09pwb3Fm4kwMXYen/b0r4xpH+EHHJQBHKkqKbLXa LFinTTTAU287PiY5E2ZopKJSEfuEVYYzjzIYXmIlnwVAeCJGMHf9H5el0/jgS5Lp AewCR/1IkAiXociDUX39J2pyZncsQyoTK6YW87WVw5H0j9scnSJ/v51/XHNdEKmt vnl2mfKzhfEySzZ0i53FK9tl5M4syBHp9Inu7SgM9vUPQx3H4Z4oSjNlMWxtTGKE RjpOag== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eeuy5cr6w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 29 May 2026 16:12:32 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2bf160f7191so8196695ad.3 for ; Fri, 29 May 2026 09:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780071152; x=1780675952; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=06DgXkn3vnm0O67cuWd7+N21NOACsuVZyxVwUzts++c=; b=j1AsHFsVnfn1hfmIpjLjPEj/Wdt5vj2FCRLG/TzK9vDY5Q+S5L3SjDT+ZS8ctVktmy wJjEyQlcHGdpacpUTpFDrcGo05Q/c/ZoLHFWcAeHrAr1Y3KIXI7cgFdpWvblNP+5JM6q fiDz6ixVxBIsSKW//wgsCAAIPEXMVk8B56ImkHuqlwW25LH5cK53CRyYoDVGI5cyxKIC Uu2z1VACgoHbtKFEHE8iLYnXUtXCWKZjftvrYJDS9T3GQ3Ph6J+5/6XLf1CI3La7tPoT kavywwT67nyuSkvw3Lf/uBHBFj+OKhMaEUUD899DBbOzcEUSNXPUQ6rchAku9mOrFGTj IA9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780071152; x=1780675952; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=06DgXkn3vnm0O67cuWd7+N21NOACsuVZyxVwUzts++c=; b=kG/L4/oGxsCt+4Ms9Y6ImN5T2RMw8txyC1rk32nn1Gx+fSgCKYcpIj/7AgOn6r3GxE 9Czx/0JIuxG+ieYthWH1CnPY9dLxpaMNYMIN6HdxoWBiPxjaTW0m3uz9t+6P9hsqaold ZnE4x5Z3BQJolCuJmoZPw5ah6YN5H56GabR/bUERR/EGphfDO298PMVeK0pUIWrHt9lh aiDbjN5dWlL2cd8o6+Rxg346oqj1YdUrPds7JsWomcJupM4xsDfGpdDhcakPEVDNG5sQ fwqp56rsD+WlmGNO5E0pKkwrMVYKjhWRFNoaX8KddkWBpGwO+VOrEzLlVFYEpcG7XCpZ XtTg== X-Forwarded-Encrypted: i=1; AFNElJ9RDHU9jPsQ2M4vlxDxw16E6Li7aw7XP2/7pHtz1SFXiF+aAyaaKzLfzGhV9jUAvhr/tdpg6llpr5epsh4=@vger.kernel.org X-Gm-Message-State: AOJu0YwC7yF6BXza9dRJPUJKmRJ8AJNw8WMbPOujTNAKckIS+E/ZYuU5 62PbNb548WawJX6/ebrqiBhOZ0MFLGZhRL7HCAmkgqlbOMYdrITGJUZlYUe63axzvEu5Lc91QK1 Vgn7cJWLCufxb0LGXq3WElwyZ+243xVX/v7LTk2gnVay8GTIH+aMtt0VWmyygRdChvag= X-Gm-Gg: Acq92OFAOnQcOvq6xGBLWNxMAbRlRA1chHdeijSM9Bl9zvDW2sAnNcZKt6NPhpyQ8oW eNTK5nTsAJSfiJC5XXKW5z97DuAy0EJNRNq/O+lj+6WsYKezW/ceBE6bR22NeU6Z3LzBaQoxn/p /zqjF8mY9A0MgJTeifECaolDti5JEz9qjH1GLRWuJ84Gs1WkypTcEa3k3Zv6DjGgIP/uRIiREVj 7cCEE9sb5wOa/9OV+H4AlHQpuNvkrRfIoZlx/rDX+Tk25QA1mvBmLRbuZREQ8GGxLCXyRJO42w4 DMgahis5nRfUcGARx0H5jeU1xw/iXflmxbafnbNmNKxybON6BrqxXq6jk95Tc/LY5SD3hZ661p9 sLKnmtyNKbU+EV48kXVCnIuDbiBZV9YENIowPVw5M9EwVLCEgh/6blom+j6R0zg== X-Received: by 2002:a17:902:d589:b0:2bd:2de3:519f with SMTP id d9443c01a7336-2bf3684acb2mr6154385ad.19.1780071152169; Fri, 29 May 2026 09:12:32 -0700 (PDT) X-Received: by 2002:a17:902:d589:b0:2bd:2de3:519f with SMTP id d9443c01a7336-2bf3684acb2mr6153675ad.19.1780071151582; Fri, 29 May 2026 09:12:31 -0700 (PDT) Received: from [192.168.0.114] ([49.205.87.240]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e6ff5sm35557685ad.7.2026.05.29.09.12.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2026 09:12:30 -0700 (PDT) Message-ID: Date: Fri, 29 May 2026 21:42:24 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add Embedded Controller node To: Daniel J Blueman , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , Randy Dunlap , Bryan O'Donoghue , Bjorn Andersson , linux-kernel@vger.kernel.org, Anvesh Jain P , Maya Matuszczyk , Krzysztof Kozlowski , Dmitry Baryshkov , Akhil P Oommen , Abel Vesa , Gaurav Kohli References: <20260526112409.66325-1-daniel@quora.org> <20260526112409.66325-2-daniel@quora.org> Content-Language: en-US From: Sibi Sankar In-Reply-To: <20260526112409.66325-2-daniel@quora.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=SPtykuvH c=1 sm=1 tr=0 ts=6a19baf0 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=QeBY61bkPGI4yPcTgj5/Kg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=t9ty7G3lAAAA:8 a=EUspDBNiAAAA:8 a=J7uTrBVL25gZzBqQJcQA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=CsAS6f0m0zARWR-uHzm3:22 X-Proofpoint-GUID: JCRUCTijSyI1cfak4YdeW7B3agHdLIjZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI5MDE2MiBTYWx0ZWRfX9OnGd9arUN9e fLr3Fcj9DrODcmDp/0SHESZtSB3ScVx6PIu1NiS0Fijup3AhLwodYbqDhXIfK0sUaXa5Gcw5zmA pjp+wTmYrZ+uudc1UKCmV2hJOwZZc0N0hsE5PAkpTPpdD6icSHdJ6tc2/FfN5NEOnGQy23Sfbcl t6IbOrglTyFsksI+kZ2X0/IG11AH9Yslr7vz8kj/kGc6bZhnEjQm/LT3nXYFoeFgg+hvqO3X3A2 a2KDkQpdXkAE6wtQeVKcnqfmYevC2UvEQpHcKKL2Y4jToc+QutaJqUY+6ktIvo0QQZVaMRkmlRF GHg8S6lKn0JmB6ggjnlk+f5g0goPAUh1MXUoQAa2dR+qLrPqrKAxDPeTC9ClQXWIXSJZIuErUbI MhtNKNI1NxMpfPjS53mb2onrY8vbTvY3OonQlx11ty08dOCRapgr3+mSD3u6K73x0GGKS5FRWgC aWr3FYc+gE7qMdHLFzA== X-Proofpoint-ORIG-GUID: JCRUCTijSyI1cfak4YdeW7B3agHdLIjZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-29_04,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 malwarescore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605290162 On 5/26/2026 4:54 PM, Daniel J Blueman wrote: > The Lenovo Slim7x uses the same Embedded Controller as the Qualcomm Hamoa > X1 Customer Reference Device. Use the lenovo,yoga-slim7x-ec compatible > introduced by patch 1 for fan control, thermal sensor and suspend > behaviour. > > Signed-off-by: Daniel J Blueman > --- > Changes in v3: > - use lenovo,yoga-slim7x-ec compatible (introduced by patch 1) > - v2 link: https://lore.kernel.org/lkml/20260502063518.15153-1-daniel@quora.org/ > Changes in v2: > - corrected DT compatible node > - v1 link: https://lore.kernel.org/all/20260429103301.17449-1-daniel@quora.org/ Reviewed-by: Sibi Sankar > > .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > index beb1475d7fa0..1ee2a2296129 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > @@ -951,6 +951,22 @@ retimer_ss0_con_sbu_out: endpoint { > }; > }; > > +&i2c5 { > + clock-frequency = <400000>; > + > + status = "okay"; > + > + embedded-controller@76 { > + compatible = "lenovo,yoga-slim7x-ec", "qcom,hamoa-crd-ec"; > + reg = <0x76>; > + > + interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>; > + > + pinctrl-0 = <&ec_int_n_default>; > + pinctrl-names = "default"; > + }; > +}; > + > &i2c7 { > clock-frequency = <400000>; > > @@ -1352,6 +1368,12 @@ &tlmm { > <44 4>, /* SPI (TPM) */ > <238 1>; /* UFS Reset */ > > + ec_int_n_default: ec-int-n-state { > + pins = "gpio66"; > + function = "gpio"; > + bias-disable; > + }; > + > edp_reg_en: edp-reg-en-state { > pins = "gpio70"; > function = "gpio";