From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DC7C3EF672 for ; Tue, 10 Mar 2026 12:50:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773147020; cv=none; b=TsSWBWyCkdt+n7/s7n9MDC5dtaMdqJIaJ2i1vABGx3GswPvm7ICJS2EVDo+EbpJBWQWwFy12RFS+puRdqf79NUYbaoZYo5cN/F5/UGli8QBMe6dEWwncWMNCm5h6omXwEyQc6zmsq4vlnpEc0UY+tZY/ySz/KqVG19U1Gz7Nq5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773147020; c=relaxed/simple; bh=lQXom7tqTXB8fIq42X+a5CDIzvyVk/isD1p5TN9jIOs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gjjIXUT6KBD9POT5MDI+iC5nXE1ddnOPzvAreu3Q3b1ss09Hvr42AX6E6aOF/2IulsR1tuJHRCpVi8PrcriThds663ChRsZzd14aszrFUYnO8l/UtTJy7JJfog7Frn/32F3JucUBAPcpobgNU/JeqMfJdBt2QiKEXQhzVud2AsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FMsd1hnX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZnRLlfRQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FMsd1hnX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZnRLlfRQ" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ACaYsD303910 for ; Tue, 10 Mar 2026 12:50:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IG8LtXmT+b8gpcKphPQcoqVpJ8lTrFw7AVmS1IYqskE=; b=FMsd1hnXG9jcZy0O Bcx8VGxTcQQSibgbXuGm35AoTMP0a0lAxOj1lnrZo7pFfp+1NsS8XK5WJbaSqyVr oftHJJFwz/MLjnBK8urZvRMmcfLy5seFPB7dckTWIA3nyQAMGeESUPWZ/AaEv4Ba s1RaH+4mxZwABIZzczN5k5MND9v1Z5zCew6OQSyUj7Seo2hW5EBpOpYb9AqWkbs3 JjDQ/El4dgGQQk+QqNjLRgxCtqreknag6XmHlK0o+fYYjDdz3jnblUdG5i/WIqtN Y84ntuHVlD1sMkJpV6g1Nsk4DoA4SLsEN6mBYdjvmPsPkBNvvQDma657Ybg/zp8Q QL+HcA== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cthjf0h53-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 12:50:18 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-89a012f8ab7so56103906d6.2 for ; Tue, 10 Mar 2026 05:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773147017; x=1773751817; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IG8LtXmT+b8gpcKphPQcoqVpJ8lTrFw7AVmS1IYqskE=; b=ZnRLlfRQ6BJy0A9C1/eEauON5tBTDsxTAnrKhlZso+w2rZHb5KGhPyYQG77A/ssD87 RHTJe6hvXuOTVKpMPA8O87RjOwTxee8ahObXJa5yQimMrlr1O/gdZLOwxTWlRoWPXjIO werZFhW3yC2qd9r64OOO2iOGdmYce57IRGQO70rVFpnzrHa+KAeD2Q4wKbGdcw6Eo2oT OQgbHF9ZQmL8mdrLSlxPE6zwx0Xz6l95haIyroTY4zKfhK82DhsJDZq7YmmgAdSrcuxy dReCiP6LQf9DvRsthDntRmKMplwR6rRXK3ib6BAAM8V4ISM5pBBvQAT8OHTy6flSBtSe 4WTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773147017; x=1773751817; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IG8LtXmT+b8gpcKphPQcoqVpJ8lTrFw7AVmS1IYqskE=; b=WRa2bubzCqo5+7XnLFHKOIjeJs75HfoSFiQKIlCuVSwvWf8Z8SxzbnfsiROTx4J6KA d7HlMyurhaIZ/z9KsEev3a1Apx1eh5xFNxUjm3dIKoblUeL8w4ycJzyNTrzFsziGK9rJ H06JIzA5I9UAWVp4lhtWZmFWDcAZyhDibMETsuEJ0mp8eccDM1piF/IoO3ju6s4YRrDy dUxLxonYO/HhKaxsk/8nLZ6eZA22ccSsQI73vD7RSBifc7z3TLTprUFXFfHP2OjQJ+rK G/gmV5fo0T1OAG4Z+93f0Rh54QbTTnDankvRS4XXxXldvh98EAa0bR38kKCT1SVkVViP Sddw== X-Forwarded-Encrypted: i=1; AJvYcCWHmQ0gYkuISXeoPRtHaDKr5TdHqFl7GMKXWbk5IojeMOYSgXsPnCa20ZhmXMYxgRT/WV4Bkjk4FMRmz3w=@vger.kernel.org X-Gm-Message-State: AOJu0YzsmIetxjCY6Dcaa+qQoCnGi8rn7viruEruByvBsKBWOXqcv9TJ W7Bc5sLfDafVcP5iqZ+8bYjkzSDcl3KZEupx02M1KHekif3FHqOMMjZgmZ3MU4iX630clO0HxE8 +pCwkk7F08pAZ6KGoJgXuDr4dt3HDFjmnTq+g0gm5Kv/3nH1chAuM3TLSsaTu3IMTDUI= X-Gm-Gg: ATEYQzz9C9ZkscnAX0bP5id5M4h8T3XjUdalRciS0czGZ2sD4pqvqocsAA8OBI3TZ9E b8vtXrFSDL3/qisvd2mkQ9yX9us/KAGAdIDvopaI0N9ccG5gyelzXfj9nUJB2432Pa5X3s9R9FC l1EHw2U82nUHyCLj3tztSl5nAQa20CL02bJAyEs0czzPszhumN7Q5J1F3N0lq3r5gHUdxmOZ0ix /1bR0o33s/B1MV3vEo2wnQwHUrXBeRpXcHQHnBZ7ufgDy0CWSPSkZhvFIGsj5WWfmxfHyDWT/FH f634ISxS4q/gH/hy3GfRqW95YXCZjlsCGRyX/TRSBonwPRlnl2Td0bar+lVABrF3reepd7UdZtu I0KzvTwuu45dZoqK+bhVBZGM86KyNxsrwhxfGCuceHX3P8ephJ0lgbsrywGAHXphgKEc75Gbc9V 5J/W4= X-Received: by 2002:a05:6214:8088:b0:89a:5129:510f with SMTP id 6a1803df08f44-89a5129550cmr61342396d6.0.1773147017553; Tue, 10 Mar 2026 05:50:17 -0700 (PDT) X-Received: by 2002:a05:6214:8088:b0:89a:5129:510f with SMTP id 6a1803df08f44-89a5129550cmr61341866d6.0.1773147017048; Tue, 10 Mar 2026 05:50:17 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b942f139e3dsm478595666b.36.2026.03.10.05.50.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 05:50:15 -0700 (PDT) Message-ID: Date: Tue, 10 Mar 2026 13:50:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/24] drm/msm/mdss: correct UBWC programming sequences To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> <20260306-ubwc-rework-v1-1-9cfdff12f2bb@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260306-ubwc-rework-v1-1-9cfdff12f2bb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 51E3ITOLq9eYI5IcVjgrJdc8f31VmVXX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDExMiBTYWx0ZWRfXw8JZpXwhbVEF kdh5/6FASyQ9+Ayf7l2FTkUbKDbGz8v8B6OL+uNW4SIo9T4lkk//40GNIfj1b+wSpALROKhXQ3V vCWpSg0KTOArbIqcfgB0sBx9qc4g4//OdLCNg9/6t8z/AN5yy6xHwCZiY5SwAu5ndUkLzfMo5ww 3F7YpQeom9mgE1upwBvTiAt+SBV+oJx1I52DyxPj5efuEZ+zbOYAhwGRoMWeoTpNTHXsAmtBFKK Rl07Y18uDxIncVEzzkND7sBRuRlEssZJU3Cj11uJviT956QikWWIm6V3D1XQkMmeEiFBIfP1s6D AftPY1A333opK+Gu1FLTbdPGPcOsCM4Hc2o/+YaBR9S6TakuJva1iMPgEHYl4yeUI5dgDxYy1jV qaaD0daY2vtOgqVkhdMY/dQ2CbBdRcKuDkj6kQAkNBCMsxozQ7Zc/iGoMuia4zuvVl86mTsAaYB runFTKsO1OjnukWTiXA== X-Authority-Analysis: v=2.4 cv=A71h/qWG c=1 sm=1 tr=0 ts=69b0138a cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=g9AtgMIdhz7_Ts0mvgYA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-ORIG-GUID: 51E3ITOLq9eYI5IcVjgrJdc8f31VmVXX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1015 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100112 On 3/6/26 5:47 PM, Dmitry Baryshkov wrote: > The UBWC registers in the MDSS region are not dependent on the UBWC > version (it is an invalid assumption we inherited from the vendor SDE > driver). Instead they are dependent only on the MDSS core revision. > > Rework UBWC programming to follow MDSS revision and to use required (aka > encoder) UBWC version instead of the ubwc_dec_version. > > Fixes: d68db6069a8e ("drm/msm/mdss: convert UBWC setup to use match data") > Signed-off-by: Dmitry Baryshkov > --- [...] > + if (data->ubwc_enc_version >= UBWC_6_0) > + ver = 5; > + else if (data->ubwc_enc_version >= UBWC_5_0) > + ver = 4; > + else if (data->ubwc_enc_version >= UBWC_4_3) > + ver = 3; > + else if (data->ubwc_enc_version >= UBWC_4_0) > + ver = 2; > + else if (data->ubwc_enc_version >= UBWC_3_0) > + ver = 1; > + else /* UBWC 1.0 and 2.0 */ > + ver = 0; You forgot(?) to use qcom_ubwc_version_tag() later Konrad