Re: [PATCH 0/2] dt-bindings: ufs: qcom: Split SC7280 and similar into separate file

[Nitin Rawat <quic_nitirawa@quicinc.com>]

On 7/30/2025 6:05 PM, Krzysztof Kozlowski wrote:
> The binding for Qualcomm SoC UFS controllers grew and it will grow
> further.  It already includes several conditionals, partially for
> difference in handling encryption block (ICE, either as phandle or as IO
> address space) but it will further grow for MCQ.
> 
> See also: lore.kernel.org/r/20250730082229.23475-1-quic_rdwivedi@quicinc.com
> 
> The question is whether SM8650 and SM8750 should have their own schemas,
> but based on bindings above I think all devices here have MCQ?
> 
> Best regards,
> Krzysztof
> 


Hi Krzysztof,

If I understand correctly, you're splitting the YAML files based on MCQ 
(Multi-Circular Queue) support:

-qcom,sc7280-ufshc.yaml includes targets that support MCQ
-qcom,ufs-common.yaml includes common properties
-qcom,ufs.yaml includes targets that do not support MCQ


In future, if a new property applies to both some MCQ and some
non-MCQ targets, we would need to update both YAML files. In the current 
implementation, we handle such cases using if-else conditions to include 
the new property.

For reference, only SM8650 and SM8750 currently support MCQ, though more 
targets may be added later.

Regarding the patch 
lore.kernel.org/r/20250730082229.23475-1-quic_rdwivedi@quicinc.com, 
instead of using two separate YAML files, we could use if-else 
conditions to differentiate the reg and reg-name properties between MCQ 
targets (SM8650 and SM8750) and non-MCQ targets (all others).

Regards,
Nitin



> ---
> Krzysztof Kozlowski (2):
>        dt-bindings: ufs: qcom: Split common part to qcom,ufs-common.yaml
>        dt-bindings: ufs: qcom: Split SC7280 and similar
> 
>   .../devicetree/bindings/ufs/qcom,sc7280-ufshc.yaml | 149 +++++++++++++++++++
>   .../devicetree/bindings/ufs/qcom,ufs-common.yaml   |  67 +++++++++
>   .../devicetree/bindings/ufs/qcom,ufs.yaml          | 160 +++++----------------
>   3 files changed, 251 insertions(+), 125 deletions(-)
> ---
> base-commit: d7af19298454ed155f5cf67201a70f5cf836c842
> change-id: 20250730-dt-bindings-ufs-qcom-980795ebd0aa
> 
> Best regards,