From: "yu kuai" <yukuai@fygo.io>
To: "Li Youhong" <dayou5941@163.com>, <song@kernel.org>
Cc: <magiclinan@didiglobal.com>, <xiao@kernel.org>,
<linux-raid@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Li Youhong" <liyouhong@kylinos.cn>, <stable@vger.kernel.org>
Subject: Re: [PATCH v2] md: fix stop_sync_thread() hang on new sync in idle path
Date: Sat, 21 Nov 2026 12:00:08 +0800 [thread overview]
Message-ID: <df8d28a5-5455-416e-aa72-ddfe5027f9f7@fygo.io> (raw)
In-Reply-To: <20261113010909.30324-1-dayou5941@163.com>
在 2026/11/13 9:09, Li Youhong 写道:
> From: Li Youhong<liyouhong@kylinos.cn>
>
> stop_sync_thread() waits for either MD_RECOVERY_RUNNING to be cleared,
> or (when MD_RECOVERY_FROZEN is clear) for mddev->sync_seq to change.
> The sync_seq counter is only incremented when a sync thread is reaped
> in md_reap_sync_thread(), not on the md_start_sync() not_running path.
>
> If the previous sync attempt took the not_running path, sync_seq does
> not advance. If mddev->thread then queues and runs a new sync in the
> window between flush_work() and wait_event(), that new sync may start
> a real sync thread, leaving MD_RECOVERY_RUNNING set while sync_seq is
> still unchanged. md_idle_sync_thread() then waits until that new sync
> thread is reaped and sync_seq finally changes, even though it only
> needs to wait for the current sync attempt to finish.
>
> Fix this by incrementing sync_seq on the not_running path as well, so
> that the wait condition correctly observes the current sync attempt has
> completed.
>
> Fixes: f52f5c71f3d4 ("md: fix stopping sync thread")
> Cc:stable@vger.kernel.org
> Signed-off-by: Li Youhong<liyouhong@kylinos.cn>
> ---
> v2:
> - Fix the Fixes: tag to reference the upstream commit f52f5c71f3d4
> instead of the stable backport a17d1bca5aba.
> - v1:https://lore.kernel.org/all/20261112092634.1700963-1-dayou5941@163.com/
>
> drivers/md/md.c | 1 +
> 1 file changed, 1 insertion(+)
Applied
--
Thanks,
Kuai
prev parent reply other threads:[~2026-11-21 4:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 1:09 Li Youhong
2026-11-21 4:00 ` yu kuai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df8d28a5-5455-416e-aa72-ddfe5027f9f7@fygo.io \
--to=yukuai@fygo.io \
--cc=dayou5941@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=liyouhong@kylinos.cn \
--cc=magiclinan@didiglobal.com \
--cc=song@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xiao@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®