From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] PCI: qcom: Allow post_init to fail
Date: Thu, 3 Aug 2017 15:45:00 +0300 [thread overview]
Message-ID: <df93be6a-eaf1-aebd-e5b2-855a32adb576@mm-sol.com> (raw)
In-Reply-To: <20170716064203.3406-1-bjorn.andersson@linaro.org>
Bjorn, thanks for the patch!
On 07/16/2017 09:42 AM, Bjorn Andersson wrote:
> host_init should detect and propagate errors from post_init.
>
> In addition, by acknowleding that post_init can fail we must disable the
> post_init resources in a step separate from the deinit, so that we don't
> try to disable the post_init resources a second time.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/pci/dwc/pcie-qcom.c | 20 +++++++++++++++++---
> 1 file changed, 17 insertions(+), 3 deletions(-)
The patch looks good to me,
Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>
regards,
Stan
prev parent reply other threads:[~2017-08-03 12:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-16 6:42 Bjorn Andersson
2017-08-03 12:45 ` Stanimir Varbanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df93be6a-eaf1-aebd-e5b2-855a32adb576@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome