From: "Jike Song" <albcamus@gmail.com>
To: "Hidetoshi Seto" <seto.hidetoshi@jp.fujitsu.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
jbarnes@virtuousgeek.org
Subject: Re: [PATCH] PCI/MSI: bugfix/utilize for msi_capability_init()
Date: Wed, 24 Dec 2008 17:01:01 +0800 [thread overview]
Message-ID: <df9815e70812240101q23f6d59fj4121b19563a77d47@mail.gmail.com> (raw)
In-Reply-To: <4951F258.6040601@jp.fujitsu.com>
On Wed, Dec 24, 2008 at 4:27 PM, Hidetoshi Seto
<seto.hidetoshi@jp.fujitsu.com> wrote:
> This patch fix a following bug and does a cleanup.
>
> bug:
> commit 5993760f7fc75b77e4701f1e56dc84c0d6cf18d5
> had a wrong change (since is_64 is boolean[0|1]):
>
> - pci_write_config_dword(dev,
> - msi_mask_bits_reg(pos, is_64bit_address(control)),
> - maskbits);
> + pci_write_config_dword(dev, entry->msi_attrib.is_64, maskbits);
>
Yes, really a nasty bug. I'm feeling guilty...
Should this fix hit 2.6.28 release? I CCed Jesse for his point.
--
Thanks,
Jike
next prev parent reply other threads:[~2008-12-24 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-24 8:27 Hidetoshi Seto
2008-12-24 9:01 ` Jike Song [this message]
2008-12-25 6:17 ` Hidetoshi Seto
2009-01-16 18:32 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df9815e70812240101q23f6d59fj4121b19563a77d47@mail.gmail.com \
--to=albcamus@gmail.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®