From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C327B41D4C7 for ; Tue, 7 Jul 2026 13:31:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783431108; cv=none; b=IAzObJLu7f3ymMCUT13Kaz8ZWjY6V5N6ekgio83EHq06c8oxPZGYn26ZpErDe/Lgb1/Py9YnNaqwUaIr7Y/JBLYNf3kdkQyxZjWbisPf3bKnCMBRmR7uxGMJ/kZFFerzzkynKC9E++8fgjVjfmIeU6HfnpZSoV5Q3W3WauGOmdk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783431108; c=relaxed/simple; bh=ULfQe5MuSmG/ChyJXgBYdASy+MulJK12QmcjURkE4Lc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a7gp4Elgc14aATbTd2bG4JTKPero/Pd9+Q1AGgMGa0pEQThcwIJ/f96RDI0PHfQViSp60ZRbAfAob+6F5mPMenDLHTvNmxjmN56oVa++CdawaTth7K9C/PPvipxjTpP3ikO6vv6GqKh1o+vmrmdHjdKtFA6awBDnstBmLPDwK+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OXEWGN9u; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fbv1K3hz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OXEWGN9u"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fbv1K3hz" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 667C8sra3542022 for ; Tue, 7 Jul 2026 13:31:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bo4OHvStj7qVIcGrqBnjjOWrOPC/PkfmhXpPZFgogYs=; b=OXEWGN9ujeVewVQO ZxGzSWwFLbXiMpbGzgq+udpJbIbjNjKFaClgLIOWKEYj0S8GyNe4/YS2ZZD+VGbp aHpFHMJJUO7kk8LiDnNqPTYciNd1antTggsy0V1KX7t6ztJ5Q+88PGy6h5J4vnYX Zl7fQpS6bjcLbt8mE5V6gzB9u83B1WCwHD1CGU2U9iXQg81MtLWZGjkQPkun2PLn 7zzlOxhREP9MbKUe8NfvZGPAqOgqGJAoHHH3avBhfgQByfFJ9XIOwhecrc+TOnsL AexAEClabFs71WPeg8JW1W4g5NeNFNQ9DeShuRADRwwuRDqAp7xAXxqN3ql4wvcA +7pwsQ== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8su725uh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 13:31:46 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c89704da8c7so7114900a12.0 for ; Tue, 07 Jul 2026 06:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783431106; x=1784035906; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bo4OHvStj7qVIcGrqBnjjOWrOPC/PkfmhXpPZFgogYs=; b=fbv1K3hzk45LEMIN5BY86p1MVcg9sEozUuWFEaenGkkO7GPOz7jgydbIcVGQ0UNZ3y U3vsowh7intg+TAInGC49hTl/3wO8lnLe2zwutR5XdxUGLWlz162pLHALiB9wGhXTcPq L7Ov8TGVMkAFMpYvaYbjKeLQh477wz/d3zKQedLOblEwqGINa0EgYkUb8UqM9tlLr+RF 1N44XaAxqnlsRHayESAgQk/JjSEQZYfT9tdaGM3EsBnCgEtfY+L0Csqh3+KEg3EjFgzS cWLq0oJ+CKnYOwfhgPJB5pnOXl0Sjov5lCSrYpfbOt/8DspaVTs2FQ2LE5FUjazCeBzz GqEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783431106; x=1784035906; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bo4OHvStj7qVIcGrqBnjjOWrOPC/PkfmhXpPZFgogYs=; b=PBbNwzgTpXo7YOYE0Zz6J+QXKvXdOMzWWI7pemrSW5rLL/rL7uJ93T7n5oNHyUMfdq tCpyAyjmhCK6IL560TX9vdYh4QJ/omWGFYN+s2CiVRhJ3ab0DkJHbHTgmeNC9FRq7ylM IEQh8US2sLPD6qQIIyTtaGGVIQ8sDpQxXSCBDL2otq0GQHkhNo5agKDCgJamMzEWeuQy yAavUIFm738ryslIwx9oS2ouDOhQGV/sELJLGmpBuutQPpXsdzIweJ6HrpsR0pZsnEle 3kfxtn6RFZFvTN2pQZDNg8d+jtvzVITwL/1dSNrlejQsCQvTWph+vvDt25/oFC7BXi6+ FPvw== X-Forwarded-Encrypted: i=1; AHgh+Ro93dOc8je4x6D+/8QVRQS/9h5WP9jMf0faZeneedfXAY7D65HLE8pkLv3N1iFBI9jkfIMJnzRf8oLdbdc=@vger.kernel.org X-Gm-Message-State: AOJu0YxvP/mD5ZJosEKLcxeCSIATrCgueSSXsT6zMwJ8VL/eIqNRuK4e jJMQy2eym3sZfmOI0ZlLgwZ3rqBJbjXqtajyywr/R91ivyBP6TPR4B/fFkCghaMdiMkGVHqhi1d le1DHo8ZF3HnmOEUascadIVBwT6unSaKzeBKQBdVXbsWVKJu95hbDJ8x2xIQmPKyHIgU= X-Gm-Gg: AfdE7cn6KnZ+i7mhMrlslpenLwF3qHm+vZzUyq2uYyvpJ+iVwCj4VptvUt3ZOvPdwsm i3uGquPKmO28cryS9ZjxSquDHXCKCdbW494Y+9RLoVtLPItEIRzynG8YhuTuRwi4UlThexY6cB5 p1jI3PFtZ7sfIrEW3shoWNQsSzaTsziDn4lK2fqlDMvLS/Ua9p+Lveb9ZSc03y1lNY5WAc5jteM i7vn6WTBxX4/dOg7F7ymgM8DH0T+m8DAotx6tycpQJuaRJsU5cTPvHdqEuu3nkHBcOguiA0CDLO kfjjyn4wrGqlR8pL3kK/bCWY/abp7fF7TE5C3bQOVcAw4Olv6ekDUxrx0m2/Yu6Sdeh8fm5/pNo sM5GPZshpoiCcnxC9nIp9ZtORykXX9eXjRpAOLsxwpJM= X-Received: by 2002:a05:6a20:2d23:b0:3bf:77d7:667d with SMTP id adf61e73a8af0-3c08ef0525bmr6078223637.28.1783431106280; Tue, 07 Jul 2026 06:31:46 -0700 (PDT) X-Received: by 2002:a05:6a20:2d23:b0:3bf:77d7:667d with SMTP id adf61e73a8af0-3c08ef0525bmr6078091637.28.1783431104586; Tue, 07 Jul 2026 06:31:44 -0700 (PDT) Received: from [10.217.217.28] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3b251eesm974409a12.31.2026.07.07.06.31.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2026 06:31:44 -0700 (PDT) Message-ID: Date: Tue, 7 Jul 2026 19:01:39 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: lemans-pmics: Add ADC support for PMM8654au To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ayyagari Ushasreevalli , Kamal Wadhwa References: <20260614-adc5_gen3_dt-v2-0-32ec576c5865@oss.qualcomm.com> <20260614-adc5_gen3_dt-v2-2-32ec576c5865@oss.qualcomm.com> <4571c6af-2a5b-49ac-903e-b158d9cbad16@oss.qualcomm.com> Content-Language: en-US From: Jishnu Prakash In-Reply-To: <4571c6af-2a5b-49ac-903e-b158d9cbad16@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDEzMiBTYWx0ZWRfX0TfK9quFOgsM L9FEiDpJqv/bZ/Ee2uT4jTRt0+5CrCBJpGgDr5vnayVM9r25EtPZqE7hzpaSw2IebyquiVa9F+h fxrMyo5VlPupWfsL1CsEjPC0wWsNQoD1iuHPq9rQ5f4jSYKmc5zzzIRkeBKT2bxscteWlH2MglM xt3y4aCT689f8YQszxP8O4cbRcadQkPbEGk35+Jj59tSfGb4Z70p8ohHLcDp6RaArpjYfhRvQHB 9liHYr/sodIOoBEdJJakxQ+ul1hDMyQOqzewcI7abIUqaoHtEMJySBly9jFNriAjFwZRVIUn6uK mVKfSYCk/tal2FwDQHhwqQhsR6GUhyFST6fZJ9Zcaxl2d97gXIsQfQ5j6fHK7iyxB0gcrdpcG6o VzpuyOjtjlUwRsZaNkll5Hzz8vxbpzJL5yGoy5HNNvSr9Uctmd4tekwvM28RRPNApkNkZPoObqb z7fwtFKuNV8KZ80w04A== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDEzMiBTYWx0ZWRfX7l1sHtmHuoqy d+xBBa7Rv6mfX095Khh76b9IGsoqfcyuNHMgvNr/vr8uQt/X+ojDrg34R3epwH0zBMkGyptRscq hzr3t9ogV7r74S84h+hM1qcCYJzyIPY= X-Proofpoint-GUID: hokH4F9QTac5-Epfu41IAeVZ3sAuyc0x X-Proofpoint-ORIG-GUID: hokH4F9QTac5-Epfu41IAeVZ3sAuyc0x X-Authority-Analysis: v=2.4 cv=HN7z0Itv c=1 sm=1 tr=0 ts=6a4cffc3 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=Tx_GAtjeg8paHK5gnVgA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_03,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 clxscore=1015 bulkscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070132 Hi Konrad, On 6/30/2026 5:34 PM, Konrad Dybcio wrote: > On 6/14/26 10:05 AM, Jishnu Prakash wrote: >> From: Ayyagari Ushasreevalli >> >> Add ADC nodes for the four PMM8654au PMICs (pmm8654au_0 through >> pmm8654au_3) on the Lemans platform. >> >> Each ADC node exposes the following ADC channels: >> - DIE_TEMP: PMIC die temperature channel >> - VPH_PWR: Battery/supply voltage channel >> >> Also add the io-channels and io-channel-names properties under >> the temp-alarm nodes so that they can get temperature reading >> from the ADC die_temp channels. >> >> Signed-off-by: Ayyagari Ushasreevalli >> Signed-off-by: Jishnu Prakash >> --- > > [...] > >> + pmm8654au_0_adc: adc@8000 { >> + compatible = "qcom,spmi-adc5-gen3"; >> + reg = <0x8000>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + interrupts = <0x0 0x80 0x1 IRQ_TYPE_EDGE_RISING>; >> + #io-channel-cells = <1>; > > Same nit as patch 3 > > and only now I realized - s/interrupts/interrupts-extended - this is > necessary for !Linux, see > > 2d5cab9232ba ("arm64: dts: qcom: sc8280xp-pmics: Specify interrupt parent explicitly") > Thanks for sharing the reference above. I'll update the patches as you mentioned in the next series. Thanks, Jishnu > with that: > > Reviewed-by: Konrad Dybcio > > Konrad