From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932727AbcFBUi4 (ORCPT ); Thu, 2 Jun 2016 16:38:56 -0400 Received: from mail-bn1on0084.outbound.protection.outlook.com ([157.56.110.84]:47264 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932171AbcFBUix (ORCPT ); Thu, 2 Jun 2016 16:38:53 -0400 Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PART2 RFC v1 1/9] iommu/amd: Detect and enable guest vAPIC support To: Joerg Roedel References: <1460119770-2896-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1460119770-2896-2-git-send-email-Suravee.Suthikulpanit@amd.com> <20160509114927.GC13971@8bytes.org> CC: , , , , , , , , From: Suravee Suthikulanit Message-ID: Date: Thu, 2 Jun 2016 15:38:43 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160509114927.GC13971@8bytes.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM3PR14CA0067.namprd14.prod.outlook.com (10.166.156.163) To BY1PR12MB0437.namprd12.prod.outlook.com (10.162.147.139) X-MS-Office365-Filtering-Correlation-Id: f0eb865c-6c24-4f87-2638-08d38b25e7a0 X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0437;2:RhL+oBNveZhWdq9egw3ICReu/O2aj3rpYQhCm+yZ5ShYeuTj1I33yxC1zmpvwUFDoZT3dhGxdbZIm2fqkWKGqtr70Vy/fRUN0X7ETcHZxYPmu5lAys8icSVPARpS37lUaYcs1M0iuo6I858LLK98hnxSgcqp4rdNkb7Cu3dvK9AFit7FYfvIeSL/94v90XHU;3:GQdOR/UlK38GhVNyZXyi9XMPmmchDj0GcmO1uDfiGpE8jdJJWSel2w0SrxVkWuWiQRyWfuxgo4Y1TtOL7Ruw8i0ggi1b03qFE/oanaTaoJDBbhPcU5+iiQcFsYZ9DI4u;25:I8xGQIxKf7GhYdMOWtpDReSaZW3P0b4P/Xt6yegIjz7gldUdxnLyaPckeaXxEEDXoPzQRVXMm2j0fEcO08watfgDqjD10wc6J8idd+0fhfPhw8nIG3DKYKwiBA0oKobwHnOLLuDdiyKewqEOZTzWNx7a8pf9pkpKIw8L5MAuwxghgAbUpFC1lG4fsEQ4Cac/07mFmk0xzQ3r7LcwWr6SeUE4E3WpKShOrh3UqZewkmzKOQo7kmCt0BzMwnqLPfZnpeQmsG1ALa+ZhyqKw1AZHXkhyZWgl9MLjYk0ahLc3EBKNlE7+tLFx4g1QIq3HpidKhkEutO1D6GRcLIzIqXLaH+DMyja2u32qIMfI9qRPt4YVHFeJEaekEw/tA41wUSNn8Xy0vsnYDVre6/pU4rODSsKrW2xqPz31yCW3GIgeek= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0437; X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0437;20:a33j34wKyGmAsvvgOmWZHzh2e39X6If8wIrZhv//AYxUlUM/aepgepBjPPE8PWUTmRZZOCVb5EfipfgLpbA9F5XEXXevnNeObvKqfwACIdZVIR3a4kmIzJ7we6y1TRW6Zjwvk+8cfXuv0v5qiNRnCYyZPrP0McT77upq99FG+n2Mtl12FIgDV6cLIkVmGeXdnMOcraJzISRdYWGP/lBQNPQLfHoqC5rsWxgy3/11HtnAJvkK9OsM/gn1jrfCHKO3D0aSDTmae5WTL47w9zOcY4e17L/x+FaARaRh+sDL0gNZSTGjZGk5VMyTOak7BYVvDpzXuG6P2Ov8dP0ztnrWPIuRCvs/CMiexttb6MCX/JhtkFQwLa4N0oXjf3UD0ToUGGbvZJqvqU8iKwWTvjvxRy4aLOzDcwO2Z7cmUl+VdkQUTFp/huYopjMmsx6anYgHQv/L/OKnFghFYjFkdThyokG3p5Z/reyJoPwTzdKiV9KN79dNk0e1WlTwu8y8T+21;4:eNVecNWs82z0RBM3iFbZikHgY8cu7PetOLWYNbPoG8J6wZvi3nspoOmJbyWKXM4d6DMnVIof4NcXX6KCGYuua0wnB0fEJ3DyGMYqWjNVcoXoG28fpma14NB1htGeUSNoTvuponiFb+N/bBthlCdxqVOQTT0COeW3cX9/wIChuqv1mklRi4b82QncSVTua30qK7dsPVS60nUMcf5a3VS1VI4iVyyvHkRKSVC69ylOe3vL1444RiwjzgwkcIPoF88+t38Wmgq084b+2bTevcCeHRVOavbOSRUDLzthiE0hHQFG8z0PgmdU09gRAgTD7DzhDzKXIHhrCrVFkvH5ejga8BlerB8tN3nxIMvqWuEUxmCBo0Hc1M+WRzhmrDeDGOt8e7wKNJ/if2J/wP+tAXog1OHm1zDCShrep57K1ntvOw0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:BY1PR12MB0437;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0437; X-Forefront-PRVS: 0961DF5286 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(377454003)(24454002)(33646002)(47776003)(86362001)(586003)(42186005)(31696002)(5008740100001)(110136002)(5004730100002)(31686004)(65806001)(6116002)(189998001)(3846002)(66066001)(65956001)(36756003)(54356999)(2950100001)(81166006)(92566002)(8676002)(50466002)(2906002)(19580395003)(76176999)(4326007)(19580405001)(230700001)(23746002)(4001350100001)(83506001)(50986999)(77096005)(65826006);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR12MB0437;H:[10.236.18.83];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY1PR12MB0437;23:IHBE8TEroqanYi9AdjxlblwrNl1gzoMcqK0Kd?= =?Windows-1252?Q?4cTW8HsKaLUOd1XLR0crpvKIHakXJT+ZpTkuUf/Z9CFw89qHwgWCWQjS?= =?Windows-1252?Q?1BXs5Ef585VhToTSXL8SgEKcOCWoWSpAM4gGH5u+US0t2e8UQJZsoSv0?= =?Windows-1252?Q?Gk2NulukAf/mPFMCqGCMNhfXGGjGGCl6WbR2ts+mO/lskVQ7eEbXqdv5?= =?Windows-1252?Q?y+6FY9rryZF80BRgeXCPjFHYhZguepJ2zxpkANon/b2rCftYcneISMdI?= =?Windows-1252?Q?R/GA+8QpkKEwvXpUifyUNx+exJmqPIy8C3QEbIdp6P1/D5JbP/xoNOl4?= =?Windows-1252?Q?dgH22EpLZwVTRbKXroo6OY4c50iL51MmPQh+gV1Izda6ix8OE61h1jgS?= =?Windows-1252?Q?/4V6Ux/+vshGfitIj1SWQhjKNOIsGYY8j3KemkDmjGV/wHIdYXLVf7Aj?= =?Windows-1252?Q?zYQo4K2aVb0cyjMrGoNMjZS1XmdxrrfPdwlnnaDxzSPbWjn+BOS5lkUI?= =?Windows-1252?Q?sSggVxWxcqF/DxZQBeLJTpuGh3I5aua8AeW+9ske6ooJ6iaFSy8gZUJV?= =?Windows-1252?Q?UFnrmCbg2ZH1ELjkCoJb0wXYT+hlYNHAe0grjhr+sVqp/DMEZfJEfd53?= =?Windows-1252?Q?s136A6L0HU3WgPElls6UIo2phedbFlqp6MHtXZSHo+Q/FstEHL9Db6ih?= =?Windows-1252?Q?7JMqzLKYSU9k/rwypXTMshkwgvCzkvZu3riO+BD+Y86fioYN1HmZHsk+?= =?Windows-1252?Q?flK/w6HkzYXWQAooSFg1e1iNstmqCQpjjYmYXWycEP3UyXDFMmdhtalK?= =?Windows-1252?Q?nQ42Q3mNwS7nmUau9LudroqHPpp5sZ+jEjlup/n8uTSIjVlPBwKIOteh?= =?Windows-1252?Q?lL4mZZbeZfoOt9ZZO0LcgEY/FaIJBfuDePHAf8VxGbCVxIqi07kkaq9k?= =?Windows-1252?Q?eFjzZHtHWVpm6nvxgHnKBjdlJjrcaEKclk256gmUrq2akZb8O/QHtcav?= =?Windows-1252?Q?6gDwiXn99v0euzN8XColEyjg3aEpoUVFuBQnlzJxDdd2xNAF5mQzWjAB?= =?Windows-1252?Q?QbVSdVh16W6yxCR22K9DRnwKQaocu4rYWOclVVPwEZMnAvguj9c1x6O2?= =?Windows-1252?Q?0nG0Jv4TvUohwH+/tDoAn4=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0437;5:tuPM2zSOSce1xsTI8+PIRztAJYOM62lvfCvrZkhGfNlq9C9HVEFNQh0kNFoXSapy6nW+0KDHfky/40QkgmfBqms02BdAhbEXG0XKUc9YWn/BXoeVlex/QR2tsxrKC/+1V6sTCdxYEKsRNi2sDrKq6g==;24:Fohupf76ta7Ub9p5eGBORiyydxli8G4k3ebF4SLfBWsABjMyW6FSGVBpG6ASQPCk5eo7/FJuZvqzsGuI0gRKnXoHYp9ON/aULu+obuVOAcc=;7:VCRPLNJ03reygT30oDvrKdKu9E/fzkkiDkKTFzmO0mRRUf+ay77XY1lQVAlmekmoY9OiM8Hm0dOfrfJUyj6fD4H7uk53nfYVq5BbBNKGldejrNqeQfvwLKNPvwAZmgKojEfy+IZDPd1VEvvjBjhLNC3NEM+s3yJPSurEwREpLSI=;20:V7TpJylQAcco+UtRg/wxuKT3WHyx/Aod65tJMygAIjxH4q1cAUqqVRvKYTZYPPmh1t6cyW9s/+cd5cD++RGKSTHMlEoX0eutS8S2RnZ6LiFS5p59eYgmzMuC07C9FrqQ+OviCfAEr+/wmD5C+iTF1glWIta7+znGCvLr9tR+zzir+E/M0e6jUs2r6O1pqyl6obazYmB1r303UlLhGmDJ5IUNXkATLnIyk5qQ+2+wUtqj8pfpo+lTbDRhHPVaWdMS X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2016 20:38:49.8111 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB0437 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/9/2016 6:49 AM, Joerg Roedel wrote: > On Fri, Apr 08, 2016 at 07:49:22AM -0500, Suthikulpanit, Suravee wrote: >> From: Suravee Suthikulpanit >> >> This patch introduces a new IOMMU driver parameter, amd_iommu_guest_ir, >> which can be used to specify different interrupt remapping mode for >> passthrough devices to VM guest: >> * legacy: Legacy interrupt remapping mode (w/ 32-bit IRTE) >> * ga : Guest vAPIC interrupt remapping mode (w/ 128-bit IRTE) >> >> Note that the GA mode also supports legacy interrupt remapping >> for non-passthrough devices with the 128-bit IRTE. > > Does this need to be under user control? The code can just check what > the hardware supports and use the 128bit IRTEs if supported, no? > > Joerg It does not need to be signified by user. Currently, if the MMIO Offset 30h[GASup] bit (of IOMMU Extended Feature Register) is set, the driver should default to using the 128bit IRTE by setting MMIO Offset 0018h[GAEn] bit (of IOMMU Control Register). The default is also enabling GA mode (by setting MMIO 0018h[GAEn] if MMIO 0030h[GASup] is set). However, if SVM AVIC is not enabled, or if the AVIC HW cannot support the type of interrupt (e.g. multicast/broadcast), it falls back to use legacy interrupt remapping mode w/ 128-bit IRTE. This option is intended for the case when we want to force IOMMU to use legacy interrupt remapping (hence no need for 128-bit IRTE). I will improve on the documentation in the next patch series. Thanks, Suravee