mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Li Huafei <lihuafei1@huawei.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: <dan.carpenter@linaro.org>, <mhiramat@kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-trace-kernel@vger.kernel.org>, <oe-kbuild@lists.linux.dev>,
	<lkp@intel.com>
Subject: Re: [PATCH] fgraph: Fix missing unlock in register_ftrace_graph()
Date: Thu, 24 Oct 2024 16:03:19 +0800	[thread overview]
Message-ID: <dfa55519-fcfd-73fa-2cd5-5a408a91bd86@huawei.com> (raw)
In-Reply-To: <20241024004624.3b574af2@rorschach.local.home>



On 2024/10/24 12:46, Steven Rostedt wrote:
> On Thu, 24 Oct 2024 10:45:46 +0800
> Li Huafei <lihuafei1@huawei.com> wrote:
> 
>> Agreed, this will make the code simpler and avoid mistakes. If we need
>> to replace all mutex(&ftrace_lock), would it be better to submit another
>> cleanup patch? We can fix the issue here first.
> 
> This case is a bug fix, just add it here.
> 
> We can do a clean up separately for the other locations.
> 

Okay, I've already sent v2:

https://lore.kernel.org/lkml/20241024155917.1019580-1-lihuafei1@huawei.com/T/#u

Thanks,
Huafei

> -- Steve
> 
> .
> 

      reply	other threads:[~2024-10-24  8:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 17:04 Li Huafei
2024-10-23  9:29 ` Steven Rostedt
2024-10-24  2:45   ` Li Huafei
2024-10-24  4:46     ` Steven Rostedt
2024-10-24  8:03       ` Li Huafei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfa55519-fcfd-73fa-2cd5-5a408a91bd86@huawei.com \
    --to=lihuafei1@huawei.com \
    --cc=dan.carpenter@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mhiramat@kernel.org \
    --cc=oe-kbuild@lists.linux.dev \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®