From: Jelle van der Waa <jelle@vdwaa.nl>
To: "Rong Zhang" <i@rong.moe>, "Ike Panhc" <ikepanhc@gmail.com>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] platform/x86: ideapad-laptop: Add charge_types:Fast (Rapid Charge)
Date: Sun, 2 Nov 2025 17:09:13 +0100 [thread overview]
Message-ID: <dfa70284-04ce-482d-8d79-cc0ee8b4bf6d@vdwaa.nl> (raw)
In-Reply-To: <20251020192443.33088-1-i@rong.moe>
On 10/20/25 21:24, Rong Zhang wrote:
> The GBMD/SBMC interface on IdeaPad/ThinkBook supports Rapid Charge mode
> (charge_types: Fast) in addition to Conservation Mode (charge_types:
> Long_Life).
>
> This patchset exposes these two modes while carefully maintaining their
> mutually exclusive state, which aligns with the behavior of manufacturer
> utilities on Windows.
>
> Tested on ThinkBook 14 G7+ ASP.
Tested this patch on my Lenovo Ideapad U330p, it now advertises that
`Fast` is a supported charge_type although my laptop does not seem to
support it:
[root@archlinux jelle]# cat /sys/class/power_supply/BAT1/charge_types
Fast [Standard] Long_Life
[root@archlinux jelle]# echo 'Fast' >
/sys/class/power_supply/BAT1/charge_types
[root@archlinux jelle]# cat /sys/class/power_supply/BAT1/charge_types
Fast [Standard] Long_Life
I'm wondering if the battery extension API allows to not advertise a
property if it isn't supported or if it should at least return -EINVAL.
Greetings,
Jelle van der Waa
next prev parent reply other threads:[~2025-11-02 16:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 19:24 Rong Zhang
2025-10-20 19:24 ` [PATCH 1/2] platform/x86: ideapad-laptop: Protect GBMD/SBMC calls with mutex Rong Zhang
2025-10-30 16:40 ` Ilpo Järvinen
2025-10-20 19:24 ` [PATCH 2/2] platform/x86: ideapad-laptop: Add charge_types:Fast (Rapid Charge) Rong Zhang
2025-10-22 18:43 ` Mark Pearson
2025-11-02 16:09 ` Jelle van der Waa [this message]
2025-11-02 18:57 ` [PATCH 0/2] " Rong Zhang
2025-11-02 19:24 ` Rong Zhang
2025-11-03 21:31 ` Jelle van der Waa
2025-11-05 8:59 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfa70284-04ce-482d-8d79-cc0ee8b4bf6d@vdwaa.nl \
--to=jelle@vdwaa.nl \
--cc=derekjohn.clark@gmail.com \
--cc=hansg@kernel.org \
--cc=i@rong.moe \
--cc=ikepanhc@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®