From: Helen Koike <helen.koike@collabora.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux DRI Development <dri-devel@lists.freedesktop.org>
Cc: David Heidelberg <david.heidelberg@collabora.com>,
Dorine Tipo <dorine.a.tipo@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: Automatically update drm CI dependencies?
Date: Mon, 8 Jan 2024 11:53:24 -0300 [thread overview]
Message-ID: <dfa99bb8-9b7d-4db2-b5bf-35da39b80eda@collabora.com> (raw)
In-Reply-To: <846e883c-e3ae-426f-83e3-38e357e53ef3@gmail.com>
On 20/12/2023 08:11, Bagas Sanjaya wrote:
> On 12/19/23 23:43, Helen Koike wrote:
>> Hi,
>>
>> On 14/12/2023 06:38, Bagas Sanjaya wrote:
>>> Hi all,
>>>
>>> I'm referring to dependabot PR on torvalds.git GitHub mirror [1]. I know
>>> that PRs submitted there are not accepted (the repo is essentially read-only
>>> mirror), hence this mail question.
>>>
>>> In summary, dependabot submitted automated PR that bumps package versions
>>> in `drivers/gpu/drm/ci/xfails/requirements.txt`. In this case, pip was
>>> upgraded to 23.3.
>>>
>>> From my experience, such automated PRs can pollute commit history (in
>>> some GitHub projects these PR kind can contribute up to half of total
>>> commits since the beginning of project). And in some projects, dependabot
>>> PRs are automatically merged without any maintainer intervention.
>>>
>>> Does such PRs (when submitted to LKML these will be patches) make sense
>>> for DRM subsystem?
>>>
>>> Thanks.
>>>
>>> [1]: https://github.com/torvalds/linux/pull/807
>>>
>>
>> imho I rather not having this automated patches, but I would like to hear the opinions from others.
>>
>
> But why? Did you mean that making the CI always depends on latest version
> of dependencies create another maintenance variable (and may constantly
> broke CI)?
>
> Confused...
Sorry I didn't reply earlier.
I'm ok with that if it doesn't produce much noise, I also think that we
need an automated test to see if the tool is still working as expected
before merging the patch.
The pip there is just used for a helper tool, it is nothing critical.
Regards,
Helen
>
prev parent reply other threads:[~2024-01-08 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 9:38 Bagas Sanjaya
2023-12-19 16:43 ` Helen Koike
2023-12-20 11:11 ` Bagas Sanjaya
2024-01-08 14:53 ` Helen Koike [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfa99bb8-9b7d-4db2-b5bf-35da39b80eda@collabora.com \
--to=helen.koike@collabora.com \
--cc=bagasdotme@gmail.com \
--cc=david.heidelberg@collabora.com \
--cc=dorine.a.tipo@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®