From: Fengyu Wang <wangfengyu@hygon.cn>
To: Valentin Schneider <vschneid@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Chen Yu <yu.c.chen@intel.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jianyong Wu <wujianyong@hygon.cn>,
Yuan Zhong <zhongyuan@hygon.cn>, Huangsj <huangsj@hygon.cn>
Subject: 回复: [PATCH v2] sched/topology: Free NUMA masks on topology allocation failure
Date: Fri, 9 Oct 2026 07:21:52 +0000 [thread overview]
Message-ID: <dfb0cb72eb1a483791dd72fc0f14116d@hygon.cn> (raw)
In-Reply-To: <xhsmhik5c7l55.mognet@vschneid-thinkpadt14sgen2i.remote.csb>
Hi,
A gentle ping on this patch. Thanks to Tim and Valentin for the reviews. Please let me know if there are any further comments or changes needed.
Thanks,
Fengyu
-----邮件原件-----
发件人: Valentin Schneider <vschneid@redhat.com>
发送时间: 2026年8月14日 23:55
收件人: Fengyu Wang <wangfengyu@hygon.cn>; Ingo Molnar <mingo@redhat.com>; Peter Zijlstra <peterz@infradead.org>; Juri Lelli <juri.lelli@redhat.com>; Vincent Guittot <vincent.guittot@linaro.org>
抄送: Dietmar Eggemann <dietmar.eggemann@arm.com>; Steven Rostedt <rostedt@goodmis.org>; Ben Segall <bsegall@google.com>; Mel Gorman <mgorman@suse.de>; K Prateek Nayak <kprateek.nayak@amd.com>; Chen Yu <yu.c.chen@intel.com>; Tim Chen <tim.c.chen@linux.intel.com>; Shrikanth Hegde <sshegde@linux.ibm.com>; linux-kernel@vger.kernel.org; Jianyong Wu <wujianyong@hygon.cn>; Yuan Zhong <zhongyuan@hygon.cn>; Huangsj <huangsj@hygon.cn>; Fengyu Wang <wangfengyu@hygon.cn>
主题: Re: [PATCH v2] sched/topology: Free NUMA masks on topology allocation failure
On 12/08/26 14:22, Fengyu Wang wrote:
> sched_init_numa() publishes sched_domains_numa_masks before it
> allocates the topology array. When that allocation fails, the early
> return leaves the masks published while sched_domains_numa_levels is
> still zero: nothing dereferences them, but nothing can free them
> either, and the topology they were built for is never installed.
>
> Free the masks on that path, and publish them only once the topology
> array they were built for has been allocated.
>
sched_init_numa() still returns nothing, and an allocation failure in scheduler topology code is pretty much always paired with a dumpster fire, but I guess this may help you get further in the booting process of a borked kernel...
> Fixes: cb83b629bae0 ("sched/numa: Rewrite the CONFIG_NUMA sched domain
> support")
> Signed-off-by: Fengyu Wang <wangfengyu@hygon.cn>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
prev parent reply other threads:[~2026-10-09 7:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 6:22 Fengyu Wang
2026-08-12 19:51 ` Tim Chen
2026-08-14 15:54 ` Valentin Schneider
2026-10-09 7:21 ` Fengyu Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfb0cb72eb1a483791dd72fc0f14116d@hygon.cn \
--to=wangfengyu@hygon.cn \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=huangsj@hygon.cn \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sshegde@linux.ibm.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wujianyong@hygon.cn \
--cc=yu.c.chen@intel.com \
--cc=zhongyuan@hygon.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®