From: Zheng Zengkai <zhengzengkai@huawei.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: <linux-security-module@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <jmorris@namei.org>,
<serge@hallyn.com>, <weiyongjun1@huawei.com>
Subject: Re: [PATCH] tomoyo: Avoid potential null pointer access
Date: Fri, 27 Nov 2020 15:17:12 +0800 [thread overview]
Message-ID: <dfb6829e-0fb6-7dbc-5dfa-9707b2f0ae16@huawei.com> (raw)
In-Reply-To: <59e0abdd-88a9-6269-9cd1-0f65792784ec@i-love.sakura.ne.jp>
Hello Tetsuo,
> On 2020/11/26 15:33, Zheng Zengkai wrote:
>> As your say, I found the function tomoyo_assign_namespace( )
>>
>> in security/tomoyo/domain.c has the similar situation,
>>
>> Can I add __GFP_NOWARN for both and remove the null check for _entry_ in tomoyo_assign_namespace( )?
>>
> Good catch. Yes, please send as a patch.
> .
I have resent a patch, thanks!
next prev parent reply other threads:[~2020-11-27 7:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 12:10 Zheng Zengkai
2020-11-25 12:25 ` Tetsuo Handa
2020-11-26 6:33 ` Zheng Zengkai
2020-11-26 6:57 ` Tetsuo Handa
2020-11-27 7:17 ` Zheng Zengkai [this message]
2020-11-27 10:52 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfb6829e-0fb6-7dbc-5dfa-9707b2f0ae16@huawei.com \
--to=zhengzengkai@huawei.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=serge@hallyn.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®