From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E1003CCFA8 for ; Fri, 8 May 2026 16:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778256306; cv=none; b=AJHv2GHXXx791c/d8/EExk9mpUSqdSbWGeQ+2e6dxqXcEuaj0f++rKRYSfH6QhmElEE24lwMW7hW0d2A/pUOv9YIHghRVbnlcFi8RoKxDQMOgUjtnkdFlJ1S1o/fyYIyjXijfARxCRSGRstH6U7eYqKKBiaiFY8vCF234jof5Vo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778256306; c=relaxed/simple; bh=HRn2Ky4V1JZSWSHSC+EMGHuinKEViXVgeQ3zyubsmI0=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=KZtc3Q/DIWFxKvfIHyu8rrxT3C6OrpfafpLVPfuxS2jf1G5JMEk7wkyyOPoEUrulzfXjxxp4r82O4EoYdqOw8gVy5tGKovdxLn+mzJ1XxCXjPV7faEvt3trylgpLN0uGwT2MRFS1yPrDwcBQeFQTiwFtMLbIU52vEvqFTa8oPHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aonQmiFG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Jxu+lqqR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aonQmiFG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Jxu+lqqR" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 648G46T31093516 for ; Fri, 8 May 2026 16:05:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iMxAGx/n9sSrvDZ+nUU28V9GmLoIy4DjjLAMpMsKrTk=; b=aonQmiFGg9G/8ttS RHlIf23vQr252oSLyiaGxiiemHGtyy0gxyErsOyUdw8UvmQSUnsi8XdKqG79ukYA D6swubeyDPk1pSwv0eS7uUuQkF98mRgpa0kuCD1PMC2RNIM3tT4mTHqSFuOpFFXT cSmYWQju3wr0f7VXUINF3r1wm3/x4VOPmXDg6MrJEokIrodT7UPyyKoLbNc6zvh1 jac/VDOkPvLJln/zxFy+QzN8KXc727ZcJ0qw6HHYSHKF2+3/TvraRqR28w1E2Wk9 tuM5BTXU6HEbTn1QSERvdOpotLmh7M0LBsLleyG1ZhbAphthpeB8jQjURIInViCd 8undRw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e1k1d004s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 08 May 2026 16:05:04 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ba603a7d2cso23824885ad.1 for ; Fri, 08 May 2026 09:05:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778256304; x=1778861104; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=iMxAGx/n9sSrvDZ+nUU28V9GmLoIy4DjjLAMpMsKrTk=; b=Jxu+lqqRiXKXw6RcWvqb67QW8Kq2frrEL8QHrWuB11sWs/LzfRvZ8Gjj1Mm+QHTOfV KOua9WVZmy4DRCYmf/C4H2htp6f5d9gTSLMZmY/pLNJWwYYNQAwOhYFw/KKpIboODNQI 36LEoIXXONwQqn4BHBtJGt7LtmR1GolHkP65Zjuk8g2G3hpgTho8UH1gdw2RSzXZAhl8 bzDIvrF0pVUOfApmcrT58oTjt/63SxMN6bX8ahjCG0/pGscrLnctjvt7VdQ/2qstQkFd /0zYJoPK9dnjM6kKi1mq/fV8gLb17OVA8aSPX6YgfNWTlfB13x8FpOJyq4GSazDFTS46 VTGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778256304; x=1778861104; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iMxAGx/n9sSrvDZ+nUU28V9GmLoIy4DjjLAMpMsKrTk=; b=mEjx8ECQn0G0GClwwNkq4WxjnXXOfEgmnFKbzmzuFskKklK1I+6hDGcFxeBALT48Xk 1bxctLBr6V36dZukSnphVUtWhRNxcpVz+SCec/Kafns7b6RpHqWeQ8pspB4e7Uk8zQEL zRZnxB6MWO+Q94FugrN7VJoJpEr2zhwrrtgFACYGXdzUDEoQUG2TkBXdt7c2YR8y146f bfUPKQIZvF41wmDJVlBrdzJ341CxatGXP2qJfc/e80MDnPcJ3h6nT0VC+6VUZYatS2Dx vrmYVqANIJgknYVSNXE5d+2cpRx6tnb4waMdtg5PQaCO/vv4ON5/TCqom0Nk6VgjRk+w dYlg== X-Forwarded-Encrypted: i=1; AFNElJ/deFV7a1T19HmpIuURYgB5nrk/4uaZRIV0jaSOstURB1kKS++hWCY7+BGU8iXYWsx6lYD11zTvWZzqnYA=@vger.kernel.org X-Gm-Message-State: AOJu0YzOyXTEypVoJ4301vK8LPTl47nD6kSTlV1fvlb/tzWchG0vw+mc AZEzQ4+LWpOGp00GYy6f2wy8PIZ673BTSRlmVG7oReGioN5ci0/dYThqT+cc6Ri7VSL5O9w6muS UGnfIJchcGM1laBYZkAlbQMYSpAuyKd8wIKgvUTkq06pYKwYaY6xb6Z90oK89V0KOoeA= X-Gm-Gg: Acq92OEvYVvFRFJCYmS/Xrj0QSnpYcpNxcS+MKX8DB3fpFeHvhukDyPej3ydnU8fnaw FHTZ01uWoxRgeiU+N3SgkjYFmDcrTYFrTgEGLJylFPSNAdn3ToyT+Lg9tnjNNUglnRrsxyJoRvp Yna1E5W6Uc8UlBUfQSLaq5LhctofRogyHoC8WZ04ryMz06AOrOY/3YH2zB+Gnrsofd41heFnis8 uoKz/735SuOF5t6/PeTNiG6y5cwT2+ZuNGVWrkT8Pc416jtVoTruPaP881nqC/k4NNWFL+w/u9X zb6LKRk3Wcy2ib8YQvMw1JVFfeovxL72RjYdDb8TtBhHS+HCgyK6g+xqtlyFq4nxaZKavUWbOxr Pf3PNsFgwbPBcuZ0Vp7R6PD1kYnLmoQY+oxWzpDZHcj1i0R2I9A== X-Received: by 2002:a17:903:22cb:b0:2b9:cabe:ce37 with SMTP id d9443c01a7336-2babc857b01mr72745985ad.1.1778256303907; Fri, 08 May 2026 09:05:03 -0700 (PDT) X-Received: by 2002:a17:903:22cb:b0:2b9:cabe:ce37 with SMTP id d9443c01a7336-2babc857b01mr72745425ad.1.1778256303252; Fri, 08 May 2026 09:05:03 -0700 (PDT) Received: from [192.168.29.32] ([49.43.224.85]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d27242sm30234755ad.9.2026.05.08.09.04.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 May 2026 09:05:02 -0700 (PDT) Message-ID: Date: Fri, 8 May 2026 21:33:58 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Imran Shaik Subject: Re: [PATCH 1/2] dt-bindings: cpufreq: qcom-hw: Document Shikra CPUFREQ Hardware To: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" , Viresh Kumar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Ajit Pandey , Taniya Das , Jagadeesh Kona , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260501-shikra-cpufreq-scaling-v1-0-c78b95f53b91@oss.qualcomm.com> <20260501-shikra-cpufreq-scaling-v1-1-c78b95f53b91@oss.qualcomm.com> <20260504-fuzzy-wapiti-of-ampleness-d8bc13@quoll> <8101e2c8-0593-4325-a701-84f776dd4b0a@oss.qualcomm.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA4MDE2MCBTYWx0ZWRfXxHiwgqRIIOsH Wpp0SADrdfaGetjKKcVsrgia5/vZFQTw2NpWFcF3jq4rd2oxtYoo1y8x0ick1H5kAN7hDhwGOPv dwSKK427jtb957jCd1Ex936Blj+ECdcd5cx968U2Q5//zvr8Cv8UMxh42OjnlvHdZtR2qjvW7KK ZB2L0LGQ4XkXc/AQ3gsyBObyZgYeCRJ9/OzjNJZT2j1icq0B8TGqDrvz2pwuoAvSdy8dHzJpzv3 wTJoPPEodBj6bQiWqAyzuXXqnA+x7rKtdDsyt955FhZiCFKfvSJeK9OwnilirBVjBE1OuNMTqVS 8ZXr7YTQgAX6NIvUsZk3mpGjhqO+NQhVUWmpQ5oJnnNpPTDwEijqEMAyu7vdeCtbeibDvYwhyon LNU58dM9gaiHRzi2tgFKMeb7IVRZ4Fqtg2ikbh26oHNycgNCUZI5T03bhCx54sOoIkeABMDaXXq lmSmq1SsSn4w1/Y3PZA== X-Authority-Analysis: v=2.4 cv=GLU41ONK c=1 sm=1 tr=0 ts=69fe09b0 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=laknryXFXokeiUDc/1ZVVQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=FCm5DZQdfCEVbhGlKnoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: e9wIoKn8rEa8UjOktlL2-dVI99XnZImf X-Proofpoint-GUID: e9wIoKn8rEa8UjOktlL2-dVI99XnZImf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_02,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0 clxscore=1015 impostorscore=0 spamscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605080160 On 05-05-2026 02:23 pm, Krzysztof Kozlowski wrote: > On 05/05/2026 10:50, Imran Shaik wrote: >> >> >> On 04-05-2026 03:53 pm, Krzysztof Kozlowski wrote: >>> On Fri, May 01, 2026 at 12:45:44PM +0530, Imran Shaik wrote: >>>> The Qualcomm Shikra cpufreq hardware is functionally identical to EPSS, >>>> but supports only up to 12 frequency lookup table (LUT) entries. Introduce >>>> qcom,cpufreq-epss-lite to represent this constrained EPSS variant. >>> >>> The entire point of having a generic compatible is that it MUST match >>> all devices. If it does not, then it is pointless to push that generic >>> compatible. >>> >>> I am speaking about qcom,cpufreq-epss. >>> >>> That's nothing new, I was arguing about it already, but now you have >>> confirmation of the mess introduced by generic compatibles. Solution is >>> not to add more generic compatibles, because what will be next? >>> qcom,cpufreq-epss-lighter? >>> qcom,cpufreq-epss-more-lite? >>> qcom,cpufreq-epss-high? >>> >>> Same was here: >>> https://lore.kernel.org/all/20240828203721.2751904-17-quic_nkela@quicinc.com/ >>> >>> So that's second time I object and do object for every new instance. No >>> to generic compatibles, they are proven to be wrong at least for >>> Qualcomm. >>> >>> Best regards, >>> Krzysztof >>> >> >> Hi Krzysztof, >> >> There is no functional change to the latest EPSS hardware >> (qcom,cpufreq-epss) in this case. The Shikra platform uses the CPU >> frequency scaling block, which is a predecessor of EPSS and is referred >> to as EPSS‑lite. The only difference between EPSS‑lite and EPSS is the >> maximum number of frequency look up table (LUT) entries. >> >> This constrained EPSS block is not specific to Shikra and can be reused >> by other SoCs that implement the same hardware. Hence, we have added a >> separate epss-lite compatible and reused the existing bindings, as all >> other aspects of the hardware behavior and interface remain identical. > > I don't understand how any of this is relevant to my comment. I know > what you did. > Hi Krzysztof, The intent behind proposing an epss-lite compatible was to describe a common hardware variant and avoid introducing SoC‑specific handling in the cpufreq driver. While reviewing existing upstream targets, I noticed that SM6375 also appears to use this constrained EPSS hardware variant, which is currently not represented accurately and would require a similar fix. Since both Shikra and SM6375 share this hardware variant, would it be acceptable to use a common epss-lite compatible for these targets? Please let me know your thoughts on this. Thanks, Imran > Best regards, > Krzysztof