From: Joe Perches <joe@perches.com>
To: Linus Walleij <linus.walleij@linaro.org>,
"Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
platform-driver-x86 <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH 1/2] x86: gpio: AMD G-Series pch gpio platform driver
Date: Fri, 08 Feb 2019 09:47:16 -0800 [thread overview]
Message-ID: <dfd0101f4a596600e2f0f8cf36886cf01c7dcb67.camel@perches.com> (raw)
In-Reply-To: <CACRpkdaSEZMR7LuLbO1V0k9QEBu4FWxFbq4ZL1pE9dAvNT1z_Q@mail.gmail.com>
On Fri, 2019-02-08 at 15:25 +0100, Linus Walleij wrote:
> > +/*
> > + * GPIO driver for the AMD G series FCH (eg. GX-412TC)
> > + *
> > + * Copyright (C) 2018 metux IT consult
> > + * Author: Enrico Weigelt <info@metux.net>
> > + *
> > + * SPDX-License-Identifier: GPL+
> > + */
>
> I think checkpatch will complain on that SPDX thing.
> Copy something from one of the other drivers, it should be
> on the first line of the file.
Actually, checkpatch will complain that there isn't
an SPDX license on line 1 but will not complain about
the existence of an SPDX license on other line numbers.
Perhaps checkpatch _should_ complain when it sees an
SPDX license identifier outside the expected line.
next prev parent reply other threads:[~2019-02-08 17:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 1:16 Enrico Weigelt, metux IT consult
2019-02-08 1:16 ` [PATCH 2/2] x86: pcengines apuv2 gpio/leds/keys " Enrico Weigelt, metux IT consult
2019-02-08 14:30 ` Linus Walleij
2019-02-08 15:21 ` Andy Shevchenko
2019-02-11 10:38 ` Enrico Weigelt, metux IT consult
2019-02-13 9:35 ` Linus Walleij
2019-02-14 10:57 ` Enrico Weigelt, metux IT consult
2019-02-08 14:25 ` [PATCH 1/2] x86: gpio: AMD G-Series pch gpio " Linus Walleij
2019-02-08 15:20 ` Andy Shevchenko
2019-02-08 17:47 ` Joe Perches [this message]
2019-02-08 20:44 ` [PATCH] checkpatch: Add test for SPDX-License-Identifier on wrong line # Joe Perches
2019-02-11 12:41 ` Enrico Weigelt, metux IT consult
2019-02-11 12:49 ` Joe Perches
2019-02-11 10:46 ` [PATCH 1/2] x86: gpio: AMD G-Series pch gpio platform driver Enrico Weigelt, metux IT consult
2019-02-13 9:02 ` Linus Walleij
2019-02-14 9:53 ` Enrico Weigelt, metux IT consult
2019-02-14 9:56 ` Enrico Weigelt, metux IT consult
2019-02-20 9:37 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2019-02-07 17:13 Enrico Weigelt, metux IT consult
2019-02-07 18:06 ` Andy Shevchenko
2019-02-08 13:50 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfd0101f4a596600e2f0f8cf36886cf01c7dcb67.camel@perches.com \
--to=joe@perches.com \
--cc=andy@infradead.org \
--cc=bgolaszewski@baylibre.com \
--cc=dvhart@infradead.org \
--cc=info@metux.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@metux.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®