From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7931EECDFB0 for ; Fri, 13 Jul 2018 09:11:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E92C20873 for ; Fri, 13 Jul 2018 09:11:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E92C20873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cn.fujitsu.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729628AbeGMJZf (ORCPT ); Fri, 13 Jul 2018 05:25:35 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:33353 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726364AbeGMJZf (ORCPT ); Fri, 13 Jul 2018 05:25:35 -0400 X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; d="scan'208";a="42210806" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 13 Jul 2018 17:11:41 +0800 Received: from G08CNEXCHPEKD03.g08.fujitsu.local (unknown [10.167.33.85]) by cn.fujitsu.com (Postfix) with ESMTP id A6D2C4B5CBE2; Fri, 13 Jul 2018 17:11:41 +0800 (CST) Received: from localhost.localdomain (10.167.226.106) by G08CNEXCHPEKD03.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.399.0; Fri, 13 Jul 2018 17:11:40 +0800 Subject: Re: [PATCH v13 14/18] x86/tsc: initialize cyc2ns when tsc freq. is determined To: Pavel Tatashin , , , , , , , , , , , , , , , , , , , , References: <20180712000419.5165-1-pasha.tatashin@oracle.com> <20180712000419.5165-15-pasha.tatashin@oracle.com> From: Dou Liyang Message-ID: Date: Fri, 13 Jul 2018 17:11:39 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180712000419.5165-15-pasha.tatashin@oracle.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.226.106] X-yoursite-MailScanner-ID: A6D2C4B5CBE2.AD858 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At 07/12/2018 08:04 AM, Pavel Tatashin wrote: > cyc2ns converts tsc to nanoseconds, and it is handled in a per-cpu data > structure. > > Currently, the setup code for c2ns data for every possible CPU goes through > the same sequence of calculations as for the boot CPU, but is based on the > same tsc frequency as the boot CPU, and thus this is not necessary. > > Initialize the boot cpu when tsc frequency is determined. Copy the > calculated data from the boot CPU to the other CPUs in tsc_init(). > > In addition do the following: > > - Remove unnecessary zeroing of c2ns data by removing cyc2ns_data_init() > - Split set_cyc2ns_scale() into two functions, so set_cyc2ns_scale() can be > called when system is up, and wraps around __set_cyc2ns_scale() that can > be called directly when system is booting but avoids saving restoring > IRQs and going and waking up from idle. > > Suggested-by: Thomas Gleixner > Signed-off-by: Pavel Tatashin > --- > arch/x86/kernel/tsc.c | 94 ++++++++++++++++++++++++------------------- > 1 file changed, 53 insertions(+), 41 deletions(-) > > diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c > index bc8eb82050a3..0b1abe7fdd8e 100644 > --- a/arch/x86/kernel/tsc.c > +++ b/arch/x86/kernel/tsc.c > @@ -103,23 +103,6 @@ void cyc2ns_read_end(void) > * -johnstul@us.ibm.com "math is hard, lets go shopping!" > */ > > -static void cyc2ns_data_init(struct cyc2ns_data *data) > -{ > - data->cyc2ns_mul = 0; > - data->cyc2ns_shift = 0; > - data->cyc2ns_offset = 0; > -} > - > -static void __init cyc2ns_init(int cpu) > -{ > - struct cyc2ns *c2n = &per_cpu(cyc2ns, cpu); > - > - cyc2ns_data_init(&c2n->data[0]); > - cyc2ns_data_init(&c2n->data[1]); > - > - seqcount_init(&c2n->seq); > -} > - > static inline unsigned long long cycles_2_ns(unsigned long long cyc) > { > struct cyc2ns_data data; > @@ -135,18 +118,11 @@ static inline unsigned long long cycles_2_ns(unsigned long long cyc) > return ns; > } > > -static void set_cyc2ns_scale(unsigned long khz, int cpu, unsigned long long tsc_now) > +static void __set_cyc2ns_scale(unsigned long khz, int cpu, unsigned long long tsc_now) > { > unsigned long long ns_now; > struct cyc2ns_data data; > struct cyc2ns *c2n; > - unsigned long flags; > - > - local_irq_save(flags); > - sched_clock_idle_sleep_event(); > - > - if (!khz) > - goto done; > > ns_now = cycles_2_ns(tsc_now); > > @@ -178,12 +154,55 @@ static void set_cyc2ns_scale(unsigned long khz, int cpu, unsigned long long tsc_ > c2n->data[0] = data; > raw_write_seqcount_latch(&c2n->seq); > c2n->data[1] = data; > +} > + > +static void set_cyc2ns_scale(unsigned long khz, int cpu, unsigned long long tsc_now) > +{ > + unsigned long flags; > + > + local_irq_save(flags); > + sched_clock_idle_sleep_event(); > + > + if (khz) > + __set_cyc2ns_scale(khz, cpu, tsc_now); > > -done: > sched_clock_idle_wakeup_event(); > local_irq_restore(flags); > } > > +/* > + * Initialize cyc2ns for boot cpu > + */ > +static void __init cyc2ns_init_boot_cpu(void) > +{ > + struct cyc2ns *c2n = this_cpu_ptr(&cyc2ns); > + > + seqcount_init(&c2n->seq); > + __set_cyc2ns_scale(tsc_khz, smp_processor_id(), rdtsc()); > +} Hi Paval, Here we didn't protect it with local_irq_save()/local_irq_restore() > + > +/* > + * Secondary CPUs do not run through cyc2ns_init(), so set up > + * all the scale factors for all CPUs, assuming the same > + * speed as the bootup CPU. (cpufreq notifiers will fix this > + * up if their speed diverges) > + */ > +static void __init cyc2ns_init_secondary_cpus(void) > +{ > + unsigned int cpu, this_cpu = smp_processor_id(); > + struct cyc2ns *c2n = this_cpu_ptr(&cyc2ns); > + struct cyc2ns_data *data = c2n->data; > + > + for_each_possible_cpu(cpu) { > + if (cpu != this_cpu) { > + seqcount_init(&c2n->seq); > + c2n = per_cpu_ptr(&cyc2ns, cpu); > + c2n->data[0] = data[0]; > + c2n->data[1] = data[1]; > + } > + } > +} > + > /* > * Scheduler clock - returns current time in nanosec units. > */ > @@ -1385,6 +1404,10 @@ void __init tsc_early_init(void) > if (!determine_cpu_tsc_frequncies()) > return; > loops_per_jiffy = get_loops_per_jiffy(); > + > + /* Sanitize TSC ADJUST before cyc2ns gets initialized */ > + tsc_store_and_check_tsc_adjust(true); > + cyc2ns_init_boot_cpu(); > } > > void __init tsc_init(void) > @@ -1400,23 +1423,12 @@ void __init tsc_init(void) > mark_tsc_unstable("could not calculate TSC khz"); > return; > } > + /* Sanitize TSC ADJUST before cyc2ns gets initialized */ > + tsc_store_and_check_tsc_adjust(true); > + cyc2ns_init_boot_cpu(); In tsc_init(), the timer interrupt has worked, Is that OK? IMO, no need to change so much, just use the original code, eg: +static void __init cyc2ns_init_bsp(void) +{ + cyc2ns_init(0); + set_cyc2ns_scale(tsc_khz, 0, rdtsc()); +} + +static void __init cyc2ns_init_cpus(void) +{ + struct cyc2ns *c2n0 = &per_cpu(cyc2ns, 0); + struct cyc2ns *c2n; + unsigned int cpu; + + for_each_possible_cpu(cpu) { + if (cpu != 0) { + cyc2ns_init(cpu); + c2n = &per_cpu(cyc2ns, cpu); + c2n->data[0] = c2n0->data[0]; + c2n->data[1] = c2n0->data[1]; + } + } +} + Thanks, dou > } > > - /* Sanitize TSC ADJUST before cyc2ns gets initialized */ > - tsc_store_and_check_tsc_adjust(true); > - > - /* > - * Secondary CPUs do not run through tsc_init(), so set up > - * all the scale factors for all CPUs, assuming the same > - * speed as the bootup CPU. (cpufreq notifiers will fix this > - * up if their speed diverges) > - */ > - cyc = rdtsc(); > - for_each_possible_cpu(cpu) { > - cyc2ns_init(cpu); > - set_cyc2ns_scale(tsc_khz, cpu, cyc); > - } > - > + cyc2ns_init_secondary_cpus(); > static_branch_enable(&__use_tsc); > > if (!no_sched_irq_time) >