From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Thomas Gleixner <tglx@linutronix.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
arnd@arndb.de, vincenzo.frascino@arm.com, luto@kernel.org
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
x86@kernel.org
Subject: Re: [RFC PATCH v2 07/10] lib: vdso: don't use READ_ONCE() in __c_kernel_time()
Date: Mon, 13 Jan 2020 07:52:31 +0100 [thread overview]
Message-ID: <dfd30b00-5d5c-29c3-6b91-aac0533635ca@c-s.fr> (raw)
In-Reply-To: <878smes13d.fsf@nanos.tec.linutronix.de>
Le 11/01/2020 à 12:07, Thomas Gleixner a écrit :
> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>>
>> With READ_ONCE() the 64 bits are being read:
>>
>> Without the READ_ONCE() only 32 bits are read. That's the most optimal.
>>
>> Without READ_ONCE() but with a barrier() after the read, we should get
>> the same result but GCC (GCC 8.1) does less good:
>>
>> Assuming both part of the 64 bits data will fall into a single
>> cacheline, the second read is in the noise.
>
> They definitely are in the same cacheline.
>
>> So agreed to drop this change.
>
> We could be smart about this and force the compiler to issue a 32bit
> read for 32bit builds. See below. Not sure whether it's worth it, but
> OTOH it will take quite a while until the 32bit time interfaces die
> completely.
I don't think it is worth something so big to just save 1 or 2 cycles in
time() function. Lets keep it as it is.
Thanks,
Christophe
>
> Thanks,
>
> tglx
>
> 8<------------
> --- a/include/vdso/datapage.h
> +++ b/include/vdso/datapage.h
> @@ -21,6 +21,18 @@
> #define CS_RAW 1
> #define CS_BASES (CS_RAW + 1)
>
> +#ifdef __LITTLE_ENDIAN
> +struct sec_hl {
> + u32 sec_l;
> + u32 sec_h;
> +};
> +#else
> +struct sec_hl {
> + u32 sec_h;
> + u32 sec_l;
> +};
> +#endif
> +
> /**
> * struct vdso_timestamp - basetime per clock_id
> * @sec: seconds
> @@ -35,7 +47,10 @@
> * vdso_data.cs[x].shift.
> */
> struct vdso_timestamp {
> - u64 sec;
> + union {
> + u64 sec;
> + struct sec_hl sec_hl;
> + };
> u64 nsec;
> };
>
> --- a/lib/vdso/gettimeofday.c
> +++ b/lib/vdso/gettimeofday.c
> @@ -165,8 +165,13 @@ static __maybe_unused int
> static __maybe_unused __kernel_old_time_t __cvdso_time(__kernel_old_time_t *time)
> {
> const struct vdso_data *vd = __arch_get_vdso_data();
> - __kernel_old_time_t t = READ_ONCE(vd[CS_HRES_COARSE].basetime[CLOCK_REALTIME].sec);
> + __kernel_old_time_t t;
>
> +#if BITS_PER_LONG == 32
> + t = READ_ONCE(vd[CS_HRES_COARSE].basetime[CLOCK_REALTIME].sec_hl.sec_l);
> +#else
> + t = READ_ONCE(vd[CS_HRES_COARSE].basetime[CLOCK_REALTIME].sec);
> +#endif
> if (time)
> *time = t;
>
>
next prev parent reply other threads:[~2020-01-13 6:52 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 14:31 [RFC PATCH v2 00/10] powerpc/32: switch VDSO to C implementation Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 01/10] lib: vdso: ensure all arches have 32bit fallback Christophe Leroy
2019-12-24 2:07 ` Andy Lutomirski
2020-01-10 20:56 ` Thomas Gleixner
2020-01-10 21:02 ` Andy Lutomirski
2019-12-30 12:27 ` Arnd Bergmann
2020-01-02 11:29 ` Arnd Bergmann
2020-01-09 15:43 ` Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 02/10] lib: vdso: move call to fallback out of common code Christophe Leroy
2019-12-24 2:24 ` Andy Lutomirski
2019-12-24 11:41 ` christophe leroy
2019-12-24 12:09 ` Andy Lutomirski
2019-12-23 14:31 ` [RFC PATCH v2 03/10] lib: vdso: Change __cvdso_clock_gettime/getres_common() to __cvdso_clock_gettime/getres() Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 04/10] lib: vdso: get pointer to vdso data from the arch Christophe Leroy
2019-12-24 2:27 ` Andy Lutomirski
2019-12-24 11:53 ` christophe leroy
2019-12-24 12:15 ` Andy Lutomirski
2019-12-24 12:41 ` Andy Lutomirski
2019-12-24 14:46 ` Segher Boessenkool
2019-12-23 14:31 ` [RFC PATCH v2 05/10] lib: vdso: inline do_hres() Christophe Leroy
2019-12-24 2:29 ` Andy Lutomirski
2019-12-30 12:07 ` Arnd Bergmann
2020-01-10 21:07 ` Thomas Gleixner
2020-01-11 9:06 ` Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 06/10] lib: vdso: make do_coarse() return 0 Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 07/10] lib: vdso: don't use READ_ONCE() in __c_kernel_time() Christophe Leroy
2019-12-24 1:58 ` Andy Lutomirski
2019-12-24 11:12 ` christophe leroy
2019-12-24 12:04 ` Andy Lutomirski
2020-01-10 21:12 ` Thomas Gleixner
2020-01-11 8:05 ` Christophe Leroy
2020-01-11 11:07 ` Thomas Gleixner
2020-01-13 6:52 ` Christophe Leroy [this message]
2019-12-23 14:31 ` [RFC PATCH v2 08/10] lib: vdso: Avoid duplication in __cvdso_clock_getres() Christophe Leroy
2019-12-24 1:59 ` Andy Lutomirski
2019-12-23 14:31 ` [RFC PATCH v2 09/10] powerpc/vdso32: inline __get_datapage() Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 10/10] powerpc/32: Switch VDSO to C implementation Christophe Leroy
2020-01-09 17:52 ` Surprising code generated for vdso_read_begin() Christophe Leroy
2020-01-09 20:07 ` Segher Boessenkool
2020-01-10 6:45 ` Christophe Leroy
2020-01-11 11:33 ` Segher Boessenkool
2020-02-16 18:10 ` Arnd Bergmann
2020-02-19 8:45 ` Christophe Leroy
2020-02-19 9:52 ` Arnd Bergmann
2020-02-19 13:08 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfd30b00-5d5c-29c3-6b91-aac0533635ca@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®