mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: YongSu Yoo <yongsuyoo0215@gmail.com>,
	linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Hyunwoo Kim <v4bel@theori.io>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	yongsu.yoo@lge.com
Subject: Re: [PATCH] media: dvb_ca_en50221: Fix a bug for detecting CI MODULE
Date: Thu, 23 May 2024 16:02:16 +0200	[thread overview]
Message-ID: <dfd94898-fabb-4089-8c04-42c2917f22dc@web.de> (raw)
In-Reply-To: <CANXPkT59y5k_DXgk6DDHbGuR6aqwLN1ugeLhFrEmk=c246i9zg@mail.gmail.com>

> 1. What is the "typo" ?

Please take another look at opportunities for spell checking
also in commit messages.

>>>> … right informtion. … a Bug. …


> 2. Can you take some examples which show the "Imperative wording" ?

I hope that you can take published guidance better into account
(instead of the wording “We fix this bug.” in the discussed changelog).
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94


> 3. Can you give me some examples for adding "Fixes" ?

An other tag specification might be more appropriate
than the following suggestion.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n145

Fixes: a75aa90c7c2f ("media: dvb_ca_en50221: Used a helper variable")


Regards,
Markus

      reply	other threads:[~2024-05-23 14:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08 12:10 yongsuyoo0215
2024-04-11 12:03 ` YongSu Yoo
2024-05-01  7:54   ` YongSu Yoo
2024-05-01 16:25 ` Markus Elfring
2024-05-23 13:11   ` YongSu Yoo
2024-05-23 14:02     ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfd94898-fabb-4089-8c04-42c2917f22dc@web.de \
    --to=markus.elfring@web.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=v4bel@theori.io \
    --cc=yongsu.yoo@lge.com \
    --cc=yongsuyoo0215@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®