From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Lee Jones <lee.jones@linaro.org>, <davem@davemloft.net>,
<kuba@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Kurt Kanzenbach <kurt@linutronix.de>, <netdev@vger.kernel.org>
Subject: Re: [PATCH 07/12] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter
Date: Wed, 4 Nov 2020 13:37:08 +0200 [thread overview]
Message-ID: <dfddd6d2-6e71-775e-c121-981a21f97950@ti.com> (raw)
In-Reply-To: <20201104090610.1446616-8-lee.jones@linaro.org>
On 04/11/2020 11:06, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/ti/am65-cpts.c:736: warning: Function parameter or member 'en' not described in 'am65_cpts_rx_enable'
> drivers/net/ethernet/ti/am65-cpts.c:736: warning: Excess function parameter 'skb' description in 'am65_cpts_rx_enable'
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Cc: Kurt Kanzenbach <kurt@linutronix.de>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/net/ethernet/ti/am65-cpts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/am65-cpts.c b/drivers/net/ethernet/ti/am65-cpts.c
> index 75056c14b161b..bb2b8e4919feb 100644
> --- a/drivers/net/ethernet/ti/am65-cpts.c
> +++ b/drivers/net/ethernet/ti/am65-cpts.c
> @@ -727,7 +727,7 @@ static long am65_cpts_ts_work(struct ptp_clock_info *ptp)
> /**
> * am65_cpts_rx_enable - enable rx timestamping
> * @cpts: cpts handle
> - * @skb: packet
> + * @en: enable
> *
> * This functions enables rx packets timestamping. The CPTS can timestamp all
> * rx packets.
>
Thank you.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
Best regards,
grygorii
next prev parent reply other threads:[~2020-11-04 11:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 9:05 [PATCH 00/12] [Set 2] Rid W=1 warnings in Net Lee Jones
2020-11-04 9:05 ` [PATCH 01/12] net: usb: lan78xx: Remove lots of set but unused 'ret' variables Lee Jones
2020-11-04 13:23 ` Andrew Lunn
2020-11-04 9:06 ` [PATCH 02/12] net: ethernet: smsc: smc911x: Mark 'status' as __maybe_unused Lee Jones
2020-11-04 13:22 ` Andrew Lunn
2020-11-04 14:31 ` Lee Jones
2020-11-04 14:38 ` Lee Jones
2020-11-04 14:47 ` Andrew Lunn
2020-11-04 14:45 ` Andrew Lunn
2020-11-04 14:56 ` Lee Jones
2020-11-04 9:06 ` [PATCH 03/12] net: ethernet: xilinx: xilinx_emaclite: Document 'txqueue' even if it is unused Lee Jones
2020-11-04 13:24 ` Andrew Lunn
2020-11-04 9:06 ` [PATCH 04/12] net: ethernet: smsc: smc91x: Demote non-conformant kernel function header Lee Jones
2020-11-04 9:06 ` [PATCH 05/12] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers Lee Jones
2020-11-04 12:00 ` Wei Liu
2020-11-04 13:27 ` Andrew Lunn
2020-11-04 9:06 ` [PATCH 06/12] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header Lee Jones
2020-11-04 13:33 ` Andrew Lunn
2020-11-04 14:28 ` Lee Jones
2020-11-04 14:38 ` Andrew Lunn
2020-11-04 15:02 ` Lee Jones
2020-11-04 9:06 ` [PATCH 07/12] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter Lee Jones
2020-11-04 11:37 ` Grygorii Strashko [this message]
2020-11-04 9:06 ` [PATCH 08/12] net: xen-netfront: Demote non-kernel-doc headers to standard comment blocks Lee Jones
2020-11-04 9:31 ` Jürgen Groß
2020-11-04 13:36 ` Andrew Lunn
2020-11-04 9:06 ` [PATCH 09/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours Lee Jones
2020-11-04 13:38 ` Andrew Lunn
2020-11-04 17:54 ` drt
2020-11-04 9:06 ` [PATCH 10/12] net: ethernet: toshiba: ps3_gelic_net: " Lee Jones
2020-11-04 13:41 ` Andrew Lunn
2020-11-04 9:06 ` [PATCH 11/12] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters Lee Jones
2020-11-04 13:43 ` Andrew Lunn
2020-11-04 9:06 ` [PATCH 12/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues Lee Jones
2020-11-04 17:59 ` drt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfddd6d2-6e71-775e-c121-981a21f97950@ti.com \
--to=grygorii.strashko@ti.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®