From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 761D125B081 for ; Tue, 9 Jun 2026 05:35:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780983328; cv=none; b=RR4T6rGzK3KBDBdUwPzahyxBoguRIbzqSS9+SfKgjaYhsnRhFCcRPZ2kfZXDOUSNixKsfTBq1FB1gKLY0oBLUKeY0fR+W6j4MQQz6bjJ3uX4hftD208KcdTAOTqndySU6CMJ/SSX8lL80KGLaQhq0mMzR77Cg0vK0836o9UiVXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780983328; c=relaxed/simple; bh=f8mZuRJM1Xj5UTCzYVtCxP6hZpPvwo/hvNTtsESfDEM=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=Hoyt79uPibQabr0ch1hGeVnQK8tsl1uY5hieG2E7+F9zw5LgSVtXI/yIUz4ulhly0tpEaPVtwIWDB9AJW1V5kn69tzEaprJVjAuf7nn0Ly2OgfIRjyw9WKkOlxY3RUw3k24YsRb84uMCfHt62k5Gcn/3ntIg2o6xhzQyOs97IUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PnwvTIbq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BNYRjo3Y; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PnwvTIbq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BNYRjo3Y" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6593wsqg1061888 for ; Tue, 9 Jun 2026 05:35:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= m8X/m6BpotSV0s2wlIu70ir+Zo0Bu84qxjgZXHCPBHk=; b=PnwvTIbqhaocR5C3 gMnO3Z+xkNWMNDC9UUaapGPH6ugZiKrj1hcJQ90vC2gTdNFfBVbjJ6Bs7aPn4yKa Mfy9dy8FYwpFf9tzaNBBAEt/8DLU/CkCG/cX4Mbx1fzBSZswIMWxXaTGN3M7Y8yL zZuDUYt7YM/KGFYBZKTLxeWwxHamC/BymfpDI9UbXgh1hx3wHvLUiprEuCwrLk71 Pvr2A4f+Zez3BvyGvs+WcjEAMpqIMQeZi5DJb4FWkM9kkblszGNcN5pQXRefJqMG rEVGuAkCIEOP+f0jwecG5ej78hTyCDUsU3cD3lsHTXtWcxNcFy8kxgTgmnqB4wQ5 AfTqVw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4envajcaen-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 05:35:26 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2bf160f7191so30564805ad.3 for ; Mon, 08 Jun 2026 22:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780983326; x=1781588126; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=m8X/m6BpotSV0s2wlIu70ir+Zo0Bu84qxjgZXHCPBHk=; b=BNYRjo3YojkezcgwToT8YPcHzQLbiCIoSFIoWxFIzGjV0fHykR9dAszMSpdVeD0dYv 65TnPXER5vD6zWUNX6UkHvHz4aQoj7AADlRd70Lvi6/TP012YLvGp8z/6eqeVc+HD3vO FJOYbk4zzSgtV77igaE9j5ytkZ6BE1WMMnYW3ydIMi6U6g+feQSRbmRJYIT99GpJ4L8/ vJd+IDudUfIXpqJkfNefiU/DYCABHnPaGtwGH0OuOp8iNkloeLAf2eTptwMuAoWwuEDW JD/QtoLeievNrJgoyKZ+Tz3QuQWFpFFIC0sp3mFOQRins3Zc5IFDp5aoufn6SO1oX7ji WUHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780983326; x=1781588126; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m8X/m6BpotSV0s2wlIu70ir+Zo0Bu84qxjgZXHCPBHk=; b=sv7FfFxKR322IaqZWzN3Tg+Y7vkXT4pd+5wJ9F2Wf+bxi2Foo9JYot+HYh+2CKZGWy baHT64ZkrSBZz8EM1bFHjGhd3wLu8HnMEkBCOHwzDZHwe6wr8xWLC4lLYnZPVqAjQuNh 8vosQpACp+DYjL/cnTTGipW0XryMm8UmMh9g3HXaV+v1PRlxU6CIVoJn4UwbFQC4AHrG pFSylWTkL07OzU5HkstYU+RnDZa5wbRT14TEL2Zq3tbVAIhPRITJEMQjdVU9/Oyo78k5 cPEmW5l3AkolH+4+qFmx9EVzFtYNA+0QbJYfQenBskjh65tPmyZOgzvUjVkK+WP4+PmG YBhw== X-Forwarded-Encrypted: i=1; AFNElJ+ya567vitqpQ7+mNYYLsajuBqGAFxYNlFtEDzi49GSDZzboXOU7YgX/V0Sf7VD3r6UbcTtxA85DoThMaw=@vger.kernel.org X-Gm-Message-State: AOJu0Yydp/CCRku/7RaulvAapSEkaOMmXQ1bkzO4SADFhxWtOiI43HYD bFoxorMfBofSrq3RtStGTfNCGxIxdBs9h833GOG3WTFWBoBnaqphvdTHnySvCQ2h6CYlXEq8YVl YVgCLYmYcLoYKZWtFd24S84t8Z7chCv7c/2etnX8GsXylzZlF0JaD1yDyXgyGLtx0OpB5Az/jVH Q= X-Gm-Gg: Acq92OHa0Htht2h5JvzUNWh9kqKVnJraR/iG7QZ7WsF1YkUFv0/HY2/PWQc4ZreNLrq r4YFUg4qTc0JVD+0DENX36P4t/pHb29I9iEpvbckkD51PtLPQozl3wKm2mglCJgbpKDgeCY+wIk lOLVy+2ktqxX7vhkCy2JcsJ6YBymqDs0LFcohLjoa64QaZyXLBTO1ssJB8xRcvSW94hfUU5mFzf XzXrtU5M9bwtC9iYxOiTnf7AFxlYenkSuU+ZEX3rcyC2uqemvEPhz+y+u8/HARIEGVwAOrcUNqe w0kCluneOBrWgmM7OlrY/eLcjaR8HQssUkNQjhlv6ibTYq5Fv6+wChqsSAgr38sVBke5jg5127i OlIuaT/jhZzC9lRidpkbE2jSmEr1jfMuFk1TXcCPHxQcHx26WpGwNv/VAjNA//ITWc+jQTC5MRf dS X-Received: by 2002:a17:903:1b44:b0:2c0:c262:b925 with SMTP id d9443c01a7336-2c1e7f9252fmr219153725ad.25.1780983326030; Mon, 08 Jun 2026 22:35:26 -0700 (PDT) X-Received: by 2002:a17:903:1b44:b0:2c0:c262:b925 with SMTP id d9443c01a7336-2c1e7f9252fmr219153385ad.25.1780983325599; Mon, 08 Jun 2026 22:35:25 -0700 (PDT) Received: from [10.151.37.217] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f94a7fsm202031215ad.28.2026.06.08.22.35.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 22:35:25 -0700 (PDT) Message-ID: Date: Tue, 9 Jun 2026 11:05:21 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: ipq5332: Move PHYs and PERST# to Root Port node From: Kathiravan Thirumoorthy To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260602-move_perst_to_rp-v1-0-8ee5b80316da@oss.qualcomm.com> <20260602-move_perst_to_rp-v1-1-8ee5b80316da@oss.qualcomm.com> <26374aa0-1db0-4d90-9cec-b546df598155@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <26374aa0-1db0-4d90-9cec-b546df598155@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: udwk4VjTemgkyyiRUqFdI_MFgX6D0pag X-Authority-Analysis: v=2.4 cv=eo3vCIpX c=1 sm=1 tr=0 ts=6a27a61e cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=o1Qc89-7ai6OhWUoDCwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: udwk4VjTemgkyyiRUqFdI_MFgX6D0pag X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDA0OSBTYWx0ZWRfXxrjOfy5YzwU3 dZ0XZ9a15k4l3pJBJLeTjDZ8rFnPVUhgv1Vz8IWEvPGgI6PFJPm+hIHVS2y2YyNeLcJKboO9Ph4 yBqvFLdx0D3zbdOzaeBGufeHmxTdxPsHWrt4wP3ji/gUGgySJ7MpDX8irCYGugbA+IxKlm8W23c Vm6/nvnR2A0ZC4gIdmq5MZGvQ+UiTPRgXU7H04E75QLV/+Y72T0FOD3DeXkpwqD6h2c7q5b0BbC Hqj0TsTEfQTu3/GoVHob6MhRPdKp7TacEecUiY6eG/UF1eqoP2K1iLA5kn2omr8jgOBs1F/pmm1 EUErWvGD/bZK9S0yBVqUEBYSQBWx0FHHvtwV3ZU4iX//casz41wL0fJnC+LRcXGqhi3Bber4gmk H+/vyWubvtYoz28/q4AQxSMa79CVk5iXwPkNyN0wI+66lqJzWMcO4Zz/AKTzXgKE+uWOLmjlbId e4p0U8kicgpNErmbZ5A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_01,2026-06-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 phishscore=0 clxscore=1015 bulkscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090049 On 6/9/2026 10:55 AM, Kathiravan Thirumoorthy wrote: > > On 6/8/2026 3:52 PM, Konrad Dybcio wrote: >> On 6/2/26 6:34 PM, Kathiravan Thirumoorthy wrote: >>> Follow the new binding style by defining PHYs and PERST# (now RESET#) >>> under the Root Port node. Avoid mixing styles and move these properties >>> to the RP node. >>> >>> Signed-off-by: Kathiravan Thirumoorthy >>> >>> --- >> [...] >> >>>   -            pcie@0 { >>> +            pcie1_port0: pcie@0 { >>>                   device_type = "pci"; >>>                   reg = <0x0 0x0 0x0 0x0 0x0>; >>>                     #address-cells = <3>; >>>                   #size-cells = <2>; >>>                   ranges; >>> +                phys = <&pcie1_phy>; >> nit: other socs (like hamoa) do it like this: >> >> pcie3_port0: pcie@0 { >>     device_type = "pci"; >>     compatible = "pciclass,0604"; >>     reg = <0x0 0x0 0x0 0x0 0x0>; >>     bus-range = <0x01 0xff>; >> >>     phys = <&pcie3_phy>; >> >>     #address-cells = <3>; >>     #size-cells = <2>; >>     ranges; >> }; > > Ack. Let me add the 'bus-range' property and move the 'phys' next to it. Just checked the history, it is dropped due to default values. Given that, let me move the 'phys' before #address-cells property. > >> Konrad