From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01016392C48 for ; Thu, 22 Jan 2026 08:32:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769070735; cv=none; b=KVFZ7/xy7b1xC99RqIodPsWywnuZwiJtbY5Ip0rUvFm8xoSVh0hWQ1Mxd0TQIpvcG2m7iOY+vKcwHp+Zs+Fkh+psf/KlQg3iZzdHwRrgI2R+4vN+npbp1XGYF+fc5nsSz2K1g0X1jcRNvzRISQ1fmCghwIpCy9MrqSuq/RFLZDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769070735; c=relaxed/simple; bh=uATaKfecwuZpQlE1wgafrpigCMzAtsS4/43cAsKSuyw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dSIkhhVMNlSplDT/KoyKoDRtUrYYJW2iRYeM27DwLnUPJIg1P5gVElKzc4fq2d0Ar7e9jXHeRxwB8G8w9/aPn8fVapmLtBJB+IyTYEnzMZ0ZtE4O0aWupmDvCRJT1p9A4c99wavAw1d5/zzJy8xoXGaetgerg+r8zRuOVvbB158= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I/JPliBO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GCgQBccA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I/JPliBO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GCgQBccA" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60M6raZL724821 for ; Thu, 22 Jan 2026 08:32:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LB7h5TBBAjWDecbOflZxYmaW8tipfD/xijV1P46UIYA=; b=I/JPliBO7FAYLWCD 18cZR9dv1dhXIdnILDga7Fm6EGD9281nA+oAtHNWSbogUQFNePibusYGzYU4xKUZ lC1NtxgAi80zP5BlUEPoNeKQ4Z+AJJKA3sGjLYkb574D780Ljn+H7fMkpMfX81h5 ZtxBfBfY5FSJxlm4kPXfqS72VmrKd18Nxk3zFxHAFwfH9L3U+WKSjgSlTR3px6hK Sn9WTyjZtMSUKF59vdO+aFSLAugzBu8fGCs//CieBQwL/RF5aDIqG7bGqMpMUCEy D+2dO9Xn/86D1Df13Lw9BwBD1PqhVS+Q1J1pkaPreQDGsInMxXYyxaJ8K4eUcTvf N0V71w== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4buf1bg91p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 22 Jan 2026 08:32:12 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8c52de12a65so17329285a.2 for ; Thu, 22 Jan 2026 00:32:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769070732; x=1769675532; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LB7h5TBBAjWDecbOflZxYmaW8tipfD/xijV1P46UIYA=; b=GCgQBccAUfA7FnwzBgInyEIZlkxx7El+OMWWpvNGqciFM+lIUlnm8MglH+pHihHis3 XaCkAdSUyYLoIDg0IgFT3H9UmSAplncIfQrlGgNZg+62zPhz4RMcSxOrRwR9fm3ndzxr 7KnOTZ3Bh9mtEdhCQEXjNMpHlkEXXZ7+8hJ1R/HycOyEPGz4VWaQ+5sS/z7cOMS70Vai TpiQVmgC2gEmhVv1EgGC8nkxMpgOrt6b+Gff5Wxbi5z0cb5xhSSpoZTvifj21WwhTO/7 EpvBxQipRhYVfiR/cwjgQFgP7eAwgRpXEOBQgkoVn4VigZbGdbzgWUm05FUS3bRNS70S 7miA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769070732; x=1769675532; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LB7h5TBBAjWDecbOflZxYmaW8tipfD/xijV1P46UIYA=; b=hN87HRBgM/zqx9IhgyBxv1ApKsDMrrJGli1UHKP3spoCLmrDV0XqUe5BId1R9AGh04 wySP1dAA6UmZiKdeQzlRki34WViExkePrk2+3vWx9eYHbEUCFzip3Ng/eyQC8UeuFswl 6R7ct1YRbt4A5Q6HQAYSfjXDbeL3XzJQLij7X56KOvOi0NIvQSd8fVPbYlvoM1GuTbk+ tBvbY0MVjafzess2nIYJNJU3n2qQPfZ2wr5NXOD0GA/TIJXw1VuaR3E0HVX9vS5rhJDK 2zxzTVrQzSkdb11VyC4KT9XLrRrMzUMPOSLZkhyyCJGPZ9dsM1+OqESLRR7nWZm7hxNv IS/Q== X-Forwarded-Encrypted: i=1; AJvYcCVOaoBz1GD4q9dDGRpx/9/dYPTCnCthVfJAvQ1W6DVQtmV/IlNcFtlYMiS4g0lPm4NMcAk2KeCirtLv/8c=@vger.kernel.org X-Gm-Message-State: AOJu0YxiArh6RdG9pr0WPTpw9XCJDIH1ekx/UGB0GDy1iCLk76L3172D Sf26BvJyuNmLv578le/5fEm1/S4wfYMRFmpnDrFtdcRpotJlZJQ0JkA2WxxjjHKJM7C+WNjmBS7 yE7DwGEu9JwJZAysu5GwmJloOpYAEMBVFxL70j6ZYVo7PMJ7FfOOhLCRgwG2DF107Cx0= X-Gm-Gg: AZuq6aKpcwZkiFbWHPvD28CHOaNOxcLrXAUMY1F9J5/aLp8eClCtHQj9AZMFEGflmVQ M6+XoE5/TbWynCSbcAD1LIeEkeuC0QUdFsk6GsqD+C9z1W4Q88gH4eroPxojuxXZCasACsR3dSY HYE/U2uKA+TUkCF60IAtOobt3TuGqMOlFxT2cOX9Vi8y0EYErc0eEnL1MpAHolIH+QayZnoBlOF QftJlvK4MYDqJ5DpA8yBvMu3fyfYTPOarIB8vhlJYkktGFgODqIh6KhLyQ/9pp+bi4Ru5M50HSQ N0OshrjKDLXjGLvFJl8WgTQx6XFt83Em9oetnI3anGTryZZGUI+3B+ZnODiVhsgDK5afUdePp+A 3Bht4AweKtL5MlLcYFa1iuQBAMTkT7UPmxHEbC3kS4gpYif44s9f/oYoIKbvKSBRu+MY= X-Received: by 2002:a05:620a:1920:b0:8b2:e704:55fe with SMTP id af79cd13be357-8c6dafed670mr207525085a.10.1769070731568; Thu, 22 Jan 2026 00:32:11 -0800 (PST) X-Received: by 2002:a05:620a:1920:b0:8b2:e704:55fe with SMTP id af79cd13be357-8c6dafed670mr207522885a.10.1769070731024; Thu, 22 Jan 2026 00:32:11 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b87959c9f8dsm1646666766b.36.2026.01.22.00.32.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 00:32:10 -0800 (PST) Message-ID: Date: Thu, 22 Jan 2026 09:32:08 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: milos-fairphone-fp6: Add Hall Effect sensor To: Dmitry Torokhov , Luca Weiss Cc: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org References: <20260116-fp6-hall-sensor-v1-1-69275c6bd809@fairphone.com> <3a17f2e5-0724-4d70-bd22-1e612142b3e8@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: DygEj_j_XWaP6tiX6YhfDlYyapKwukvl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIyMDA1NiBTYWx0ZWRfXwMX29tjz7LkU iQ2IIxuPL0LUf30vLqHsXQDfjiFgSPEakpmnzL+PNxWXBhG4JGm6sRoKZzFT3L8GgHBOR4IchKN vXY7lGCdydWjdYz13O8iY9Ys4+xP5iwSbmt8XfMlu0P32K28/ye9fHTpAnhf+S9KS5zwUNDvAGT LyLYPxOva6MH8/TD6CiILLm2ACyn4nINfU0hYT2rmOkYwUq7rHeICcRP+vvQarkYMtT9poVupPw /4FUtdQvHwnN2gBJ+eBQ1b3tS4/aYYoW7fXhq7uBn38CGaZWCk9rITWkc3d7g2LCsOzi1ZKjtfl 6ODJYURXJYs67k5fcmlkLrvIKr3r99Ls7TBlm9HR5OFWs1GnIkxBUZU4m5m9fbvJaR9MsSPnWyQ g+5juJmej6zn+9X05Gi9svIZ+eDLcZ0U2/YKtz+KbS0SgwRww0BlsB1TZWvhoDcK+EteS4Wf2C3 NKm45KWSdj6YVMarhoA== X-Authority-Analysis: v=2.4 cv=G+0R0tk5 c=1 sm=1 tr=0 ts=6971e08c cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=6H0WHjuAAAAA:8 a=8BatEDlHAAAA:8 a=miy9QUiAF7RNB75P6oEA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=Soq9LBFxuPC4vsCAQt-j:22 a=tjV2R_ox5hktXOQLSeCq:22 X-Proofpoint-GUID: DygEj_j_XWaP6tiX6YhfDlYyapKwukvl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-21_04,2026-01-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 malwarescore=0 phishscore=0 adultscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601220056 On 1/21/26 9:06 PM, Dmitry Torokhov wrote: > On Wed, Jan 21, 2026 at 09:07:44AM +0100, Luca Weiss wrote: >> On Wed Jan 21, 2026 at 12:05 AM CET, Dmitry Baryshkov wrote: >>> On Mon, Jan 19, 2026 at 04:52:23PM +0100, Luca Weiss wrote: >>>> On Mon Jan 19, 2026 at 3:41 PM CET, Konrad Dybcio wrote: >>>>> On 1/16/26 3:22 PM, Luca Weiss wrote: >>>>>> Add a node for the Hall Effect sensor, used to detect whether the Flip >>>>>> Cover is closed or not. >>>>>> >>>>>> The sensor is powered through vreg_l10b, so let's put a >>>>>> regulator-always-on on that to make sure the sensor gets power. >>>>> >>>>> Is there anything else on L10B? Can we turn it off if the hall sensor >>>>> is e.g. user-disabled? >>>> >>>> It's the voltage source for pull-up of sensor I2C bus (so >>>> ADSP-managed?), DVDD for amplifiers and VDD for a most sensors like >>>> the gyro. >>>> >>>> So realistically, it'll probably be (nearly) always on anyways. And I >>>> don't want to shave another yak by adding vdd support to gpio-keys... >>> >>> Why? If it is exactly what happens on the board: the device producing >>> GPIO events _is_ powered via a vdd. Added Input maintainer / list to cc. >> >> Yes, the hall sensor which is connected to the GPIO on the SoC, has an >> extra VDD input which needs to be on in order for the Hall-effect sensor >> to be on. >> >> See page 133 "HALL" in the center of the page >> https://www.fairphone.com/wp-content/uploads/2025/08/Fairphone-Gen.-6_-Information-on-how-to-repair-dispose-of-and-recycle-EN-NL-FR-DE.pdf >> >> The IC is OCH166AEV4AD where VDD is (as expected) "Power Supply Input": >> https://www.orient-chip.com/Public/Uploads/uploadfile/files/20231014/1OCH166Adatasheet202203221.pdf > > If we add regulator support to gpio-keys do we expect it to be > per-gpio/per-key? Or we'd recommend splitting into several instances of > gpio-keys so that there is on set of supplies per gpio-keys device? gpio-keys {} is very broad and generic, I would imagine it would only make sense to keep it per-entry, like Luca suggested Konrad