From: Pavel Begunkov <asml.silence@gmail.com>
To: Byungchul Park <byungchul@sk.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel_team@skhynix.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, almasrymina@google.com, hawk@kernel.org,
toke@redhat.com
Subject: Re: [RFC net-next v2] netmem: replace __netmem_clear_lsb() with netmem_to_nmdesc()
Date: Mon, 11 Aug 2025 15:37:04 +0100 [thread overview]
Message-ID: <dfe92ca1-fdab-48f3-8410-e4435ab4f2f9@gmail.com> (raw)
In-Reply-To: <20250811042306.GA41974@system.software.com>
On 8/11/25 05:23, Byungchul Park wrote:
> On Sun, Aug 10, 2025 at 08:39:42PM +0100, Pavel Begunkov wrote:
>> On 7/29/25 11:41, Byungchul Park wrote:
>>> Changes from RFC:
>>> 1. Optimize the implementation of netmem_to_nmdesc to use less
>>> instructions (feedbacked by Pavel)
>>>
>>> ---8<---
>>> From 6a0dbaecbf9a2425afe73565914eaa762c5d15c8 Mon Sep 17 00:00:00 2001
>>> From: Byungchul Park <byungchul@sk.com>
>>> Date: Tue, 29 Jul 2025 19:34:12 +0900
>>> Subject: [RFC net-next v2] netmem: replace __netmem_clear_lsb() with netmem_to_nmdesc()
>>>
>>> Now that we have struct netmem_desc, it'd better access the pp fields
>>> via struct netmem_desc rather than struct net_iov.
>>>
>>> Introduce netmem_to_nmdesc() for safely converting netmem_ref to
>>> netmem_desc regardless of the type underneath e.i. netmem_desc, net_iov.
>>>
>>> While at it, remove __netmem_clear_lsb() and make netmem_to_nmdesc()
>>> used instead.
>>
>> I'll ultimately need this in another tree as indicated in the
>> original diff, so I'll take it into a branch and send it out
>
> Just curious. What is the original diff?
It was this one:
https://lore.kernel.org/all/a7bd1e6f-b854-4172-a29a-3f0662c6fd6e@gmail.com/
--
Pavel Begunkov
prev parent reply other threads:[~2025-08-11 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 10:41 Byungchul Park
2025-07-29 15:35 ` Mina Almasry
2025-08-10 19:39 ` Pavel Begunkov
2025-08-11 4:23 ` Byungchul Park
2025-08-11 14:37 ` Pavel Begunkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfe92ca1-fdab-48f3-8410-e4435ab4f2f9@gmail.com \
--to=asml.silence@gmail.com \
--cc=almasrymina@google.com \
--cc=byungchul@sk.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=kernel_team@skhynix.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®