From: Colin Ian King <colin.king@canonical.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: sun: remove redundant variables adv and lpa
Date: Thu, 5 Jul 2018 11:50:01 +0100 [thread overview]
Message-ID: <dfecea10-87b5-2110-6efb-02f46e7b4e2c@canonical.com> (raw)
In-Reply-To: <20180705.193315.2106014813802269928.davem@davemloft.net>
On 05/07/18 11:33, David Miller wrote:
> From: Colin King <colin.king@canonical.com>
> Date: Thu, 5 Jul 2018 10:37:32 +0100
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Variables adv and lpa are being assigned but are never used hence they
>> are redundant and can be removed.
>>
>> Cleans up clang warnings:
>> warning: variable 'lpa' set but not used [-Wunused-but-set-variable]
>> warning: variable 'adv' set but not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> I think you can safely remove the register reads too, so please
> do so.
Just to clarify, just the MII_ADVERTISE and MII_LPA, or both these AND
also MII_ESTATUS too?
>
> Thanks.
>
next prev parent reply other threads:[~2018-07-05 10:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 9:37 Colin King
2018-07-05 9:52 ` Dan Carpenter
2018-07-05 9:54 ` Colin Ian King
2018-07-05 10:01 ` Dan Carpenter
2018-07-05 10:33 ` David Miller
2018-07-05 10:50 ` Colin Ian King [this message]
2018-07-05 10:52 ` David Miller
2018-07-05 13:54 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfecea10-87b5-2110-6efb-02f46e7b4e2c@canonical.com \
--to=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®