From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752465AbeAXDdU (ORCPT ); Tue, 23 Jan 2018 22:33:20 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:35152 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752291AbeAXDdS (ORCPT ); Tue, 23 Jan 2018 22:33:18 -0500 Subject: Re: [PATCH-next] powerpc/fsl_pci: Use PTR_ERR_OR_ZERO To: =?UTF-8?Q?Christopher_D=c3=adaz_Riveros?= , benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, joe@perches.com, christian.koenig@amd.com, tyreld@linux.vnet.ibm.com, konrad.wilk@oracle.com, robh@kernel.org Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20180123203752.15057-1-chrisadr@gentoo.org> From: Tyrel Datwyler Date: Tue, 23 Jan 2018 19:33:10 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20180123203752.15057-1-chrisadr@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18012403-0044-0000-0000-000003D51881 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008417; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000247; SDB=6.00979476; UDB=6.00496456; IPR=6.00758782; BA=6.00005792; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00019175; XFM=3.00000015; UTC=2018-01-24 03:33:16 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18012403-0045-0000-0000-000008047CB4 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-24_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801240041 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/23/2018 12:37 PM, Christopher Díaz Riveros wrote: > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Christopher Díaz Riveros > --- Reviewed-by: Tyrel Datwyler > arch/powerpc/sysdev/fsl_pci.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c > index cc20d2255d7f..142184635c81 100644 > --- a/arch/powerpc/sysdev/fsl_pci.c > +++ b/arch/powerpc/sysdev/fsl_pci.c > @@ -1304,10 +1304,7 @@ static int add_err_dev(struct platform_device *pdev) > pdev->resource, > pdev->num_resources, > &pd, sizeof(pd)); > - if (IS_ERR(errdev)) > - return PTR_ERR(errdev); > - > - return 0; > + return PTR_ERR_OR_ZERO(errdev); > } > > static int fsl_pci_probe(struct platform_device *pdev) >