From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 458AE3905F9 for ; Thu, 2 Jul 2026 19:35:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783020926; cv=none; b=cnhK4Vycn+1APzzdM1pOcAfbojdClY8Fw7H8MXXz0PI2qFcnGFoC5NrHbqoX6xsLzRGsUm6hlGUJOCz4+r2Zg8FZ3HVthsQrDXznDGHQNUILmimwncg/uawDAtJMMsQLdH6KNWTJbt4THyFmTRVxbayVAHtkpZZ+5tr6ceGqSLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783020926; c=relaxed/simple; bh=I/ZM2OkT/dPa1GEft4QF0DUM5VH45Fd00jGx8xU90Tk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y9iv78ibbxwKrjkbrBqSgREjmjGKHcZb9jzq7EgKtHtAxhPskXiI1WukmyXgP+Tc+gvdcy3yu502Aa7c+RHhFDVLm3Sd3+UHkTJD2/T6/UDJ1jtwuvCpVRRkUHGVq6yceYOFYDtCj/5QkvVF4waWaKjo5oFGCXIm0Uz+8G7BUzo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=kD2FPudj; arc=none smtp.client-ip=209.85.161.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="kD2FPudj" Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-6a183eb9689so1416618eaf.1 for ; Thu, 02 Jul 2026 12:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783020921; x=1783625721; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I0Nc5U/TyB5elCjL6iCrBR8Ha+/073W6VQJdxK5d5a4=; b=kD2FPudjT55QuiJCXrPLRpbZ3HmHvNnvpuqzlsxJ3phuElCTdL+DxrJtVCvayT/4Tw Gjn2d8i6wHNMfX0uvmB10lLdsybBDReVP6fCCavrv2Dn676o9J+KPVc47HcZrswuxqvp teVl/fYWiqpJkCpoCggjrLoN75XYPcKTxNbQCHUXgiJGjM1YFZh679TY2lHc57iSgqiT oaNV9ESfCVvbL5hFPvs2H0IMFT8ORxsuwt0e7SmpVU3llLFcJRdA2XALXDqGHa4UgdrS GpyznobkdZW4HJ825qRyxCvUKuxUzakMKu+0D8vtVIZ/qTWQGfYt+SL+yoSQIWT/y3Ju vsAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783020921; x=1783625721; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I0Nc5U/TyB5elCjL6iCrBR8Ha+/073W6VQJdxK5d5a4=; b=kSnBMpvluoQWZSeRIPkqa04K2Ij5H11mSMI1pTCzigbDIdgK1rlEr65Geh7SJ30U2k h8gSz6DCYuf/b5SebSavnQCy85PXOEDPc1JQXElLt0vqet5rTUoT9cp3k2Vkkb8WrZMb YksYFC0GE209cHiNdvzxMUoNxcTCspZO97jt173JNEwX70yNqF/AQ1RaV3BJB14BunNE /9d4qNS2LuNe+csDUvzliCvL+3BdQg6eWND0DauO2V56jqiiFTWWO6LrFXJNq6Cz12po +mUN76Sz88S6eJSat5Yx/vHuJcNURMnEqXYZ29OkOwaULgyoXuQNBnIZs8VCXE9f4jM6 E7Xg== X-Forwarded-Encrypted: i=1; AFNElJ/NJ7UijS9wBWMRXiRsxkyNeK/N5an11Ijf4hQCI1us2mQoTRrPkA+onvwnmw2vC3UoZB+xzdhKESlyJwM=@vger.kernel.org X-Gm-Message-State: AOJu0YwFjRX2Zd5djtuWce2p/9ih8SnJlGEsawKxvUCvJ5exNpJjFXvV 9R9tjYYATKaHq1uo4q1Xcxx5XTCx0VByUgOwMbaxSTfB4djaMW5Uh2/BHr2P9im0meQ= X-Gm-Gg: AfdE7cntc/PiO3QdXJRSL8Jze3ui8Hz2zLv1duTMlkrQXb4MuX0ZhWabV3Hwo+nM6Mb KzV8mwxuo+qEIvQbIT5Pa346ygi3+5jqNoV/3b75qzOHb583JvVmpTfBka/egM0e3OIOkZLCdKD agGhXhkIMuon0w8nWAtgNSDtyqHLkoMgHiGWH1AnUArEn6Q02tyz9B/7EVoPQUUPWMo4KKvBj+K 9ENV/17Wog5aodqtbrTlLJZieiYO07MmwZC8Ul/VutHFGCbysjWfxpCQTJ5Dc3XsMLjjPaFLpyV 3kQLyyiggVPCE4pUzbiGRk/6WTARgJnfnwnhNnK8ZQ/tx6/e0MNtn3Wn45o3XCMKvUVd8HuyJI0 ecI3OZyFhmK4ZDXyDiTWrteCUv/pAKWZkxY5zKz5BbLllUZCG7MkYDQ4SRY9dcs2/PWU8uo9j3A lI3LV/pB+u1FbV0zbCe6oDGeGdgZEx+VWvFgtm1f+eLgbrKAgEx+tn/MAm82kQpI7ORlcfiB9S+ g== X-Received: by 2002:a05:6820:1888:b0:6a1:50ec:4401 with SMTP id 006d021491bc7-6a30d8fbd90mr4195250eaf.62.1783020921061; Thu, 02 Jul 2026 12:35:21 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:6a9f:626e:95c4:2a80? ([2600:8803:e7e4:500:6a9f:626e:95c4:2a80]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-44cbec93a70sm3938090fac.11.2026.07.02.12.35.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 12:35:20 -0700 (PDT) Message-ID: Date: Thu, 2 Jul 2026 14:35:20 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 1/3] dt-bindings: iio: adc: Add reference-source property To: Jonathan Cameron Cc: Kurt Borja , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260622-new-channel-props-v2-0-aafd5369f253@gmail.com> <20260622-new-channel-props-v2-1-aafd5369f253@gmail.com> <20260702202002.79c1be1b@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: <20260702202002.79c1be1b@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/2/26 2:20 PM, Jonathan Cameron wrote: > On Mon, 22 Jun 2026 14:40:10 -0500 > David Lechner wrote: > >> On 6/22/26 2:30 PM, Kurt Borja wrote: >>> Some ADCs have configurable voltage reference sources for each channel. >>> >>> Signed-off-by: Kurt Borja >>> --- >>> Documentation/devicetree/bindings/iio/adc/adc.yaml | 13 +++++++++++++ >>> 1 file changed, 13 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml >>> index b9bc02b5b07a4c7..fdad6b8276c934c 100644 >>> --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml >>> +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml >>> @@ -73,6 +73,19 @@ properties: >>> device design and can interact with other characteristics such as >>> settling time. >>> >>> + reference-source: >> >> Since this is an array, the name should be `reference-sources`. >> >>> + $ref: /schemas/types.yaml#/definitions/string-array >>> + maxItems: 2 >>> + minItems: 1 >> >> Maybe minItems here is OK, but I don't think we should put maxItems here. >> This way, it stays more flexible for other use cases. > > I'm curious. What other usecases did you have in mind? I didn't have something specific in mind, but in Kurt's ADS1263 series, we actually have a case with 3 values for this property already, ADC1 positive, ADC1 negative and ADC2. > >> >>> + description: >>> + Indicates the voltage reference source or sources for this channel. Some >>> + ADCs usually allow choosing between internal reference sources or a pair >>> + of external pins. >>> + >>> + If a single value is provided, it represents a single voltage reference >>> + source. If two values are provided, the first one corresponds to the >>> + positive source and the second to the negative source. >>> + >>> anyOf: >>> - oneOf: >>> - required: >>> >> >