From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 923633A7D98 for ; Fri, 24 Jul 2026 07:21:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784877715; cv=none; b=iIcyBKGh0x2qqSAJUiJofRcaNC8ttY/iU7oKAfUU3VtKdz/m+PPS3sNHw2nBZZNB1xRFbjQu7djBzIUmqRBD4jwOCTLFv3gWTS6KpUaK20y4Czo3Gze6UwRdwCHvy8TYgWeYaM+nd2oJBSJYNpB8xk48yvMgMvE19cPA2qtOD5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784877715; c=relaxed/simple; bh=T/mVtXFpRV/KFXPYmh4hS6FwTGtXktfC7N93Cv5SD2g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O0n08DeXtnOitqLT7qX+vYgMl4DWcfzkiMsvRLR9r0DrMc31PD9al+QEv03nIAWlB8Fb0vW+wMcIa8ZEyGDoDF4HlN+mtHERyi62m1u8kUlZHo5tFjtkqqYKICVtCh8UqhBH53EVKkl3I97e/QdN83YhaN5fEMTiDy/7GphIRuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mv60xMcP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aqsLLbez; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mv60xMcP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aqsLLbez" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66O4lHg31869015 for ; Fri, 24 Jul 2026 07:21:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QujMsYqHj01uukt0+i1dXgGQeV+hHQ+bjAtReQvTWPY=; b=mv60xMcPc/yPiVMB lWzfNxLu27HTGiW6xzh5RqvZYYPcLvGF0wImFbJa/3cKvstTxr9SC2OkXlNdpSHv XZiPbI2Mxmejo3G0hi1PJQm12H6+OtD28pS62v58Sr7aNN1jUrwCEcWGshq45FvZ IC7w68FwJvY3cArxQ4uCY1+m35+trdu5qYsg/5agCuqzMBvNAgG0yKaXhEGAcpW2 HwZ+pP1FTWpwGj2st5gU5Flflg+GIZaxANVUdtY8alSwC5sAbrOQ92e1Tk49uPfr LFDbGibRPvGgr6N6pBxcv9qGpZUn6npJAjl6VMqCQ//XOET5lSePLqAKjG3GpNpB Zu0aiw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fm0pw8n4w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Jul 2026 07:21:53 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2cce14a21faso2522925ad.0 for ; Fri, 24 Jul 2026 00:21:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784877712; x=1785482512; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QujMsYqHj01uukt0+i1dXgGQeV+hHQ+bjAtReQvTWPY=; b=aqsLLbez4LnUyNHyS63CnZVOnYwluvKm/N6riqyK0CvKyQIAywLJAHdOQuUgU0/tQA BE/gho1cKjWGKftJSxUxCXgTOzPZ4E/y2K0oDSlCohjWx3ujgb4qlWO2JKnr4yoylOkx jaYuokg/tpkYXsScetO8GPCHoNbNhXNlQiRwjsaoYZymdo6pcENoMxsI071YWK+iSijk ncYJCxmMJuUjVSfVoZD2lszOMGjMoPfIxrdID9ozOW9mHTtZ6MvcwRNHamblmUb2kWy2 WpAvSBWW2jMOzD2/IBxN2IlqEtJMqMZn7gSnNwTBtVznRCrIsoLrgx85sCKp1jfIcA+4 zwiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784877712; x=1785482512; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QujMsYqHj01uukt0+i1dXgGQeV+hHQ+bjAtReQvTWPY=; b=W4gOaqmkKfn7ZXyz+8lRdbg2t2Q4D+GffGgFdzp6tFvbN0/shw/0Bb6UF5f442fhlN rd4G8RH++SaC1J1UplQ/nMeLJ6sBvkInHPx/DzyZnlR320KtL1vEB4xwq2ixiseuouLT 1Dq/vVx4YEPKJKYASrqSi8XgSkgn8l4tzpZwcHnMldoC50lusIMJb2QYjSEEAPV1Agsg 247uk1U/hDKl4Eg0fmUIWJQiFrQmEye34erL1wEdL6SHD4EKB5jit96GeUn9jGZoqutq brLo0g675pu2pHfE7xp4gMNTEKiaPOo7+IHephopfCPuH6u3RT9QOrnvE6qh5GSaHeMG Iw7g== X-Forwarded-Encrypted: i=1; AHgh+RoKZTkLAz/j4PSMc+m88RRH59kmFMRrtN9/RwK1Y3doYBoFmaYBNnWULFlpHSa/XE/QF56kl6OAFAD3sI8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzbvvi7stXCM+jLxhQKWPfb8p/9eiDaufvvwxYNFqhsxKJAhtPw N0az2JGemxUwAXxBlj0CIrOKAYzhtss9Xrxy7vq3njoizXlOPWwSWWY8quPGil71D75Gse1TTpX /D6YWT8Dcrnd//CkSPF7U/TdcCTMt/WKBmDCbW42KrOArbosibzVk9d6ycVoJbW9Kv4Q= X-Gm-Gg: AR+sD11ztJoWHXQwbveViSHfcVEV8fKTYUNhcawLd2vAjytzRU5/0tfAd4FAvI65MtB e+vnfJLcm65z8wTseCLg+79bErz05PqYpTP90FEISpbbdvy06S4L1xB3JJ5JgH3eKd9i/W+JLD6 jltNr5zI7+lPe3BIgSo249KTJdqcx54l7K9Hh3gcaTNQKzBM0zjuT+cVbUZdC0i/LlMBJ+uzI7c p5kmXtdXn/LXACSdxuCHGqsWpBGSl6/TspBtFCylVLmdyFsJNqEsaq+RDhf+AJnzIkeJqLSQ/J3 UsAbQ/9mrNHKtJr6CSePxxCPDUztIoQGf2Mgy5aFFUUkPuJJLsspAzHwJnELQuCV+CuHG4h09Z5 gNuIdsmFn+B41zkjHEy1BXkjzEwZTEpc= X-Received: by 2002:a17:903:2987:b0:2ca:53f7:3c69 with SMTP id d9443c01a7336-2cfa9452b51mr64444695ad.9.1784877712142; Fri, 24 Jul 2026 00:21:52 -0700 (PDT) X-Received: by 2002:a17:903:2987:b0:2ca:53f7:3c69 with SMTP id d9443c01a7336-2cfa9452b51mr64444505ad.9.1784877711665; Fri, 24 Jul 2026 00:21:51 -0700 (PDT) Received: from [10.217.252.136] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f39064bsm47642475ad.76.2026.07.24.00.21.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 00:21:51 -0700 (PDT) Message-ID: Date: Fri, 24 Jul 2026 12:51:23 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] Bluetooth: qca: add QCC2072 support To: Dmitry Baryshkov Cc: Luiz Augusto von Dentz , Krzysztof Kozlowski , Marcel Holtmann , Bartosz Golaszewski , Conor Dooley , Rob Herring , Bjorn Andersson , Konrad Dybcio , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, quic_hbandi@quicinc.com, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, quic_anubhavg@quicinc.com, quic_mohamull@quicinc.com References: <20260723-rb3-industrial-bt-uart-v1-0-3c8e580c09d1@oss.qualcomm.com> <20260723-rb3-industrial-bt-uart-v1-1-3c8e580c09d1@oss.qualcomm.com> Content-Language: en-US From: Rahul Samana In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDA2NSBTYWx0ZWRfXyY0eim7/SiZg O5RsMv7NOBCmnPFOMAEJod6BfUuZpqE5EzxisqNyfynkIR6mPRTT5sR+A976Aea8rhoGQDC5cJC Bsvc2Y4Owa/zpXr8FaCDSUoMLpljMa61oHTyCzlT6ch7XtDa5YzK1I7+/TEpW9EJQI4N87RoFJ0 aeTEML2+0DwL9iFFuKKO3RAt44r1RvtwOe89Yy9ikIna3ClBBY88NIgENDc1xv7we25TneWLOBD /FU4ZgxOCrQ9pNJ3wh33VaYesnhhPnpY987ff9+n4aQbFuv5XdCKy1mnvrqsxzzoZIG6wehEvVM HG/8+VEO6mRVfgs6flm8eJqXTkFOrIBT5euhEYzaCfQvn/2gSJpUMehs3Sg9YO71ahMmFkZ1/Qu deyWAaXNPNF3DTK33Q8+aPq/c0Rh16WHpCF7wv4ljvzTBVmJwrMXxF07WUipM/w1Vqyxls8X5MM JfLz2IzmwQ+27AVHGXA== X-Authority-Analysis: v=2.4 cv=RJeD2Yi+ c=1 sm=1 tr=0 ts=6a631291 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=LlWMOfBPVhFVXrbsjUAA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: 2WxRkDVve4IRFJESSN82zDE-JGx4cfa3 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDA2NSBTYWx0ZWRfX9ZHzff8rDEWm PF+i7QtoY5OsYDyI+Sc4sAZ9eki/77yQAbgUfe8fyaTDJQ0ANWe0TeL+AHzR2M8ue13gUGUhxjK E2spbie+F4+aG4hgc3AM/3Kxg2UmQ0g= X-Proofpoint-GUID: 2WxRkDVve4IRFJESSN82zDE-JGx4cfa3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-24_01,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 phishscore=0 bulkscore=0 impostorscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240065 On 24-07-2026 00:36, Dmitry Baryshkov wrote: > On Thu, Jul 23, 2026 at 06:01:07PM +0530, Rahul Samana wrote: >> Add QCC2072 as a supported Qualcomm Bluetooth controller. >> >> QCC2072 uses the ORN firmware and NVM naming scheme. Select the NVM file >> and BCS calibration file using the controller board ID when available, >> with fallback to the default files. >> >> Register the QCC2072 compatible with hci_qca and route it through the >> same UART setup, speed switching and power-control paths as recent >> Qualcomm Bluetooth controllers. >> >> Signed-off-by: Rahul Samana >> --- >> drivers/bluetooth/btqca.c | 70 ++++++++++++++++++++++++++++++++++++++++++++- >> drivers/bluetooth/btqca.h | 2 ++ >> drivers/bluetooth/hci_qca.c | 24 ++++++++++++++++ >> 3 files changed, 95 insertions(+), 1 deletion(-) > > I think you are a third engineer who submits a patch with this name and > with no mentions of the previous work. Are you working in parallel with > no idea what other team is doing, are you ignoring the previous work and > implementing it from scratch or are you picking up a patch made by > somebody else and killing the authorship / SoB tags? > > Hi Dmitry, You are right, we should have called out the prior work explicitly. This series is intended to continue the QCC2072 enablement work previously posted by Vivek Sahu and Yepuri Siddu, not to replace it without attribution. Vivek posted the initial QCC2072 binding and driver support up to v5: https://lore.kernel.org/all/20260218114955.3970974-1-vivek.sahu@oss.qualcomm.com/ The driver part had received review, while the binding side still had open comments. Since Vivek was no longer available to continue the series, the work was picked up by Siddu. Siddu then posted a follow-up series for the reworked RB3 Gen 2 Industrial BT-over-UART use case, adding the QCC2072 DT binding, extending the driver support with NVM + BCS calibration handling, and adding a card-specific DT overlay for the M.2 E-key slot populated with QCC2072: https://lore.kernel.org/all/20260529175342.3363935-1-yepuri.siddu@oss.qualcomm.com/ https://lore.kernel.org/all/20260529175822.3366535-1-yepuri.siddu@oss.qualcomm.com/ https://lore.kernel.org/all/20260529180234.3373056-1-yepuri.siddu@oss.qualcomm.com/ https://lore.kernel.org/all/20260529180431.3373856-1-yepuri.siddu@oss.qualcomm.com/ That series used the older card-specific overlay approach and was also sent as separate unthreaded patches. Based on the review feedback there, and because the M.2 power sequencing work was being upstreamed, we decided to carry the work forward as a new b4-managed series aligned with the M.2 power sequencing model. The driver patch in this series is therefore based on the previous QCC2072 enablement work, with additional changes needed for our tested RB3 Gen 2 Industrial setup: board-id based NVM selection and combining the BCS calibration TLV with the selected NVM before download. I should have documented this lineage in the cover letter and preserved the authorship / Co-developed-by / Signed-off-by tags appropriately. I will fix that in v2 and make the provenance clear in both the cover letter and the affected patches. We will make sure to follow this through and address the review comments properly in the next revisions. Thanks for pointing this out. Regards, Rahul